From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BEC8C6FA82 for ; Sun, 4 Sep 2022 17:35:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BB3A780190; Sun, 4 Sep 2022 13:35:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B63EA8D0031; Sun, 4 Sep 2022 13:35:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A059580190; Sun, 4 Sep 2022 13:35:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8F72F8D0031 for ; Sun, 4 Sep 2022 13:35:23 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0E1E780413 for ; Sun, 4 Sep 2022 17:35:23 +0000 (UTC) X-FDA: 79875104526.17.8DDB824 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 496271C006C for ; Sun, 4 Sep 2022 17:35:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662312921; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0OqCRc2qTCkhbyWvO/JaR0is+0EHj7fynFanwSBHTbQ=; b=g55q3mMAw2pGfx/7ij48D2XPwzRkxq542z6pl0lyKZtUs+wBbrLo2khEoaASjj71Syx+Hd v4YJc0rRXyaQ9xel57OgR87ZeqrvTJMPLOtgUHaOpaT8sJz9XHPBoWwhZwt9yxLKfAAQjy yOyJpZhHZCHjCokuVSpsfv09CrVwznc= Received: from mail-il1-f199.google.com (mail-il1-f199.google.com [209.85.166.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-580-9Ab3jZHdNx2GV3_dxN5OtQ-1; Sun, 04 Sep 2022 13:35:20 -0400 X-MC-Unique: 9Ab3jZHdNx2GV3_dxN5OtQ-1 Received: by mail-il1-f199.google.com with SMTP id d6-20020a056e020be600b002dcc7977592so5654700ilu.17 for ; Sun, 04 Sep 2022 10:35:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=o0ARc/WsfLgkgJVA1xQtlIt2FlJwc8l8B0ov9VDgSZU=; b=ageZMXRlem6c6voF4RwPqrgLCsh7Ot0qeNt2xirOT0M3nM/MCOcvYRsAAGxhF32H03 YiOwqxN1/DXVnaYtbDE1Rbh+WQ4t26AFG6iQTAbMK+0Hkg+BgggE+LHg142QUgbByXMy mOXTD7uFXjub50MyZBAPxRA2CEFYuGJSMx/C1BBYcltzWuCl/P58cbul86+XYConMMsb bo9D6CyeU71q2aq187YGAKAgKqT4OGxORsaJrdgXFN1x6441PC3pWsUbo2eTXxBfph/c mkomEbDZmQ8OMNwSyFReBCo7vCo8zfz46srtKQKy2R6Q57ML85UPyqZMk8JlpRv7DQBa 95mQ== X-Gm-Message-State: ACgBeo3SNDtypDD/XwkpfipL/MGmOhgbE7My8tblnk5XPygtMvDazMIo ADzzMetQqKOMKSXJ6tPb8S1OD6a72S9rlsi8U2agHzaJjn+37zbRnyCGoji1OULXxOQ+sJP9Fe7 ay8clRIxvqkY= X-Received: by 2002:a6b:770e:0:b0:688:9297:e935 with SMTP id n14-20020a6b770e000000b006889297e935mr21329992iom.164.1662312919418; Sun, 04 Sep 2022 10:35:19 -0700 (PDT) X-Google-Smtp-Source: AA6agR55bK95xzwJWsOxsdk9YsYFHz/+OuTCfwiDRbd2xAGrS8TSK8/ZFU0XrUpt79PfC0wXIhBzaA== X-Received: by 2002:a6b:770e:0:b0:688:9297:e935 with SMTP id n14-20020a6b770e000000b006889297e935mr21329986iom.164.1662312919123; Sun, 04 Sep 2022 10:35:19 -0700 (PDT) Received: from xz-m1.local (bras-base-aurron9127w-grc-35-70-27-3-10.dsl.bell.ca. [70.27.3.10]) by smtp.gmail.com with ESMTPSA id w137-20020a022a8f000000b00349f5cba87dsm3286746jaw.12.2022.09.04.10.35.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Sep 2022 10:35:18 -0700 (PDT) Date: Sun, 4 Sep 2022 13:35:16 -0400 From: Peter Xu To: kernel test robot , Andrew Morton Cc: kbuild-all@lists.01.org, Linux Memory Management List , Andrew Morton , "Huang, Ying" Subject: Re: [linux-next:master 4318/4736] arch/x86/mm/init.c:1057:15: warning: no previous prototype for 'arch_max_swapfile_size' Message-ID: References: <202209030759.1ODqXm2p-lkp@intel.com> MIME-Version: 1.0 In-Reply-To: <202209030759.1ODqXm2p-lkp@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="oZ/S/NxrU6VZ5kui" Content-Disposition: inline ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=g55q3mMA; spf=pass (imf21.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662312922; a=rsa-sha256; cv=none; b=i592reU0gkIsSy3FgM5SMQJ3pGJ0XeNXrdxLEwW6nP7ItMwQU8ivNnAgOJxfYy5RA+MLH2 bvLknqHxnzQSqX3oMzrTlMT45PipJGzlJ68gRRPf2KIOTeuh3rnMB3VSWJ6sAS4NWeAcY7 Lln5zzNzbSvRHHWhZnGtHKW4BlM7nuU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662312922; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0OqCRc2qTCkhbyWvO/JaR0is+0EHj7fynFanwSBHTbQ=; b=4DiqkuJw+MoGxZqa0uQ+P5+igMRNMacgcHiMwf+QMOqY3ghIxYiPxysi0debc2eMTs3z7D kkUx3glPrTBE+aTxRN9TUXnlKEbnR+mJ4eFpUDuKeqtx7TwihZMxPvY9m9EaLihnrZMig6 MZ3qlOv0bODPoXZeoJKGan52SVuYTwI= X-Rspamd-Queue-Id: 496271C006C Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=g55q3mMA; spf=pass (imf21.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: n9cqy8f3qjw4ewk3n64kro7immethy1t X-HE-Tag: 1662312922-6724 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --oZ/S/NxrU6VZ5kui Content-Type: text/plain; charset=utf-8 Content-Disposition: inline On Sat, Sep 03, 2022 at 07:32:02AM +0800, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: e47eb90a0a9ae20b82635b9b99a8d0979b757ad8 > commit: c21e4d92cbb920b50a809409bc56c6ca4f09e7bf [4318/4736] mm/swap: cache maximum swapfile size when init swap > config: x86_64-randconfig-a011 (https://download.01.org/0day-ci/archive/20220903/202209030759.1ODqXm2p-lkp@intel.com/config) > compiler: gcc-11 (Debian 11.3.0-5) 11.3.0 > reproduce (this is a W=1 build): > # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=c21e4d92cbb920b50a809409bc56c6ca4f09e7bf > git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > git fetch --no-tags linux-next master > git checkout c21e4d92cbb920b50a809409bc56c6ca4f09e7bf > # save the config file > mkdir build_dir && cp config build_dir/.config > make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash arch/x86/mm/ mm/ > > If you fix the issue, kindly add following tag where applicable > Reported-by: kernel test robot > > All warnings (new ones prefixed by >>): > > >> arch/x86/mm/init.c:1057:15: warning: no previous prototype for 'arch_max_swapfile_size' [-Wmissing-prototypes] > 1057 | unsigned long arch_max_swapfile_size(void) > | ^~~~~~~~~~~~~~~~~~~~~~ > -- > >> mm/swapfile.c:2820:22: warning: no previous prototype for 'arch_max_swapfile_size' [-Wmissing-prototypes] > 2820 | __weak unsigned long arch_max_swapfile_size(void) > | ^~~~~~~~~~~~~~~~~~~~~~ > > > vim +/arch_max_swapfile_size +1057 arch/x86/mm/init.c > > 1055 > 1056 #ifdef CONFIG_SWAP > > 1057 unsigned long arch_max_swapfile_size(void) > > -- > 0-DAY CI Kernel Test Service > https://01.org/lkp Hi, Andrew, The oneliner patch fixes the issue for me, which is attached. The patch to squash in is within the subject after "fixup: " (ff516092aa69 ("mm/swap: cache maximum swapfile size when init swap", 2022-09-02)). Thanks, -- Peter Xu --oZ/S/NxrU6VZ5kui Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0001-fixup-mm-swap-cache-maximum-swapfile-size-when-init-.patch" >From 99ce98e66d67ecadc6a73791aa425d76155a9f59 Mon Sep 17 00:00:00 2001 From: Peter Xu Date: Sun, 4 Sep 2022 13:31:38 -0400 Subject: [PATCH] fixup! mm/swap: cache maximum swapfile size when init swap Content-type: text/plain Signed-off-by: Peter Xu --- include/linux/swapfile.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/swapfile.h b/include/linux/swapfile.h index 75fc069594a5..29182dfc0cc7 100644 --- a/include/linux/swapfile.h +++ b/include/linux/swapfile.h @@ -10,6 +10,7 @@ extern spinlock_t swap_lock; extern struct plist_head swap_active_head; extern struct swap_info_struct *swap_info[]; extern unsigned long generic_max_swapfile_size(void); +extern unsigned long arch_max_swapfile_size(void); /* Maximum swapfile size supported for the arch (not inclusive). */ extern unsigned long swapfile_maximum_size; /* Whether swap migration entry supports storing A/D bits for the arch */ -- 2.32.0 --oZ/S/NxrU6VZ5kui--