From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DD86C54EE9 for ; Sat, 3 Sep 2022 01:54:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 305D180149; Fri, 2 Sep 2022 21:54:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B51280120; Fri, 2 Sep 2022 21:54:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 17D1A80149; Fri, 2 Sep 2022 21:54:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 046FB80120 for ; Fri, 2 Sep 2022 21:54:32 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D2E9940F79 for ; Sat, 3 Sep 2022 01:54:31 +0000 (UTC) X-FDA: 79869104742.23.D550B1E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf19.hostedemail.com (Postfix) with ESMTP id D919E1A0043 for ; Sat, 3 Sep 2022 01:54:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662170070; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7/7DBGJSieMRSq3PvqiiqdK55MV/k943DFwkDvzV0EQ=; b=HSm5oTnfl5hLktQwcV1swkhB7oJCszusF8iE2uTXO3TqeuaD4h/XJ39HSUlfUFWENjxrSG ad/qO3VW0DFn5ROm3SW8B2MpyvFxPfRhqATyp8+wtYsl5cBqiJ8sZhAc9yOnNiTAPbf6fv f0UnuVH9z8rmdIrBYUJqyQY8Glta/NY= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-540-6ihJcg9xM_GIPhKpbdorfQ-1; Fri, 02 Sep 2022 21:54:28 -0400 X-MC-Unique: 6ihJcg9xM_GIPhKpbdorfQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DC08D29AA3B3; Sat, 3 Sep 2022 01:54:27 +0000 (UTC) Received: from localhost (ovpn-12-81.pek2.redhat.com [10.72.12.81]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 54FBB1415125; Sat, 3 Sep 2022 01:54:25 +0000 (UTC) Date: Sat, 3 Sep 2022 09:54:22 +0800 From: Baoquan He To: Uladzislau Rezki Cc: Song Liu , Andrew Morton , Linux-MM , open list , Song Liu Subject: Re: [PATCH] mm/vmalloc: Extend find_vmap_lowest_match_check with extra arguments Message-ID: References: <20220831052734.3423079-1-song@kernel.org> <20220831160111.a6e7d17785ca21ce7c43981c@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662170071; a=rsa-sha256; cv=none; b=iQDBtzsNL9L+7nBKXWoLoP2QKPP2eEJ9aWk68bOAM81CfSu8ZQgMhY7pBY6A+A5HGP8Sjo k66/Ng2nyrQYsLn+AgaM7a/UXoEzvShu/cXkgNTR3HEse65jCtCbUnBMK+ygBFeXuqICYa xw90nk67VQuDgNeRJyMW8Jef1dto66M= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HSm5oTnf; spf=pass (imf19.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662170071; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7/7DBGJSieMRSq3PvqiiqdK55MV/k943DFwkDvzV0EQ=; b=m4g8wbiAJh+ObY+90MG3KgCYVbbMzBdkZS+TzFsmrBVq66rO8ukThU9XJoj99vaoGNxCPb BfV99pPaqP+gRX+lvqQPTvQrivX7n1AomyLf2Hdd18KbZMU5seO+4lgzjswQenhvN60otI 93B4tgbUdubRhxaclxz4oDy5XosjP0U= X-Stat-Signature: 19pacw31f5s7wym684jhtf4yef3z7tm4 X-Rspamd-Queue-Id: D919E1A0043 X-Rspam-User: Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HSm5oTnf; spf=pass (imf19.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam01 X-HE-Tag: 1662170070-107207 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 09/02/22 at 06:45pm, Uladzislau Rezki wrote: > > > Even without this patch, the debug path would work correctly. The > > > difference is just only in > > > whether roots are hardcoded or passed over function paramter. > > > > Calling find_vmap_lowest_match() inside find_vmap_lowest_match_check() > > will fail compilation because the function interface has been changed. > > > Ah. That makes sense, though the commit message has to reflect it. > So it is only about compilation error if debug is ON. Indeed, the current patch log sounds like an improvement or normal change. In fact it's a code fix.