From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10D01C6FA82 for ; Fri, 2 Sep 2022 20:35:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6ABAA8012A; Fri, 2 Sep 2022 16:35:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 65B7B80120; Fri, 2 Sep 2022 16:35:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 522DD8012A; Fri, 2 Sep 2022 16:35:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4455180120 for ; Fri, 2 Sep 2022 16:35:53 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0FE0980549 for ; Fri, 2 Sep 2022 20:35:53 +0000 (UTC) X-FDA: 79868301786.13.A813482 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 7DD1F40048 for ; Fri, 2 Sep 2022 20:35:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662150952; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fn+Zoib7z+3jWmLDklpcVUHy37Y7jPpJPmAY6A3wSS4=; b=EUBE6q1XBNfPmHpqV9iK4CAr3YVmw2q8Hvb16kUSWbBhctMGRmUb5xfMsCA0n0kMdeJtVj mmpJ9FSK275fcJzdIiASnv1ZuDFrWlyaR5uM58tiL5TJT+h4ERLGk4RtmRQE7nsUsgpbqY nH+fj6xbj5wL+309RbRqfY/U9a0lII8= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-103-M-UB0zI-NcGo4rGuTWGiMA-1; Fri, 02 Sep 2022 16:35:51 -0400 X-MC-Unique: M-UB0zI-NcGo4rGuTWGiMA-1 Received: by mail-qk1-f199.google.com with SMTP id n15-20020a05620a294f00b006b5768a0ed0so2811502qkp.7 for ; Fri, 02 Sep 2022 13:35:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=fn+Zoib7z+3jWmLDklpcVUHy37Y7jPpJPmAY6A3wSS4=; b=6SS9HVpiu+FRmQi3bAE3HK/zIVB/xyjwcaI7FjHBG+AWpe28NBtc/EOuPNyNM39iez eKPs+KgDrD2E4yDOk6IMB2oyUbIzWG5U5hN2zOVFzLbIf7rElaHTi0EO0y/7vuj7iOYU PNTmHA1HrzdDK7kGzqS+TICsQQYACmPvD2UmRENTjAvKtu1EO5n3iJM5c1sPlLuLEHIv xPJ2gAQoHpkh/itrMNneQzblXujHQn1CKOrjUxXBgCC5NjKb5oTjdEgnTaUGnPl/HMet 4srrxj6SH58em44K3i6Uw96vqgxGpQ8Xj7hERAfHExAu+MfWXsNxFC50b+FQKiMijuud gwMg== X-Gm-Message-State: ACgBeo1wLyv4Fk9TmL95xNt0h4IWDZ96kyMkdO9L7ZbpBQykp8E7TX+U 6wNy94Ej4fpYcKHQB9U1AgGYZDaAFiw2kOscCaabc8LzCPLJpqT0T2f4chPEnrmwF3TCjJTBhMq hI7nDA2icUgk= X-Received: by 2002:a05:6214:cca:b0:499:216a:bb53 with SMTP id 10-20020a0562140cca00b00499216abb53mr12361602qvx.98.1662150950658; Fri, 02 Sep 2022 13:35:50 -0700 (PDT) X-Google-Smtp-Source: AA6agR6kIdR84rwbeR6TPg15NwPgQnYmK4+injhS/K8qL1Ci4QeM6ILUyA6WUnfYAugNgzwk5mCQRQ== X-Received: by 2002:a05:6214:cca:b0:499:216a:bb53 with SMTP id 10-20020a0562140cca00b00499216abb53mr12361578qvx.98.1662150950432; Fri, 02 Sep 2022 13:35:50 -0700 (PDT) Received: from xz-m1.local (bras-base-aurron9127w-grc-35-70-27-3-10.dsl.bell.ca. [70.27.3.10]) by smtp.gmail.com with ESMTPSA id i7-20020a05620a404700b006b5cc25535fsm2262614qko.99.2022.09.02.13.35.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Sep 2022 13:35:50 -0700 (PDT) Date: Fri, 2 Sep 2022 16:35:47 -0400 From: Peter Xu To: Alistair Popple Cc: linux-mm@kvack.org, akpm@linux-foundation.org, Nadav Amit , huang ying , LKML , "Sierra Guiza, Alejandro (Alex)" , Felix Kuehling , Jason Gunthorpe , John Hubbard , David Hildenbrand , Ralph Campbell , Matthew Wilcox , Karol Herbst , Lyude Paul , Ben Skeggs , Logan Gunthorpe , paulus@ozlabs.org, linuxppc-dev@lists.ozlabs.org, "Huang, Ying" , stable@vger.kernel.org Subject: Re: [PATCH v4 1/4] mm/migrate_device.c: Flush TLB while holding PTL Message-ID: References: <9f801e9d8d830408f2ca27821f606e09aa856899.1662078528.git-series.apopple@nvidia.com> MIME-Version: 1.0 In-Reply-To: <9f801e9d8d830408f2ca27821f606e09aa856899.1662078528.git-series.apopple@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662150952; a=rsa-sha256; cv=none; b=ARyCPNL5jHAv5gn05ceT+bFe00+SEZRZ1znLiT6D8Q2MmaWmXAoP0QJypdiaEk3CGwQX51 XUM/YXSc5tgsImRwDp81Tf856EVY2uaT/3KqmF+Jscho5INHYNMDlpHs3x1Izm7VGHpWKj +LW/KZPh4VOzmhmHTJv1trGE+zq57qU= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EUBE6q1X; spf=pass (imf11.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662150952; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fn+Zoib7z+3jWmLDklpcVUHy37Y7jPpJPmAY6A3wSS4=; b=51fcT1VTFweJSAcXflUNb7Mb2uTSDzxQzFSXyJnmnqpQVWWOr5crT9HXxN7jApo78S7yxG u7pFCJH6YV/mHrCniWpJISSPdNNvLfjsGkWi2BNKbFesalnOir2G98COSudRRJsWxVAmOm a1r3TmUgu06vvVsCP5DSO9yHr9/yJKE= Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EUBE6q1X; spf=pass (imf11.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Stat-Signature: wpm8r66sxcauyrfi5imctxjih1ia7hbc X-Rspamd-Queue-Id: 7DD1F40048 X-Rspamd-Server: rspam04 X-Rspam-User: X-HE-Tag: 1662150952-958045 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 02, 2022 at 10:35:51AM +1000, Alistair Popple wrote: > When clearing a PTE the TLB should be flushed whilst still holding the > PTL to avoid a potential race with madvise/munmap/etc. For example > consider the following sequence: > > CPU0 CPU1 > ---- ---- > > migrate_vma_collect_pmd() > pte_unmap_unlock() > madvise(MADV_DONTNEED) > -> zap_pte_range() > pte_offset_map_lock() > [ PTE not present, TLB not flushed ] > pte_unmap_unlock() > [ page is still accessible via stale TLB ] > flush_tlb_range() > > In this case the page may still be accessed via the stale TLB entry > after madvise returns. Fix this by flushing the TLB while holding the > PTL. > > Signed-off-by: Alistair Popple > Reported-by: Nadav Amit > Reviewed-by: "Huang, Ying" > Fixes: 8c3328f1f36a ("mm/migrate: migrate_vma() unmap page from vma while collecting pages") > Cc: stable@vger.kernel.org Acked-by: Peter Xu -- Peter Xu