From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72B2CC6FA82 for ; Fri, 2 Sep 2022 20:39:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EEABD8012B; Fri, 2 Sep 2022 16:39:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E9A0780120; Fri, 2 Sep 2022 16:39:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D3A7B8012B; Fri, 2 Sep 2022 16:39:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C10F680120 for ; Fri, 2 Sep 2022 16:39:11 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 97A75A0774 for ; Fri, 2 Sep 2022 20:39:11 +0000 (UTC) X-FDA: 79868310102.18.3886B04 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf09.hostedemail.com (Postfix) with ESMTP id 2CE6F140063 for ; Fri, 2 Sep 2022 20:39:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662151150; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xJ0Qu9XWFO4UUk4rWqs9r8O8v+oRQvUvbXP0h2FgBJE=; b=izfspim21vDPLupFqueqrPW667+f/C6/3ewkOm4ko9xHknZytG2H/QejfgaWNKf833ASvO AFtZsAvlUqo6XA7Kgf87/aC9NXhUSLI55nEeBrHiTUzNiwzgD8yPhgUQtWy76xktQL7G5A EEVpkGYe2ER9J4qGetvKSHNPk10/17c= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-627-HQAUJV82Mf6ifFDySEY_iw-1; Fri, 02 Sep 2022 16:39:07 -0400 X-MC-Unique: HQAUJV82Mf6ifFDySEY_iw-1 Received: by mail-qv1-f70.google.com with SMTP id cz3-20020a056214088300b00498f11a6d8aso1982037qvb.11 for ; Fri, 02 Sep 2022 13:39:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=xJ0Qu9XWFO4UUk4rWqs9r8O8v+oRQvUvbXP0h2FgBJE=; b=Nlvqh3H53n7kzdGaMcIWxJE36ygf6sEJW+4DMJRIP6q3+w+c3hxeVGFG7btOLmzpNI iIxLP7CzHAv1SxILZNRxauz7EEB8SARICJrMHEOFGzQCBvjrFizA0Zt+1kDsfGbyeyJC M3CabgGDP657BPu4eVxgCyn9Ujb4UbHQVKcgS5XaHJLhiGDIGPDGKlza1cBMtiFjle4V /OEhVZjD0REz3P/0o4beSNULR+6PMEseCFDd6s1eyuP5deCID6d2E/O27aiUjQXE1YE8 Js00l1twy0r4AQRzQhlf2bZDnMIZPi9eTqOBUdTDt+KzCy0bilWcFgJOfl2OE9Lwz21I jKFA== X-Gm-Message-State: ACgBeo2wyfFR7k5TFk0SpbWOCPRVAWHfyGxU6nM18/Fb4pfJ7llM74UH avSRRhIPn4ojc2jA8twFam5bi5zarck/JtWFJllzGUg68Bu8auHBL1zH8xOK+e3gsSZFc/z27jF oKvP5mhFQZvs= X-Received: by 2002:a05:6214:4005:b0:474:3c94:cdc2 with SMTP id kd5-20020a056214400500b004743c94cdc2mr30020612qvb.17.1662151147436; Fri, 02 Sep 2022 13:39:07 -0700 (PDT) X-Google-Smtp-Source: AA6agR7YMrtikm013gR4JTLQQoN5gVOE4hUudLnV6FSgJBznRd/8l8hCsLr/ALJPQCQnci+l7e2+tQ== X-Received: by 2002:a05:6214:4005:b0:474:3c94:cdc2 with SMTP id kd5-20020a056214400500b004743c94cdc2mr30020592qvb.17.1662151147191; Fri, 02 Sep 2022 13:39:07 -0700 (PDT) Received: from xz-m1.local (bras-base-aurron9127w-grc-35-70-27-3-10.dsl.bell.ca. [70.27.3.10]) by smtp.gmail.com with ESMTPSA id l3-20020ac80783000000b00342fcdc2d46sm1725995qth.56.2022.09.02.13.39.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Sep 2022 13:39:06 -0700 (PDT) Date: Fri, 2 Sep 2022 16:39:04 -0400 From: Peter Xu To: Alistair Popple Cc: linux-mm@kvack.org, akpm@linux-foundation.org, Nadav Amit , huang ying , LKML , "Sierra Guiza, Alejandro (Alex)" , Felix Kuehling , Jason Gunthorpe , John Hubbard , David Hildenbrand , Ralph Campbell , Matthew Wilcox , Karol Herbst , Lyude Paul , Ben Skeggs , Logan Gunthorpe , paulus@ozlabs.org, linuxppc-dev@lists.ozlabs.org, stable@vger.kernel.org Subject: Re: [PATCH v4 2/4] mm/migrate_device.c: Add missing flush_cache_page() Message-ID: References: <9f801e9d8d830408f2ca27821f606e09aa856899.1662078528.git-series.apopple@nvidia.com> <5676f30436ab71d1a587ac73f835ed8bd2113ff5.1662078528.git-series.apopple@nvidia.com> MIME-Version: 1.0 In-Reply-To: <5676f30436ab71d1a587ac73f835ed8bd2113ff5.1662078528.git-series.apopple@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662151151; a=rsa-sha256; cv=none; b=sNy5QPETiV//iomDavIQnJQU2ELXlbN6llR+peKGHr3NeLrx0cp+TS2gc75hfyMGZbXybs YHBuq89bU5KZzoBMZvQAOrlDIvNVD6NBccFb9wO8utBnHFv6Xskle8Wk1uml/syvH+F2AX OaVMy9iTJVpFHPfIn0rJTegzSEkqqqs= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=izfspim2; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf09.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662151151; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xJ0Qu9XWFO4UUk4rWqs9r8O8v+oRQvUvbXP0h2FgBJE=; b=4VstDiB3I/y0r7Bp+SMbnpOkLc2uwr8F7qvFKh4Nm2owA7lFmGeJlzpL30JayHQ8DLYVrJ 77jc2AC93lieXByU9Edwa0K9Vc6qV+jRFbFvjgpLVSKx7V2pgBl0tkjYlAN2rAj3/EsTQQ yKjuaqBgIrrAzS9NS1kWM/YX3hrOGN8= X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 2CE6F140063 Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=izfspim2; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf09.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com X-Rspam-User: X-Stat-Signature: 8a3y73g3kbi59df3skk6fncybjf8qhfn X-HE-Tag: 1662151151-397477 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 02, 2022 at 10:35:52AM +1000, Alistair Popple wrote: > Currently we only call flush_cache_page() for the anon_exclusive case, > however in both cases we clear the pte so should flush the cache. > > Signed-off-by: Alistair Popple > Fixes: 8c3328f1f36a ("mm/migrate: migrate_vma() unmap page from vma while collecting pages") > Cc: stable@vger.kernel.org This is the patch to start collide with David's. David's patch has also unified both paths with ptep_get_and_clear(), but this patch itself is also correct to me. It'll probably just become no-diff after rebase, though.. I'm not sure how the ordering would be at last, but anyway I think this patch stands as its own too.. Acked-by: Peter Xu Thanks for tolerant with my nitpickings, > > --- > > New for v4 > --- > mm/migrate_device.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/migrate_device.c b/mm/migrate_device.c > index 6a5ef9f..4cc849c 100644 > --- a/mm/migrate_device.c > +++ b/mm/migrate_device.c > @@ -193,9 +193,9 @@ static int migrate_vma_collect_pmd(pmd_t *pmdp, > bool anon_exclusive; > pte_t swp_pte; > > + flush_cache_page(vma, addr, pte_pfn(*ptep)); > anon_exclusive = PageAnon(page) && PageAnonExclusive(page); > if (anon_exclusive) { > - flush_cache_page(vma, addr, pte_pfn(*ptep)); > ptep_clear_flush(vma, addr, ptep); > > if (page_try_share_anon_rmap(page)) { > -- > git-series 0.9.1 > -- Peter Xu