From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93BF2ECAAD2 for ; Fri, 2 Sep 2022 01:05:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 25EE58008C; Thu, 1 Sep 2022 21:05:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 20C9F6B00B6; Thu, 1 Sep 2022 21:05:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D62E8008C; Thu, 1 Sep 2022 21:05:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id EEC166B00B5 for ; Thu, 1 Sep 2022 21:05:00 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C6FF21403C0 for ; Fri, 2 Sep 2022 01:05:00 +0000 (UTC) X-FDA: 79865351160.05.7C989FB Received: from out1.migadu.com (out1.migadu.com [91.121.223.63]) by imf05.hostedemail.com (Postfix) with ESMTP id 5C4C610004D for ; Fri, 2 Sep 2022 01:04:59 +0000 (UTC) Date: Thu, 1 Sep 2022 18:04:46 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1662080697; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oRI44dmgZNXvCbxbx0ytBb5MNkpf1qBSJsTY6pAYXVg=; b=tb82WN7ukOq58edHhF7JOoDon3b2L1v/3IY97PsYRx6OPp66Trpvsx1rbRyhlh12fOiUwG EZmYoO3fSDUB2lu8gxsuWxZiVkHfm4qLeJxKDdrjL94MRoA3GDg6F5I9+Uj2cx14iFfbdO He+0U/hKqYLU04r4PhzKId0lgLZpOKY= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Kent Overstreet Cc: Yosry Ahmed , Michal Hocko , Mel Gorman , Peter Zijlstra , Suren Baghdasaryan , Andrew Morton , Vlastimil Babka , Johannes Weiner , dave@stgolabs.net, Matthew Wilcox , liam.howlett@oracle.com, void@manifault.com, juri.lelli@redhat.com, ldufour@linux.ibm.com, Peter Xu , David Hildenbrand , axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, Steven Rostedt , bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, Christoph Lameter , Pekka Enberg , Joonsoo Kim , 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, Shakeel Butt , Muchun Song , arnd@arndb.de, jbaron@akamai.com, David Rientjes , minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, Linux-MM , iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, Linux Kernel Mailing List Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications Message-ID: References: <20220831084230.3ti3vitrzhzsu3fs@moria.home.lan> <20220831101948.f3etturccmp5ovkl@suse.de> <20220831190154.qdlsxfamans3ya5j@moria.home.lan> <20220901223720.e4gudprscjtwltif@moria.home.lan> <20220902001747.qqsv2lzkuycffuqe@moria.home.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220902001747.qqsv2lzkuycffuqe@moria.home.lan> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662080699; a=rsa-sha256; cv=none; b=OkChxRKjpHprtlDkCLwUs/E7nyrBQ7IpH9NJgP8lCvt9O0TbmwRdLhiGV4DC7vfIve7/3V DCgmZG7mRSLkKN3lETqwh1LRAQV4/GYN+XSoHrnzY7b5oY6RPljaomQRY4Lkjsi3a02tic qXtrGxXVXDI5UoSWnzwYbfiuHGUOSf8= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=tb82WN7u; spf=pass (imf05.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.121.223.63 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662080699; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oRI44dmgZNXvCbxbx0ytBb5MNkpf1qBSJsTY6pAYXVg=; b=2Z4zocDI+2Em5/CHs+eEdsPkFMGUNCOGYQ0wOESV1m0TiNj3ekVZirh6b9BbR6KikRXmVi Y+b4roXvisShVzrg8A6amSwFPyIhsn/sWp4jitcV3TCC2SjU4Sy2L8TZx2bv3lowi5mHaf cq8WptnZ0WRaU/YCbjmdlMvMspdyDRQ= Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=tb82WN7u; spf=pass (imf05.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.121.223.63 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 5C4C610004D X-Stat-Signature: jrrxkq7djpyhoji789rqnp6iyixonhfc X-HE-Tag: 1662080699-625609 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 01, 2022 at 08:17:47PM -0400, Kent Overstreet wrote: > On Thu, Sep 01, 2022 at 03:53:57PM -0700, Roman Gushchin wrote: > > I'd suggest to run something like iperf on a fast hardware. And maybe some > > io_uring stuff too. These are two places which were historically most sensitive > > to the (kernel) memory accounting speed. > > I'm getting wildly inconsistent results with iperf. > > io_uring-echo-server and rust_echo_bench gets me: > Benchmarking: 127.0.0.1:12345 > 50 clients, running 512 bytes, 60 sec. > > Without alloc tagging: 120547 request/sec > With: 116748 request/sec > > https://github.com/frevib/io_uring-echo-server > https://github.com/haraldh/rust_echo_bench > > How's that look to you? Close enough? :) Yes, this looks good (a bit too good). I'm not that familiar with io_uring, Jens and Pavel should have a better idea what and how to run (I know they've workarounded the kernel memory accounting because of the performance in the past, this is why I suspect it might be an issue here as well). This is a recent optimization on the networking side: https://lore.kernel.org/linux-mm/20220825000506.239406-1-shakeelb@google.com/ Maybe you can try to repeat this experiment. Thanks!