From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FB21ECAAD2 for ; Fri, 2 Sep 2022 03:37:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BE37B800AD; Thu, 1 Sep 2022 23:37:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B922E8008D; Thu, 1 Sep 2022 23:37:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A8305800AD; Thu, 1 Sep 2022 23:37:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 99E988008D for ; Thu, 1 Sep 2022 23:37:13 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 69486809B5 for ; Fri, 2 Sep 2022 03:37:13 +0000 (UTC) X-FDA: 79865734746.13.E01BBA2 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf18.hostedemail.com (Postfix) with ESMTP id 0CBAE1C0046 for ; Fri, 2 Sep 2022 03:37:12 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E877533D70; Fri, 2 Sep 2022 03:37:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1662089831; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DI3GzIroG9Z+gelwHW3Ud5RXkeyLPq2aEkpI5BDoZSw=; b=L2xXFpSmTEGE6FRw07qcHWG0VItqsbhBM2+jeEoRx/z3MpHrP1rnretBF1tisN7yaIssk6 ZwI3GdIbDPgaQGbtlQMlVUDm7nf1/EvBiNonEnTvldEDxMicKQHY7/zIUPYJXajNnIx0wc XEkhtd0b+rQla/eN47IDlst49DM7IB4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1662089831; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DI3GzIroG9Z+gelwHW3Ud5RXkeyLPq2aEkpI5BDoZSw=; b=0bm2D7GTEKl/tCM8+DAcI8dU7ouMBIo0Ve525Q/ZRTSr/Q9HVfFhYL7PTWATjKErOSx8jn Py1vqPuOMmVaeOBw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6E62C133DD; Fri, 2 Sep 2022 03:37:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id We8xGGd6EWPBDwAAMHmgww (envelope-from ); Fri, 02 Sep 2022 03:37:11 +0000 Date: Fri, 2 Sep 2022 05:37:09 +0200 From: Oscar Salvador To: Michal Hocko Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Vlastimil Babka , Eric Dumazet , Waiman Long , Suren Baghdasaryan Subject: Re: [PATCH 3/3] mm,page_owner: Filter out stacks by a threshold counter Message-ID: References: <20220901044249.4624-1-osalvador@suse.de> <20220901044249.4624-4-osalvador@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662089833; a=rsa-sha256; cv=none; b=DubhDhdIb+tgrzF0YwkWd8e2JVt04W8NNMDc4n4e+smo4ULN3pPhlZBteXf3to8iwhq8TT 2f7X7z4hn6y4pP2MBHl/7XXCMsWW+FPm7+zj4ImFuwzUL+gBJuYDGEPn/eTVgOKAI6g9CH j/XC110xajA7YlNJPUxPIOleIbBETEk= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=L2xXFpSm; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=0bm2D7GT; spf=pass (imf18.hostedemail.com: domain of osalvador@suse.de designates 195.135.220.28 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662089833; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DI3GzIroG9Z+gelwHW3Ud5RXkeyLPq2aEkpI5BDoZSw=; b=KYGOw5N+jYf9jn01bbRmNRsH6wdxR0mflnEsOhjrQ2ktu0F0/L6zxERZ5pynXG+10zD22r LmkI76M2lVC4grXG8FZ6ljJHITY0w/3RPAUIkK79pfQ8xdHx8NGYINnClTfsfiDFSEqdko UndFukvDR0xJxMmkMqsoVsVrHc9EtsI= X-Stat-Signature: cmkrdmuqwibiodefidpb8anfzkzk3acu X-Rspam-User: X-Rspamd-Queue-Id: 0CBAE1C0046 X-Rspamd-Server: rspam07 Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=L2xXFpSm; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=0bm2D7GT; spf=pass (imf18.hostedemail.com: domain of osalvador@suse.de designates 195.135.220.28 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de X-HE-Tag: 1662089832-821041 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 01, 2022 at 10:40:32AM +0200, Michal Hocko wrote: > On Thu 01-09-22 06:42:49, Oscar Salvador wrote: > [...] > > +static ssize_t read_page_owner_threshold(struct file *file, char __user *buf, > > + size_t count, loff_t *pos) > > +{ > > + char *kbuf; > > + int ret = 0; > > + > > + count = min_t(size_t, count, PAGE_SIZE); > > + > > + if (*pos >= count) > > + return 0; > > + > > + kbuf = kmalloc(count, GFP_KERNEL); > > No, you do not want to trigger user defined allocation like that. I > would use seq_file. Sure, will use that. Thanks! -- Oscar Salvador SUSE Labs