From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C1F3ECAAD2 for ; Fri, 2 Sep 2022 03:39:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A0F44800AE; Thu, 1 Sep 2022 23:39:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9BE888008D; Thu, 1 Sep 2022 23:39:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 88721800AE; Thu, 1 Sep 2022 23:39:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7A3278008D for ; Thu, 1 Sep 2022 23:39:46 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 50938A11F4 for ; Fri, 2 Sep 2022 03:39:46 +0000 (UTC) X-FDA: 79865741172.11.6E3EB59 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 1B27016005B for ; Fri, 2 Sep 2022 03:39:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662089984; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=reUzAghh98Vj3d4jHbhqMfDzoVvANcNSdRbekokO7F0=; b=WOTEm2G7p3cNuR38+IJGzd7Tz1uPXP3YHpFH9Fz364ML9KXyhf1iaEax/ttNxqloRWBao9 4w5HUzS/81y8JAgLVXW7uwDu0xzCV2AOFiolqSE8/oTVeEogUnitSkX5bqtz4HTXK1cWDQ k1Xio1zgek+hfFzCHZipViQLlziLBww= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-260-lkQYvhtMPtqoTIIFP8I-dA-1; Thu, 01 Sep 2022 23:39:40 -0400 X-MC-Unique: lkQYvhtMPtqoTIIFP8I-dA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AE06D85A589; Fri, 2 Sep 2022 03:39:39 +0000 (UTC) Received: from localhost (ovpn-12-173.pek2.redhat.com [10.72.12.173]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E61DA1121314; Fri, 2 Sep 2022 03:39:38 +0000 (UTC) Date: Fri, 2 Sep 2022 11:39:34 +0800 From: Baoquan He To: Uladzislau Rezki Cc: Song Liu , Andrew Morton , Linux-MM , open list , Song Liu Subject: Re: [PATCH] mm/vmalloc: Extend find_vmap_lowest_match_check with extra arguments Message-ID: References: <20220831052734.3423079-1-song@kernel.org> <20220831160111.a6e7d17785ca21ce7c43981c@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662089986; a=rsa-sha256; cv=none; b=ZtdLglWOigxL9tgUwpNauYFlmZu2wktLObVUVh/cCaAQtk66F4Fy84teeMYEVcH/nuwvUT bKVNzobouRzhTFrwP2Xw4Dn+nHw4xcD8JCL6amWDDjqgZn9SJ4HVUd5Oxr4mAGWFacOgjZ AMamNfy97zCJ/1+iXCRfjisUT+dNx7w= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WOTEm2G7; spf=pass (imf08.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662089986; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=reUzAghh98Vj3d4jHbhqMfDzoVvANcNSdRbekokO7F0=; b=vt9ApQ9CrpQanC11/Cwz4qCUrcLw+VIn9QDiPjdDOaJK6VIvGo2Nw+VypLoQb0s0XAbP8C 1VOXPSjoGXQCQv7gtyqUBKcjGdca4oKnPB9ZesOSjAm3SlPeMU+UnSaAzyEdQnQLJF6puV y56LRy36wUZ21D8iKcaK8B5FLYItyVU= Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WOTEm2G7; spf=pass (imf08.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Stat-Signature: md11pcny3wa9chfoihe18gueiznaeqy3 X-Rspamd-Queue-Id: 1B27016005B X-Rspamd-Server: rspam04 X-Rspam-User: X-HE-Tag: 1662089984-441235 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 09/01/22 at 02:16pm, Uladzislau Rezki wrote: > This is only for debug purpose. > > Even without this patch, the debug path would work correctly. The > difference is just only in > whether roots are hardcoded or passed over function paramter. Calling find_vmap_lowest_match() inside find_vmap_lowest_match_check() will fail compilation because the function interface has been changed. > > On Thu, Sep 1, 2022 at 2:47 AM Song Liu wrote: > > > > On Wed, Aug 31, 2022 at 4:01 PM Andrew Morton wrote: > > > > > > On Tue, 30 Aug 2022 22:27:34 -0700 Song Liu wrote: > > > > > > > find_vmap_lowest_match() is now able to handle different roots. Make > > > > similar changes to find_vmap_lowest_match_check() and > > > > find_vmap_lowest_linear_match() to handle different trees. > > > > > > What are the runtime effects of this change? > > > > The code is gated by DEBUG_AUGMENT_LOWEST_MATCH_CHECK. It > > is only compiled when the developer enables it explicitly. Therefore, > > there isn't > > any runtime effect. > > > > Thanks, > > Song > > > > -- > Uladzislau Rezki >