From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95CD0ECAAD2 for ; Fri, 2 Sep 2022 03:33:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D417A800AB; Thu, 1 Sep 2022 23:33:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CF0318008D; Thu, 1 Sep 2022 23:33:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BDFB9800AB; Thu, 1 Sep 2022 23:33:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id AB04B8008D for ; Thu, 1 Sep 2022 23:33:27 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 80B331A0E39 for ; Fri, 2 Sep 2022 03:33:27 +0000 (UTC) X-FDA: 79865725254.27.7CC70FA Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf01.hostedemail.com (Postfix) with ESMTP id 16BF74004B for ; Fri, 2 Sep 2022 03:33:26 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B1F7E20A7E; Fri, 2 Sep 2022 03:33:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1662089605; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eIdTt/sIs/p9Y5wl0IOT0Yq8IRs/zFnc8Crxg9PtTRo=; b=V1uhk2dF/9U+V+IAOcbxe9njvdvA3xHj4GLDsJ9pPFDmko57bd+QSh5b2j9B/3veu28LxX YvESnUu4m62LHlYn6M0GW9shUzQyO8WDFM5jLqyeG6pREpI3nKuWDGedYLHf9nZw+EVC0n Cs7nusZ2UF1UZ/beb1OTbCwqvmmOpvk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1662089605; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eIdTt/sIs/p9Y5wl0IOT0Yq8IRs/zFnc8Crxg9PtTRo=; b=lCcyAGqaOzmiGz+xtHfVjAi03RqCKlGGm29yRFeYGkR9bdVQhFL9+qal7Ux/+HSww6U4Rh 7QGk9KWYn36K7QCw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 234B3133DD; Fri, 2 Sep 2022 03:33:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ZMTaBYV5EWNoDgAAMHmgww (envelope-from ); Fri, 02 Sep 2022 03:33:25 +0000 Date: Fri, 2 Sep 2022 05:33:23 +0200 From: Oscar Salvador To: Ammar Faizi Cc: Linux Kernel Mailing List , Linux MM Mailing List , Andrew Morton , Michal Hocko , Vlastimil Babka , Eric Dumazet , Waiman Long , Suren Baghdasaryan , Ammar Faizi Subject: Re: [PATCH 2/3] mm, page_owner: Add page_owner_stacks file to print out only stacks and their counter Message-ID: References: <20220901044249.4624-1-osalvador@suse.de> <20220901044249.4624-3-osalvador@suse.de> <9f2ef1ac-c0a1-eb77-8e68-e9a60bc8efd2@gnuweeb.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9f2ef1ac-c0a1-eb77-8e68-e9a60bc8efd2@gnuweeb.org> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662089607; a=rsa-sha256; cv=none; b=dCsPQ3OuR5Z62QUGja03OVHP3p6EsIH9Cn2P3a1Cp291w5cAiyBU1ZmcBOU+nu+m2cBcF/ JdTtQ7cM3PxXywnmYPskQFdijpxatlhBQcDbCqyzMrseeBdm9sUZRTIDPAZRC51TRqLikg gnxxGde/S3lq9RJHKFuNjO1druXcn+8= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=V1uhk2dF; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=lCcyAGqa; spf=pass (imf01.hostedemail.com: domain of osalvador@suse.de designates 195.135.220.29 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662089607; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eIdTt/sIs/p9Y5wl0IOT0Yq8IRs/zFnc8Crxg9PtTRo=; b=0NegH8HdFsV1/o8E4r/cHBQigAblyDqW66k/l/lJEgOpJAeBy7AnyF8dUdpV1sbR32k+S8 F5/+Oqn96omF+uyO2Pej3KlqsNWfJgcZhAKxoPhWKcIjpF5YbRa8cOlBy+Z4hWUb5wFbgf BGcNiQrrPYgW/Adu7iECeP+yowU6dUY= X-Rspam-User: X-Stat-Signature: bknzy1o489kgte9f4ykyh64eua9gq6uw X-Rspamd-Queue-Id: 16BF74004B X-Rspamd-Server: rspam06 Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=V1uhk2dF; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=lCcyAGqa; spf=pass (imf01.hostedemail.com: domain of osalvador@suse.de designates 195.135.220.29 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de X-HE-Tag: 1662089606-305485 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 01, 2022 at 03:16:44PM +0700, Ammar Faizi wrote: > On 9/1/22 11:42 AM, Oscar Salvador wrote: > > +static unsigned long last_stack = 0; > > This @last_stack can just be a static local variable in the new > function you wrote, read_page_owner_stacks(), since no other > functions use it. We could certainly do that. > > > +static ssize_t read_page_owner_stacks(struct file *file, char __user *buf, > > + size_t count, loff_t *pos) > > +{ > > + char *kbuf; > > + int ret = 0; > > + > > + count = min_t(size_t, count, PAGE_SIZE); > > + kbuf = kmalloc(count, GFP_KERNEL); > > + if (!kbuf) > > + return ENOMEM; > > Missing a negative sign, return -ENOMEM; Oh yes, I overlooked that. Thanks! -- Oscar Salvador SUSE Labs