From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C781ECAAD3 for ; Thu, 1 Sep 2022 11:30:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7BEFF8D0002; Thu, 1 Sep 2022 07:30:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 76C0E8D0001; Thu, 1 Sep 2022 07:30:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 632E28D0002; Thu, 1 Sep 2022 07:30:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 52FEC8D0001 for ; Thu, 1 Sep 2022 07:30:23 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 29DD8805A1 for ; Thu, 1 Sep 2022 11:30:23 +0000 (UTC) X-FDA: 79863298326.28.82844A1 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by imf09.hostedemail.com (Postfix) with ESMTP id B521114006A for ; Thu, 1 Sep 2022 11:30:22 +0000 (UTC) Received: by mail-pj1-f41.google.com with SMTP id q3so13619424pjg.3 for ; Thu, 01 Sep 2022 04:30:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=V64FDAeyB9hSKsb/4XLPZwHiRXFWh6rSShrdNPEYKEA=; b=oarQ6geNTT9z54uxsUfvrryuucCFqLBbGOkVzo5P8mbwQHV+PFreOCList453nk2cH otvxgBzG4uHr+ag/hExNrNG4P294ojHc6xMVXTpTJSV7YDgue3vRM2yLt+lcGio8RAg4 DjiOETSfmlKTLSTvp6g4wXpXR60dL0L+vM+jAc2xOjRL1tYAAPC7cbQOuWJ1DBWpVgsc fMHIDiJkfN1cYb8mzHRjPV+8slTsVswxQUbcoPLEmYPslHzE+syxqTLcPszns2LRYa8U 4C44FzVxC0Qhbdw0xnZaVWRKnmW/2dqXvSN4GCVX5jJUrJglspiOprIm3WnUNlyyGvfH 7yqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=V64FDAeyB9hSKsb/4XLPZwHiRXFWh6rSShrdNPEYKEA=; b=wZZrbuIPgh6+5MNUbUimbGbqIJSo0ixhvd3SyU6bAe4ViNnbfgP0dPRPjdN7sT8Ify 94ylUA0JiPHUL+XEXWK3OaYMT88ft5gN9hfoJk0AAdnNulDYgJ2EHwwo8z3amhlsFo6P uszrtp5P1zvgq8Z6z2YyZvdC4/AcAwY8wDP5znDTuh1X+BBwk2rIbriiGBvtnH8Joggr 8bwAtC0Scc/hEcbYWOt2u46sWWZEzG0Pk0+LUJGg/jv4ynMqFmhCxRmoP6s3sMt+jmvI mK+cr/o+6F7z12VdHW9brUgpv19ypz/g22qTIiL6fUwsUkun55mMfDUc8/qTWw8+Z1y1 wDmw== X-Gm-Message-State: ACgBeo2oZCz8dawBYskRC9+qzZ+/dedsVT1C58yXt3qH09aDjxaswNJx EHRaWTo6Y0W1kR4sUOFxNt8= X-Google-Smtp-Source: AA6agR6pd33qRdzLHZ6Bbspw7Lb3a1DPKOKLvOmzCs4Xcs/ojldVTySRswOcQBI0IhEnkciItY+5XA== X-Received: by 2002:a17:90a:f416:b0:1fd:c729:bd0b with SMTP id ch22-20020a17090af41600b001fdc729bd0bmr7946642pjb.171.1662031821788; Thu, 01 Sep 2022 04:30:21 -0700 (PDT) Received: from hyeyoo ([114.29.91.56]) by smtp.gmail.com with ESMTPSA id i14-20020aa796ee000000b00537ff911a89sm10454933pfq.105.2022.09.01.04.30.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Sep 2022 04:30:19 -0700 (PDT) Date: Thu, 1 Sep 2022 20:30:14 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Vlastimil Babka Cc: kernel test robot , kbuild-all@lists.01.org, Linux Memory Management List Subject: Re: [linux-next:master 2760/3682] include/trace/events/kmem.h:54:1: sparse: sparse: restricted gfp_t degrades to integer Message-ID: References: <202208290041.W6s9gjtG-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662031822; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=V64FDAeyB9hSKsb/4XLPZwHiRXFWh6rSShrdNPEYKEA=; b=LFOkK2/gBX6gDLZ9B1SBwl3JObVsSHViWaWKhJIJGNtl6SNDu4jfaXp4jwDu3hA/fuIORI DqQYMoODNZMv5ayZA/jXMuFfMXzz8KPpGD2q5fGq0dpzp0FxiX7V5Hs7/smFVXQToCamFm aBQxpBtHkJQMgZcpqL9XCu8uicJW3Zg= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=oarQ6geN; spf=pass (imf09.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.216.41 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662031822; a=rsa-sha256; cv=none; b=KhDoMs5CAZukuQLCkG2fpB+dQSGGbgxbjXoLw0rSLa+1abfMcgn5reizAsuLNaQCdiAH06 m+HFOezOU0kcGJNwia/+IwGZYZsWqgAOci1FpN3+496pCHuklaD38bpgXmp+hE2DSy92jS Y0eqHZo0MnUrsmzgDXns/Dy/P0lBt5c= Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=oarQ6geN; spf=pass (imf09.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.216.41 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-Stat-Signature: yebbzzmogyrqfmqcfzwf68dtshucfaj4 X-Rspamd-Queue-Id: B521114006A X-Rspamd-Server: rspam05 X-HE-Tag: 1662031822-122105 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 01, 2022 at 11:45:05AM +0200, Vlastimil Babka wrote: > On 8/28/22 18:30, kernel test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > > head: 8d0c42c9e80791e8baba2932d2cbd2dcead50d47 > > commit: 86431e299ca5a0e16405201535b6060936146215 [2760/3682] mm/slab_common: drop kmem_alloc & avoid dereferencing fields when not using > > config: openrisc-randconfig-s033-20220828 (https://download.01.org/0day-ci/archive/20220829/202208290041.W6s9gjtG-lkp@intel.com/config) > > compiler: or1k-linux-gcc (GCC) 12.1.0 > > reproduce: > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > chmod +x ~/bin/make.cross > > # apt-get install sparse > > # sparse version: v0.6.4-39-gce1a6720-dirty > > # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=86431e299ca5a0e16405201535b6060936146215 > > git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > > git fetch --no-tags linux-next master > > git checkout 86431e299ca5a0e16405201535b6060936146215 > > # save the config file > > mkdir build_dir && cp config build_dir/.config > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=openrisc SHELL=/bin/bash > > > > If you fix the issue, kindly add following tag where applicable > > Reported-by: kernel test robot > > > > sparse warnings: (new ones prefixed by >>) > > mm/slab_common.c: note: in included file (through include/trace/trace_events.h, include/trace/define_trace.h, include/trace/events/kmem.h): > >>> include/trace/events/kmem.h:54:1: sparse: sparse: restricted gfp_t degrades to integer > > > > vim +54 include/trace/events/kmem.h > > > > 53 > > > 54 TRACE_EVENT(kmalloc, > > 55 > > 56 TP_PROTO(unsigned long call_site, > > 57 const void *ptr, > > 58 size_t bytes_req, > > 59 size_t bytes_alloc, > > 60 gfp_t gfp_flags, > > 61 int node), > > 62 > > 63 TP_ARGS(call_site, ptr, bytes_req, bytes_alloc, gfp_flags, node), > > 64 > > 65 TP_STRUCT__entry( > > 66 __field( unsigned long, call_site ) > > 67 __field( const void *, ptr ) > > 68 __field( size_t, bytes_req ) > > 69 __field( size_t, bytes_alloc ) > > 70 __field( unsigned long, gfp_flags ) > > 71 __field( int, node ) > > 72 ), > > 73 > > 74 TP_fast_assign( > > 75 __entry->call_site = call_site; > > 76 __entry->ptr = ptr; > > 77 __entry->bytes_req = bytes_req; > > 78 __entry->bytes_alloc = bytes_alloc; > > 79 __entry->gfp_flags = (__force unsigned long)gfp_flags; > > 80 __entry->node = node; > > 81 ), > > 82 > > 83 TP_printk("call_site=%pS ptr=%p bytes_req=%zu bytes_alloc=%zu gfp_flags=%s node=%d accounted=%s", > > 84 (void *)__entry->call_site, > > 85 __entry->ptr, > > 86 __entry->bytes_req, > > 87 __entry->bytes_alloc, > > 88 show_gfp_flags(__entry->gfp_flags), > > 89 __entry->node, > > 90 (IS_ENABLED(CONFIG_MEMCG_KMEM) && > > 91 (__entry->gfp_flags & __GFP_ACCOUNT)) ? "true" : "false") > > 92 ); > > 93 > > Amending the commit with > diff --git a/include/trace/events/kmem.h b/include/trace/events/kmem.h > index 8c6f96604244..243073cfc29d 100644 > --- a/include/trace/events/kmem.h > +++ b/include/trace/events/kmem.h > @@ -88,7 +88,7 @@ TRACE_EVENT(kmalloc, > show_gfp_flags(__entry->gfp_flags), > __entry->node, > (IS_ENABLED(CONFIG_MEMCG_KMEM) && > - (__entry->gfp_flags & __GFP_ACCOUNT)) ? "true" : "false") > + (__entry->gfp_flags & (__force unsigned long)__GFP_ACCOUNT)) ? "true" : "false") > ); > > > Thank you for the fix, Looks good to me. -- Thanks, Hyeonggon