From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8774ECAAD1 for ; Thu, 1 Sep 2022 08:38:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6E0026B0072; Thu, 1 Sep 2022 04:38:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 68ECF6B0073; Thu, 1 Sep 2022 04:38:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 559458D0001; Thu, 1 Sep 2022 04:38:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 445A66B0072 for ; Thu, 1 Sep 2022 04:38:11 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 1DD8B81428 for ; Thu, 1 Sep 2022 08:38:11 +0000 (UTC) X-FDA: 79862864382.15.44EDFEC Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf05.hostedemail.com (Postfix) with ESMTP id B9172100037 for ; Thu, 1 Sep 2022 08:38:10 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 5E08B1FB58; Thu, 1 Sep 2022 08:38:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662021489; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NrHpzMz41QmduVOHpV9GnZB1kYyiHKDCqktpestefcU=; b=tZeFnsBgvZN6JzMwErJ11ohD5yGPe2CJTezUP6foJPfV4OKUBAAU3RcJOFpSRn4MkMiJQc 8+7Hrgyh2hI/kyJ0UrL1nq0SjQtoKssxX57d+GfLKyXlmgqWx9iJ53yHizE/g3NBBrE9Cu tEuPLNok/zsJdO1eqZdb0nz3tVEor2c= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3C1D713A79; Thu, 1 Sep 2022 08:38:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id KlFtDHFvEGPpNwAAMHmgww (envelope-from ); Thu, 01 Sep 2022 08:38:09 +0000 Date: Thu, 1 Sep 2022 10:38:08 +0200 From: Michal Hocko To: Marco Elver Cc: Oscar Salvador , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Vlastimil Babka , Eric Dumazet , Waiman Long , Suren Baghdasaryan , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , kasan-dev@googlegroups.com Subject: Re: [PATCH 1/3] lib/stackdepot: Add a refcount field in stack_record Message-ID: References: <20220901044249.4624-1-osalvador@suse.de> <20220901044249.4624-2-osalvador@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662021490; a=rsa-sha256; cv=none; b=Vb/sy8iLU+YJBt68vzp104+SaLJuqOCiE2cANzu3PzB2vKgfisbUlb5AL2/yPNYyV6kBnV UnKfYbc3kfCvH7hpVHCkeR4eqc0daM0TivOzGZoHijgIBUf/0JtqeEtiSVntsG7W1Nc/5q 3LlW89EepK3gobne+msncAEx6TpNWi0= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=tZeFnsBg; spf=pass (imf05.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662021490; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NrHpzMz41QmduVOHpV9GnZB1kYyiHKDCqktpestefcU=; b=anfJ8AZp7MNUmnguRTHXtk5/AoLjlECdsU2Sa1gG9XWhqHymKQVhlvZUPFPmqZmmv/bBwu xV3uHzBW5KvXCgf2cTRSB1/wz2SDECwwhXhY5y5kOZ4sQ4tUIHFiQfpypgLFi1zT4lE7CA 7kUdTFA2af1Ai0z2P9xvkeDoMmNJxJI= X-Stat-Signature: 6t8qcsbfecoo4364eociargwosxyagk8 X-Rspamd-Queue-Id: B9172100037 Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=tZeFnsBg; spf=pass (imf05.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1662021490-980613 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 01-09-22 10:24:58, Marco Elver wrote: > On Thu, Sep 01, 2022 at 06:42AM +0200, Oscar Salvador wrote: [...] > > diff --git a/lib/stackdepot.c b/lib/stackdepot.c > > index 5ca0d086ef4a..aeb59d3557e2 100644 > > --- a/lib/stackdepot.c > > +++ b/lib/stackdepot.c > > @@ -63,6 +63,7 @@ struct stack_record { > > u32 hash; /* Hash in the hastable */ > > u32 size; /* Number of frames in the stack */ > > union handle_parts handle; > > + refcount_t count; /* Number of the same repeated stacks */ > > This will increase stack_record size for every user, even if they don't > care about the count. Couldn't this be used for garbage collection? -- Michal Hocko SUSE Labs