From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E851ECAAD3 for ; Thu, 1 Sep 2022 07:36:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 876186B0072; Thu, 1 Sep 2022 03:36:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 826066B0073; Thu, 1 Sep 2022 03:36:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6EDC28D0001; Thu, 1 Sep 2022 03:36:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5D9196B0072 for ; Thu, 1 Sep 2022 03:36:51 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2AC5C80E94 for ; Thu, 1 Sep 2022 07:36:51 +0000 (UTC) X-FDA: 79862709822.09.85493E8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 8BE9880053 for ; Thu, 1 Sep 2022 07:36:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662017810; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=esLxAvr9853Thi1a9GlfKlpRrKA5zTCBjO5Czht1ha8=; b=gO+1vvjSAd8WE++Aqsq0u2EP65YIloaxFVylUEH7c83jF/TG+c2TlRs8EvX8UUcZze95Yr Nlv9iAnj6vB9s9YgYKt44ztX6Bb4iBAVhVKIcDYfRor2ib/+0Q0t65pq3Kzd922LohtrAe SMqULcg3ivF+ZJ1xquMNXa/U2QQAVOQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-478-HY9lTAENOau_a90uJaIBJA-1; Thu, 01 Sep 2022 03:36:49 -0400 X-MC-Unique: HY9lTAENOau_a90uJaIBJA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6BC8B811E81; Thu, 1 Sep 2022 07:36:48 +0000 (UTC) Received: from localhost (ovpn-12-182.pek2.redhat.com [10.72.12.182]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4952740C141D; Thu, 1 Sep 2022 07:36:46 +0000 (UTC) Date: Thu, 1 Sep 2022 15:36:43 +0800 From: Baoquan He To: Christoph Hellwig Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, agordeev@linux.ibm.com, wangkefeng.wang@huawei.com, linux-arm-kernel@lists.infradead.org, Yoshinori Sato , Rich Felker , linux-sh@vger.kernel.org Subject: Re: [PATCH v2 10/11] sh: mm: Convert to GENERIC_IOREMAP Message-ID: References: <20220820003125.353570-1-bhe@redhat.com> <20220820003125.353570-11-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662017810; a=rsa-sha256; cv=none; b=eFPVuihdE/C9fLvnlABM212Zmv56EDEdbWeZNOemLygKAx/zQ5fg9na/4MSUcmMRgTXBqX BsWm3EdgREeZ0odidpRJo4nAkdf/gdz1dP58zIHQ+qQPsRUZl9+t68EFQpLs8TAwa29E58 T76By3o5Wy381PjMVQTp2/mbKhC6QvA= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gO+1vvjS; spf=pass (imf02.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662017810; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=esLxAvr9853Thi1a9GlfKlpRrKA5zTCBjO5Czht1ha8=; b=kDOLT3PFpowe3bC8yhrmLo9W3po6J+TlX7YiuNHkMj/ouosAMcAI1H2RvLJEsIFvxtirdv 8VmXJgzYn3AW14UvMBSYl2FWOL2C/TyXS7SnuXQARq8GHZRA4JA4K8jZ3eKow6kUUilNQk BTmige52Xuo+J9QCq1oPTycFeQWFNNo= X-Rspam-User: X-Stat-Signature: fkgbn59e9usorafyz37w8uw55f77zts5 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 8BE9880053 Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gO+1vvjS; spf=pass (imf02.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-HE-Tag: 1662017810-230715 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 08/21/22 at 12:06am, Christoph Hellwig wrote: > > +void __iomem * > > +arch_ioremap(phys_addr_t *paddr, size_t size, unsigned long *prot_val); > > +#define arch_ioremap arch_ioremap > > Shouldn't this still be under CONFIG_MMU? Yeah, you are right, will put them under CONFIG_MMU. I thought making GENERIC_IOREMAP depend MMU in Kconfig will contain that. But people can manually set the Kconfig item freely. Thanks for pointing it out. diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig index 5f220e903e5a..b63ad4698cf8 100644 --- a/arch/sh/Kconfig +++ b/arch/sh/Kconfig @@ -25,6 +25,7 @@ config SUPERH select GENERIC_SCHED_CLOCK select GENERIC_SMP_IDLE_THREAD select GUP_GET_PTE_LOW_HIGH if X2TLB + select GENERIC_IOREMAP if MMU >