From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E56B8ECAAD4 for ; Thu, 1 Sep 2022 01:27:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 72A0E8D0001; Wed, 31 Aug 2022 21:27:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6D99E6B0073; Wed, 31 Aug 2022 21:27:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 52BD78D0001; Wed, 31 Aug 2022 21:27:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 43FFB6B0072 for ; Wed, 31 Aug 2022 21:27:35 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E447AA07BE for ; Thu, 1 Sep 2022 01:27:34 +0000 (UTC) X-FDA: 79861779228.20.3CBA7F0 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by imf28.hostedemail.com (Postfix) with ESMTP id 2D0D4C003E for ; Thu, 1 Sep 2022 01:27:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661995654; x=1693531654; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=0TyRb2nGLPMR/ZdchMmWFrw4FIzkdzsV0zLV+AJX+j4=; b=Tl/5HwSwHVgK7Q497RY6bGwWbb/oYGf04UsQd0roOlQo47ENPwZaENE/ surYGb+hVifWw98ZG+y/S7dCIMKljmVYTpaqw0bjAlYV4kiZLd2kf5woX h3nlrYf76iaPpX3331l8wqlgFjrY7BPSpogdFynKi+rw05xzhwYWtC6re KGPP+5ncM/w/GRN/TyToXUo2KVVxijX88RCi1jGm+7D2iRVx0y+9Bugrg f3oUXXqxBACRxNAt/9Vb7KGKNu5xAQtzZ8yMOhcdXIaM0dLLCCI8nkA7X 33AzHvTEbRZRgSBuEUYfNY+zOAcUPdQY9gq3FN0GrYsRVsmBu/LjV7Q7k Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10456"; a="282566817" X-IronPort-AV: E=Sophos;i="5.93,279,1654585200"; d="scan'208";a="282566817" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Aug 2022 18:27:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,279,1654585200"; d="scan'208";a="563252098" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga003.jf.intel.com with ESMTP; 31 Aug 2022 18:27:31 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 31 Aug 2022 18:27:31 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 31 Aug 2022 18:27:30 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 31 Aug 2022 18:27:30 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.106) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 31 Aug 2022 18:27:30 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V7E0y0wtiotLADOi4WUI5N1pdqepqujHgLspf5fVnfomTturMcEB2xz6ztoub+EXlK520a2Q2wBuHmlgm52a4xerJN+/4Ro6gdw8aGbOE3jddL/ANASZkZb2ZqB87+2fvZTOVhcXgvRo4Mqw44RRK7C8QSJncbLVcT4iRvVn6x9iWIpbvLyoAG1Z91/2wI5X7BMhgmi0NiivRPZp7ehfOw/NiA8H7RRfXkdzxW3dbKJIDIlRF37Bug8pg/o/lJWe+/9bGFgZvF+Kxd5vMOnuKhwNppuvyg9K8HijUXFfp115L4JHjJcM6I+b1qZZIpD/Eownv5HUjNHIcZs9OLWx6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TW5LiODEYz3WknU55utscAYy9Jv36BeElHi/AvMOgdk=; b=i+6cCw85Pp0PvDRUb3nn+ZGSFfn/FzPbE0N3h3ByTVpq7LPWU/QUk1PqXcK4OR8inqGGMRlgCZ5k3SWXZEyppoKn6t/tkVmx5wP1r47rTY1PCj5KN6fP1IpBPGmoTA7fgxPb8OGINNQpXoxSw1AbgKaq/KnIz2xunIA+nyvakQylX0Oy6mGo2nGiJ8GvyljJfoZvo99BCxh/ijS9oJc8Cl7sd8TBKSCkHQnEB+fEKY+sLojxN/tj7xzd0RqMu2o2zMmoqfMysIjmpUvQY7ozbZH9mv66KqPHmsJlxFMm0osmSCJ02jLdx94LXgq7KAWYL7yAvjAzXsQrRHobGUxOpQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN0PR11MB6304.namprd11.prod.outlook.com (2603:10b6:208:3c0::7) by MW4PR11MB6786.namprd11.prod.outlook.com (2603:10b6:303:20b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Thu, 1 Sep 2022 01:27:28 +0000 Received: from MN0PR11MB6304.namprd11.prod.outlook.com ([fe80::d446:1cb8:3071:f4e8]) by MN0PR11MB6304.namprd11.prod.outlook.com ([fe80::d446:1cb8:3071:f4e8%5]) with mapi id 15.20.5588.010; Thu, 1 Sep 2022 01:27:28 +0000 Date: Thu, 1 Sep 2022 09:26:54 +0800 From: Feng Tang To: Vlastimil Babka CC: Marco Elver , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Andrew Morton , Alexander Potapenko , Dmitry Vyukov , "kasan-dev@googlegroups.com" , "linux-mm@kvack.org" Subject: Re: [PATCH -next] mm: kence: add __kmem_cache_free to function skip list Message-ID: References: <20220831073051.3032-1-feng.tang@intel.com> <7edc9d38-da50-21c8-ea79-f003f386c29b@suse.cz> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <7edc9d38-da50-21c8-ea79-f003f386c29b@suse.cz> X-ClientProxiedBy: SG2P153CA0005.APCP153.PROD.OUTLOOK.COM (2603:1096::15) To MN0PR11MB6304.namprd11.prod.outlook.com (2603:10b6:208:3c0::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 422ac82a-8fbd-4816-342a-08da8bb92224 X-MS-TrafficTypeDiagnostic: MW4PR11MB6786:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mzm5i49qrtRbXjMeiVkRj0Y6LE87uOenUntMd31jegURj63ncyT2O8mJIxc78cUo/JwNq17NNrXnydONb1tioWDgAZ0WRNsaTu3hsMA5H/6vT/aVYffLEgsiSwCXRpJFbAHqXiETDp5rIPblOXg1VHPij6O1hgu7t1dE13Goh0k/Ilhzk1cxxWWabncgVPphb7fDTnEVrS+9eIscnrxcSQO1NdFcbUrZiEqtF1w2yA118HUm7lgjl5ZLoZRipBKNU1CjrkequhOJ/PUER21abQA/YROfTu8JeQVA28U3CIWM7gM97GhuTzyP1xa8b5TFmwUdGkSQ8+i49IFkMQ2nYASbo0Km7XwZLrQdYGfUDDHQJt1kmUe5zZWFf+5FkeorK808oM/u+xE8a9oowzCRGXByN3zoshNez4D84ITswwy5eIOgM5N9FsCSicXYn5b2nK0tKBwMgU2CUcLZa5Xljtc/nqjSc8uJAjvc4BO7pkDv19r43hzpsy2mn9f8Sv6yA8BLxe+frrTSZZhfjOtoL56EIJ7IUQXopBu0G8weFRBy/f+3G73CuZBgo9v31iupAV7i6pmDEg2DWbu18FnrDrGLZWAJF85KCGS9T3/u9ppqa9dMSrEheZYLwA0s+GP8Q2BdClaEKe/bF4f68+xXlP7wYpLgCkxSwr4zm5nY02yimh62gsTZHWCa0JjP0CmlTN7KqZc1D6EwQDRvjA6wKA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN0PR11MB6304.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(7916004)(346002)(136003)(396003)(39860400002)(366004)(376002)(44832011)(33716001)(66476007)(66556008)(66946007)(6916009)(54906003)(316002)(53546011)(41300700001)(6666004)(6506007)(26005)(2906002)(8936002)(5660300002)(6486002)(478600001)(9686003)(6512007)(186003)(83380400001)(82960400001)(86362001)(4326008)(8676002)(38100700002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZVi+wCytboJCeckyTIl5Um6S72A9AsGImc0ZJDhEI30HQ7qVw5r+K8Xfxnki?= =?us-ascii?Q?oU0OYS4RgVOjMAbaRIu7a1BzR2yLGbLJiT4IvLqevxTTt5kLE3FyPMm2S7Dg?= =?us-ascii?Q?WCLy7egUwnCXxAwLnV5cQYQnXvptR+IcJKcHjM2OVdVy6trOk+b+bhoNDitO?= =?us-ascii?Q?Cr+p+g0T5VEOJihZxfl3ea4qUjU7UYNp7QUZW2twZuIcideE6kNBd6drei1r?= =?us-ascii?Q?Kcoc3ia2ZJ577TNVhvrCuoYoHudcrg39YoiSWxMLjrLca4oKdcl78l0kMAJf?= =?us-ascii?Q?p5UJ5TeXc3t+9r4yeKCaSq3bnUQIzdVD3KbF8yoZMj65ef//O8LVoqdEUw3s?= =?us-ascii?Q?nkAO56eF4MXcH8E1kaoPeAtCXgch8esVX87Z3RFAO9I5ssCfJF3qrtBuAhZU?= =?us-ascii?Q?qYQf7vo88hDinxfErNkJqhkYXwbJAYFCfwAzU3Nckxww28YaeQ+9R9Wl0CeP?= =?us-ascii?Q?i4NacCNW0LMoAlTQYGDempgp1sUpExmZ/aP8TA5ExbCmyxqcgEwBD+VnIuKb?= =?us-ascii?Q?2ZRXap5zTsELwPHaaO863ShDy+cciDnewpCL+dJe1a2Kv89Zw1Y/B9FKdceu?= =?us-ascii?Q?kX/wCI4wgQlcwtaU/vKpTGuJmW9rPjyQgJYVeI03Tzv6lwKSTSpHjgPlifOr?= =?us-ascii?Q?oJf9HSHG6L2CbWmLVH3XgLaYI1+WviVcsHAUtjDdrLg+m29RkBDZzMvNccxn?= =?us-ascii?Q?w/Ai9CeRwLEArS1duAoWqjbsu4vKVROESFuE0x1MXg7P51yEctjpzCvd59F/?= =?us-ascii?Q?grhsQ65FovywYjnDU3xPFOuPQSv8jp0E4EmNR1ybKO/Nz+pVbjtG/Nqm8W8F?= =?us-ascii?Q?flzqqaF/unESuv+xbLbw2EiqfR/Ewcu10GCo8Gwur41aHPxr7BgT0gHpQwLH?= =?us-ascii?Q?WleTTy189Hl4ikQGaVZB8dF7lrulYQDDTPgLMCkM+j0MqZOZ5mU+KhDRyWKb?= =?us-ascii?Q?lgZGVa//gmYxBErg7TkJoVtHsnMOSBIC27C/GlCEin0kpuDq5x3tWgqS8KKq?= =?us-ascii?Q?BPb8WqN6jdOUDG9BWvoqlNjLvGf+EseCrNiKQaBNq6bw1upag2Nyukx5VW/r?= =?us-ascii?Q?p1NozMO1jRRVfdxxi2wrlQ0HKuE1J7Z7vjLbApa0RUneWi3uKtbbTv3vyLJ+?= =?us-ascii?Q?kfBW358tOZrOPIPdaMu/sZhMXAZYLDATltH4HL8hPrnmTDFhO66R7tdby9Iz?= =?us-ascii?Q?zl/lr4uJJxTIDMjfnwo/ONpVQOWj1kNZitXM6sdoMKfobgl+EnaUZbh3LCl/?= =?us-ascii?Q?3OJKcxrcDJgwXoBGftB27Vumn3z2vsU/aEOKwRwtAcnmMpiLVY006AGBu66Y?= =?us-ascii?Q?7JWTQZiX9CtRY0bBFIFvcib7BqHHQfoQ2JZKMqei+2ZXkQHLxIpymP0cOqnS?= =?us-ascii?Q?h1Bb9uV9ijkMqYGgbx45JH12xXzoPr+tw4WTBuTbBTc8E3BEOlkXnZ2s1JSH?= =?us-ascii?Q?WzRisle/fVp2UexC6lnCFWk54q8iBb55tU00ST/nexyLIqneVSjA9CU2NjKm?= =?us-ascii?Q?7p93Iij5oiEUfid8a7OcvBt09qwOEQdvjc7kOAcjecg+IY2ICfq2TYtL9flB?= =?us-ascii?Q?Xch3yLghyyU6iOjA+p2qtM1MKBhhJzaVDFIOoQKY?= X-MS-Exchange-CrossTenant-Network-Message-Id: 422ac82a-8fbd-4816-342a-08da8bb92224 X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6304.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2022 01:27:28.6086 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KclWF6jzw5IYkUT79Uv04ib5JN8UQ4ZtM2AmmHO4HLAsqTD16MfvER2CQeihXeugVv1rg8/SgclN6VdA1/jckQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB6786 X-OriginatorOrg: intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1661995654; a=rsa-sha256; cv=fail; b=s1+T/wuXu6fzQ6qeBdzk997aIY2zekNvpkEt4/ZFpPL8+hw4DqKtgVwIqU0hA93BtEcNfQ sZyYZrol+HYX0KW+6dt499RhvyNWoPeaFHYVWU1+ex3Yqy9XvQeFP4VOTrvSr1ly0qDpUq p4ip10EyPvSAGC1YKfWZGxcuLXlILuw= ARC-Authentication-Results: i=2; imf28.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b="Tl/5HwSw"; spf=softfail (imf28.hostedemail.com: 134.134.136.20 is neither permitted nor denied by domain of feng.tang@intel.com) smtp.mailfrom=feng.tang@intel.com; dmarc=fail reason="No valid SPF" header.from=intel.com (policy=none); arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661995654; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TW5LiODEYz3WknU55utscAYy9Jv36BeElHi/AvMOgdk=; b=3tKWl0sb+HgHNjfgOXLmc4QC+xQ9RG6I6mN3KqJNTMn6DSJqBtNejaQ6clm6ZhA50GDAtC B0nIg/XMVDE/v4qYAtW/zsNNP+qzw/F1LLdb7PedJ4a39dOoVBHMxkkNI7VhPtoa5+1KGL mlWe7PIj0wu+RScA7Dcu/dHMB95U7Ms= X-Rspam-User: X-Stat-Signature: 59kaeqs6r3p3a44cjz87a31eh6ad9ckf X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 2D0D4C003E Authentication-Results: imf28.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b="Tl/5HwSw"; spf=softfail (imf28.hostedemail.com: 134.134.136.20 is neither permitted nor denied by domain of feng.tang@intel.com) smtp.mailfrom=feng.tang@intel.com; dmarc=fail reason="No valid SPF" header.from=intel.com (policy=none); arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") X-HE-Tag: 1661995653-747428 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 01, 2022 at 12:16:17AM +0800, Vlastimil Babka wrote: > On 8/31/22 16:21, Marco Elver wrote: > > On Wed, 31 Aug 2022 at 16:04, Hyeonggon Yoo <42.hyeyoo@gmail.com> wrote: > > > >> Maybe you can include those functions too? > >> > >> - __kmem_cache_alloc_node > >> - kmalloc_[node_]trace, kmalloc_large[_node] > > > > This is only required if they are allocator "root" functions when > > entering allocator code (or may be tail called by a allocator "root" > > function). Because get_stack_skipnr() looks for one of the listed > > function prefixes in the whole stack trace. > > > > The reason __kmem_cache_free() is now required is because it is tail > > called by kfree() which disappears from the stack trace if the > > compiler does tail-call-optimization. > > I checked and I have this jmp tail call, yet all test pass here. > But I assume the right commit to amend is > 05a1c2e50809 ("mm/sl[au]b: generalize kmalloc subsystem") > > Could you Feng maybe verify that that commit is the first that fails the > tests, and parent commit of that is OK? Thanks. Yes, 05a1c2e50809 is the first commit that I saw the 4 kfence failed kunit cases. Thanks, Feng