From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E78FECAAD4 for ; Thu, 1 Sep 2022 01:22:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BE3B78D0001; Wed, 31 Aug 2022 21:22:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B91BC6B0073; Wed, 31 Aug 2022 21:22:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A59508D0001; Wed, 31 Aug 2022 21:22:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 935B66B0072 for ; Wed, 31 Aug 2022 21:22:06 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 6B9EA14061A for ; Thu, 1 Sep 2022 01:22:06 +0000 (UTC) X-FDA: 79861765452.18.14B55F7 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by imf23.hostedemail.com (Postfix) with ESMTP id 0AD25140053 for ; Thu, 1 Sep 2022 01:22:05 +0000 (UTC) Received: by mail-pl1-f177.google.com with SMTP id u22so15695645plq.12 for ; Wed, 31 Aug 2022 18:22:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=nGbSPl6vfUxnpVaxdq8qn8cGXULdrRBFaoDPHGxfyrQ=; b=EI5j0lvZBm62JicpfiQSBi7BYb4g1q1L64BDiYbBF+l1fAE5ZYWpsfKSXW2Yfo1KDB ByFErbxVMNQRgeoxwV2ojR5jQQbHvGR2AOhyOGE86qEgyAFQsCZkJxPe6zyOJ5SR/E0H R2VDSdiJbBfwVtNA7yxUvypvmlAghteEHxRDA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=nGbSPl6vfUxnpVaxdq8qn8cGXULdrRBFaoDPHGxfyrQ=; b=45LtNWWXD+8EFZD7p8WYO5yrdIbsWoKe12IRbWcfhQ0/20P2rw7ILjwbuU6GTCK4ho 6TBF0vTejllqx3JiHFRukeO2asrH0pLLmnK6VXz3VfH9JXQSwHQLaBd4dFmTZ568VFnl XjU8FTwIsRa56fcQNilkVe7whx2vfrb+cFm2FqMvZ0/+boUm9YSJIC/JOrqMAauumjBV 5434xJ1Rc15B9ySQW+aEa8sLcvHGXSvcZ2Gptv3MxzNAIYz1ao1ZdTpYAG/YXfvwcKjk Jxx2dZYmDCoE8LvZ4gcjO3ElzCdlEamZy+NBQfXpTQUwZsSYF6Z2ejOfnXq9Uvas/f9Q Qdiw== X-Gm-Message-State: ACgBeo0emsXq6JWxB0xz52GLyz3PhL1wUDyNx0bvmhijSiCwoMcsBe9D ctMKLkcJrXwHjhvnpxP4gXo7FA== X-Google-Smtp-Source: AA6agR6taB/DtW1RsVuwX04HNOdPTnYauju6iD2tOkpmyqZmHPFGW+xFSLlmBl3YkGfdTCeQPF0scw== X-Received: by 2002:a17:903:25c4:b0:174:4311:bf17 with SMTP id jc4-20020a17090325c400b001744311bf17mr26602118plb.103.1661995324965; Wed, 31 Aug 2022 18:22:04 -0700 (PDT) Received: from google.com ([110.11.159.72]) by smtp.gmail.com with ESMTPSA id f17-20020a170902f39100b0016b81679c1fsm390242ple.216.2022.08.31.18.22.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Aug 2022 18:22:04 -0700 (PDT) Date: Thu, 1 Sep 2022 10:21:58 +0900 From: Sergey Senozhatsky To: Alexey Romanov , Minchan Kim , Andrew Morton Cc: senozhatsky@chromium.org, ngupta@vflare.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel@sberdevices.ru Subject: Re: [PATCH v1] zsmalloc: zs_object_copy: replace email link to doc Message-ID: References: <20220815144825.39001-1-avromanov@sberdevices.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220815144825.39001-1-avromanov@sberdevices.ru> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661995326; a=rsa-sha256; cv=none; b=RFW8GHxExTj23mfa+Tf0D18bcW3wolDXBajgLa89zC5MGW429XZFvcQ2uqofzXP4OeStPd fFviNY8mN0DEon6XIavMJF/9gAJLmgCyGpbY4DhT0D2xZRkUv9f0heb01Ckz8W49c2sz6c o+1mw5gIFv5Jf+sScGws7ld8XZ6+VEM= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=EI5j0lvZ; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf23.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.177 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661995326; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nGbSPl6vfUxnpVaxdq8qn8cGXULdrRBFaoDPHGxfyrQ=; b=g1FgKr7Wu0npHUbNdrbkoJfOS4RKgZ+QRIlbxNNB9cK5rmHscMkwLXLyLJbOIDUvgPUJAI CAIP0vIvx92J4C9KjWlB6UiMTYx8cGKXzKwY/O3JHdTdBrxwZS9I7DD8BZAFerujatT5SV XQLZ5ZYWIlE5wJltq0c4824YTVXaTc0= X-Rspam-User: Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=EI5j0lvZ; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf23.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.177 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org X-Rspamd-Server: rspam07 X-Stat-Signature: 3c9zkdmuw6jj9w783zm7wnuda3ccaft8 X-Rspamd-Queue-Id: 0AD25140053 X-HE-Tag: 1661995325-133374 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (22/08/15 17:48), Alexey Romanov wrote: > diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c > index 99d93a48cbe0..17641bde5432 100644 > --- a/mm/zsmalloc.c > +++ b/mm/zsmalloc.c > @@ -1559,8 +1559,8 @@ static void zs_object_copy(struct size_class *class, unsigned long dst, > * Calling kunmap_atomic(d_addr) is necessary. kunmap_atomic() > * calls must occurs in reverse order of calls to kmap_atomic(). > * So, to call kunmap_atomic(s_addr) we should first call > - * kunmap_atomic(d_addr). For more details see > - * https://lore.kernel.org/linux-mm/5512421D.4000603@samsung.com/ > + * kunmap_atomic(d_addr). For more details see > + * Documentation/mm/highmem > */ > if (s_off >= PAGE_SIZE) { > kunmap_atomic(d_addr); So I'm not against this patch, but in general I don't think we document kmap_atomic/kunmap_atomic in the kernel. That's type of API that people get BUG() on and then figure out that it's a stack and pop-s should mirror push-es. We have lots of undocumented src/dst kmap-s: src = kmap_atomic(s_page); dst = kmap_atomic(d_page); do_copy_page(dst, src); kunmap_atomic(dst); kunmap_atomic(src); Like I said, I'm not against this patch, so FWIW Reviewed-by: Sergey Senozhatsky I'll let Minchan to have the final word.