From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD600ECAAA1 for ; Mon, 12 Sep 2022 10:05:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4E08D8D0002; Mon, 12 Sep 2022 06:05:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4900A8D0001; Mon, 12 Sep 2022 06:05:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 356FE8D0002; Mon, 12 Sep 2022 06:05:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 22ECB8D0001 for ; Mon, 12 Sep 2022 06:05:40 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E229A120A4E for ; Mon, 12 Sep 2022 10:05:39 +0000 (UTC) X-FDA: 79903001598.11.1B1D268 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by imf18.hostedemail.com (Postfix) with ESMTP id 90CFF1C0087 for ; Mon, 12 Sep 2022 10:05:39 +0000 (UTC) Received: by mail-pl1-f182.google.com with SMTP id u22so8067514plq.12 for ; Mon, 12 Sep 2022 03:05:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=wA+G1rTGQqTYcb1OJ8bJnhg5ULF8AN+cZNRHEqhhtc0=; b=Ys1cLfVc+bcTfWM4x+7FFPxbO53/oc5Q137yVhVX6Kp76sOg3QoJZUeGNC+YoBko6y 8wyh4ivOgFhWEim/YVhn9/Zkc8Ofz7r0NoHvfHM1n134T0fVkSryNqlc1RMv6Yq0/IDl M37jI/RzCW9PIeWhErr77+I5ZvQLqRlSGzd1Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=wA+G1rTGQqTYcb1OJ8bJnhg5ULF8AN+cZNRHEqhhtc0=; b=HXOOZXiQZB3oQ2qMiXZ9J1Xpr3XL3cvziwiukjnDWRUiMtrzw0gVBXhpR96bsF2TjI aI1/lm0WLX7O5+yi4iXAF9Cfu5ci5Tgh/4l/Oo9Ivm9dAvQBDZF2NqNmNwjjht1pGaMi eslKjB93LWzDtU2wWqgsRoK402RQrT7S4eN9ERLBO0udwD+MRO8AzOtLpCh1/BtIgxiq rNoY5zgUtQYwjwwmLd/cdjqiehnRyYFRdyJHfcLVh0HubaDZRLbSWG12K7hELaQgR4Ww iuPq0rUtaKeo5pOp2pp8mhsJiG2+spD6JAjMvEtvmERzMvz9XQqSxoDbRBnOUgDYdbdQ 6zCQ== X-Gm-Message-State: ACgBeo3OgCAvtJzZXCXGBuLUnoP0MHx6J6TTXn/a1+J26svGfr2r42SF fIiI6+nTPl/nZMP9MN87ilp4mw== X-Google-Smtp-Source: AA6agR4o+ywEOFCjegIHMhQuf4jPIoJG6xexxviUFVMTcXJ8B9+SHhDcSVNWGfbNzBpjpLQR9xhxJw== X-Received: by 2002:a17:90b:3807:b0:1f4:ecf7:5987 with SMTP id mq7-20020a17090b380700b001f4ecf75987mr22399681pjb.13.1662977138419; Mon, 12 Sep 2022 03:05:38 -0700 (PDT) Received: from google.com ([240f:75:7537:3187:7b09:9fce:b16b:c111]) by smtp.gmail.com with ESMTPSA id lr16-20020a17090b4b9000b002000dabc356sm4755447pjb.45.2022.09.12.03.05.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Sep 2022 03:05:37 -0700 (PDT) Date: Mon, 12 Sep 2022 19:05:33 +0900 From: Sergey Senozhatsky To: Minchan Kim Cc: Andrew Morton , Nitin Gupta , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Sergey Senozhatsky Subject: Re: [PATCH RFC 4/7] zram: Introduce recompress sysfs knob Message-ID: References: <20220905082323.2742399-1-senozhatsky@chromium.org> <20220905082323.2742399-5-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220905082323.2742399-5-senozhatsky@chromium.org> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662977139; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wA+G1rTGQqTYcb1OJ8bJnhg5ULF8AN+cZNRHEqhhtc0=; b=VgodoX6305OBcQJbReEDJOVH6xnGVWlGy0XyyOwSO6xLI3YvoSCYnDobBTOM8Lt/piVNIG tSvOMZdQdv0hy8fgR8fkdVy0eeDFpyNk8xvLezENpJyjU8rjeOzJyHixwb6X5K9muxbrYB bxCarcXiIFk7CajhbYSSJJLkfbFqmhM= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Ys1cLfVc; spf=pass (imf18.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.182 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662977139; a=rsa-sha256; cv=none; b=hSLkviK2CMVY2mOq3GwMhu5q9JrThJDvzFktCzxX3T8hhUxn4JGFMK4nhgUnpcdofjRVGT jhD/ribkYZH8aZBWHgKhgWtrP5xPeAghAD4u2TAlxAi9IWrdYR+Prlr7HPD48SBAnTL4a4 QRMwoPjkCVDfS1RCKblyPliQ5KxMEu8= X-Rspam-User: Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Ys1cLfVc; spf=pass (imf18.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.182 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-Rspamd-Server: rspam06 X-Stat-Signature: izs7uf576oru3m878jr3o37uihb89pz1 X-Rspamd-Queue-Id: 90CFF1C0087 X-HE-Tag: 1662977139-584067 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (22/09/05 17:23), Sergey Senozhatsky wrote: [..] > + /* > + * Either a compression error or we failed to compressed the object > + * in a way that will save us memory. Mark object as "recompressed" > + * if it's huge, so that we don't try to recompress it again. Ideally > + * we want to set some bit for all such objects, but we for now do so > + * only for huge ones (we are out of bits in flags on 32-bit systems). > + */ This limitation goes away once we move ZRAM_FLAG_SHIFT to more reasonable value. I can introduce one more pageflag that will be set for objects that cannot be compressed by either compression algorithm.