From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EF8BECAAD2 for ; Mon, 29 Aug 2022 15:18:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E177C940008; Mon, 29 Aug 2022 11:18:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DC6B8940007; Mon, 29 Aug 2022 11:18:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C8E52940008; Mon, 29 Aug 2022 11:18:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B8663940007 for ; Mon, 29 Aug 2022 11:18:36 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7A7ACA0233 for ; Mon, 29 Aug 2022 15:18:36 +0000 (UTC) X-FDA: 79852987032.07.3DA1138 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf15.hostedemail.com (Postfix) with ESMTP id C3D0EA0023 for ; Mon, 29 Aug 2022 15:18:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=7J+LCIglFKic1AQISx0CzlZmZfddBICdnlceYftKUCA=; b=DKJG+UGgSD8bjysp/aH4+vio3R OynVCz+nWsZjkJt9lXj0dsxcZpUrOYGgROS9hKPw15WWvzi4XdoEGPiHbX+2X77nbASY6yHhJnUoS IAaFgqUtBGfpdV42MM/ScOthkyqnuBqTA6EDV34iWwEAJF3pbfa77ytur85N9h8BkI9gT9ER3hRwd OixySRQKg8ZUM2sBO6zc2fNPJTgfIWpLpA3kZDYEuOyOZLmWmykincdTUIk6VEdR3U2li+G5Agehg 07KMHCI8rE53e5kLj98oSoAlz5aYcLoKhroqp9ChVw1FgyoKiex0DAoiqTzz3nqzxKA43nNZVyzl2 i/J7pc6A==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oSgX0-003C2r-P9; Mon, 29 Aug 2022 15:18:30 +0000 Date: Mon, 29 Aug 2022 16:18:30 +0100 From: Matthew Wilcox To: Linus Walleij Cc: Andrew Morton , linux-mm@kvack.org Subject: Re: [PATCH] fs/proc/kcore.c: Pass a pointer to virt_addr_valid() Message-ID: References: <20220829131317.114007-1-linus.walleij@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220829131317.114007-1-linus.walleij@linaro.org> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661786316; a=rsa-sha256; cv=none; b=kaJVu4aRmYFPumrZXYalQubwOSG3SiIcRiv+rTvXbEIHROEJia52RvEAUrCEODqPUzwryJ ThSLnmnBUwHhnMza8Hl80sfREQ/lVUirV0jIUXn3BVwkyJr/CXyy6KQZ+5gKdEqK911wzD 6j+wDRikQn21e5PAVR3bwZrsZdqFZOg= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=DKJG+UGg; spf=none (imf15.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661786316; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7J+LCIglFKic1AQISx0CzlZmZfddBICdnlceYftKUCA=; b=oxNI6ZogzY57oybMiBKhr6U9kng/AIMGjUdC1GiwFrwrmbgfNa8eOZdXjAIBJxcHCWU/Aw fQhyGUzb6v49RULuFrPJBikp035IlTrRkLNrmz1CAC699wDGt2YcQ7wFzYI6igtz/Ckuy4 iVMtW114Eta4EOOmK7DU8fFz2I0BaJ4= Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=DKJG+UGg; spf=none (imf15.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Rspamd-Server: rspam05 X-Stat-Signature: k44nddp51m3uk6hymu4zaby7b7htrzke X-Rspamd-Queue-Id: C3D0EA0023 X-Rspam-User: X-HE-Tag: 1661786315-642348 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 29, 2022 at 03:13:17PM +0200, Linus Walleij wrote: > The virt_addr_valid() should be passed a pointer, the current > code passing a long unsigned int is just exploiting the > unintentional polymorphism of these calls being implemented > as preprocessor macros. Why do you think it's unintended polymorphism? It looks to me like polymorphism is absolutely intended.