From: Matthew Wilcox <willy@infradead.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org
Subject: Re: [PATCH] fs/proc/kcore.c: Pass a pointer to virt_addr_valid()
Date: Mon, 29 Aug 2022 16:18:30 +0100 [thread overview]
Message-ID: <YwzYxt4xTcnGEyDw@casper.infradead.org> (raw)
In-Reply-To: <20220829131317.114007-1-linus.walleij@linaro.org>
On Mon, Aug 29, 2022 at 03:13:17PM +0200, Linus Walleij wrote:
> The virt_addr_valid() should be passed a pointer, the current
> code passing a long unsigned int is just exploiting the
> unintentional polymorphism of these calls being implemented
> as preprocessor macros.
Why do you think it's unintended polymorphism? It looks to me
like polymorphism is absolutely intended.
next prev parent reply other threads:[~2022-08-29 15:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-29 13:13 Linus Walleij
2022-08-29 15:18 ` Matthew Wilcox [this message]
2022-08-29 21:03 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwzYxt4xTcnGEyDw@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox