From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5347AC0502A for ; Mon, 29 Aug 2022 01:40:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 962CB940008; Sun, 28 Aug 2022 21:40:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 912DF940007; Sun, 28 Aug 2022 21:40:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7D909940008; Sun, 28 Aug 2022 21:40:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6B0AB940007 for ; Sun, 28 Aug 2022 21:40:32 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 39DC0140C99 for ; Mon, 29 Aug 2022 01:40:32 +0000 (UTC) X-FDA: 79850925504.11.99B28A1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf23.hostedemail.com (Postfix) with ESMTP id BCDD3140044 for ; Mon, 29 Aug 2022 01:40:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661737231; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0vCF2MFLwabeNCUHxCLBI4UWY8z6BpyfJcEettVVvuc=; b=icBPu8x0uBrGeiSixRZ+vEofjZUtZAynb2TXeUC4XqbT6dJDiN+zJdsse3GNlO4+ZJxq54 XlDAeGy9+Lf6+Gp0nvkJ0TmOcvLTFrBww6HaLj5adH3w12+jtJnQusgxiP4JXb+AeYtrpV AC/WuREvXLgkKx5cuFHGXeiwE1kfocw= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-329-LevrZ2iyNZi2Fkpakragqg-1; Sun, 28 Aug 2022 21:40:29 -0400 X-MC-Unique: LevrZ2iyNZi2Fkpakragqg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 092B3101A54E; Mon, 29 Aug 2022 01:40:29 +0000 (UTC) Received: from localhost (ovpn-12-153.pek2.redhat.com [10.72.12.153]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0EDB34010FCC; Mon, 29 Aug 2022 01:40:27 +0000 (UTC) Date: Mon, 29 Aug 2022 09:40:24 +0800 From: Baoquan He To: Christoph Hellwig Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, agordeev@linux.ibm.com, wangkefeng.wang@huawei.com, linux-arm-kernel@lists.infradead.org, Jonas Bonn , Stefan Kristiansson , Stafford Horne , openrisc@lists.librecores.org Subject: Re: [PATCH v2 07/11] openrisc: mm: Convert to GENERIC_IOREMAP Message-ID: References: <20220820003125.353570-1-bhe@redhat.com> <20220820003125.353570-8-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661737231; a=rsa-sha256; cv=none; b=JmpDq+kMsazNPK4sU/8OdFHCCF0qRq/S3x+FWdAzaEIa+kPPXIpcPp0sgcwXCbtCM3JyMx FhISSeWBWX22qMhW4n6GW46L0DuoKuMquMTyRSXY5eZKULdWOFu3VlA95lXxX2TS03MXWO GPBECV1zgBP8nGBaBYRWJSpymKWaq4g= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=icBPu8x0; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661737231; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0vCF2MFLwabeNCUHxCLBI4UWY8z6BpyfJcEettVVvuc=; b=Tda3nCR8iWsOarnqolEWB0hUWaTlDqnwTB6CGjD649Cpgyd+rf6OjdM25RnycULSFCk1B9 WIto2LevxAx2iQ65z+8aAocNWoZNrffl6zxgcFo3CMusvN6bYY12X7vgOOrwHtneWXXGyt hAdS7Ax1kNiCtBZsF37keL7HfjOC6LY= X-Rspamd-Queue-Id: BCDD3140044 Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=icBPu8x0; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com X-Rspamd-Server: rspam12 X-Rspam-User: X-Stat-Signature: e3gtn5z1c938qs4ntiykzmy4fk8ohzgg X-HE-Tag: 1661737231-485087 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 08/21/22 at 12:03am, Christoph Hellwig wrote: > > + if (unlikely(!mem_init_done)) { > > if ((fixmaps_used + (size >> PAGE_SHIFT)) > FIX_N_IOREMAPS) > > + return IOMEM_ERR_PTR(ret); > > v = fix_to_virt(FIX_IOREMAP_BEGIN + fixmaps_used); > > fixmaps_used += (size >> PAGE_SHIFT); > > > > + if (ioremap_page_range(v, v + size, p, __pgprot(*prot_val))) { > > fixmaps_used -= (size >> PAGE_SHIFT); > > + return IOMEM_ERR_PTR(ret); > > + } > > + > > + return (void __iomem *)(offset + (char *)v); > > } > > This code needs to go away, and all very early boot uses of ioremap > need to switch to use early_ioremap insted. Makes sense. On openrisc, the thing is I didn't find one place where ioremap() is called in arch code. I can cut the early ioremap out and wrap into a separate early_ioremap() function, however I don't know where to put it. Not sure if I miss anything or openrisc doesn't really need early ioremap.