From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F0AAECAAD1 for ; Sat, 27 Aug 2022 22:49:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E589694000A; Sat, 27 Aug 2022 18:49:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DE186940007; Sat, 27 Aug 2022 18:49:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C840094000A; Sat, 27 Aug 2022 18:49:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B1CAD940007 for ; Sat, 27 Aug 2022 18:49:10 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 8917A1A0F5D for ; Sat, 27 Aug 2022 22:49:10 +0000 (UTC) X-FDA: 79846864860.13.0ABA22C Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [62.89.141.173]) by imf14.hostedemail.com (Postfix) with ESMTP id 43320100026 for ; Sat, 27 Aug 2022 22:49:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=1/n2J4xjTn1ap1GZ0mLWYdRRj9CyoF5AMUAXfowIlzs=; b=VQB77bVgY7MH7hA2Hn3yJithb+ V8KT+xXMkNvkM+W2DGKX82e0A//vw316FKFIHqRgk6O9CrA+C8zHxRnwqm3nyPoPu2WsJ+waOhMCF Jnu8m8s49cvLx5ENkFjAm1TdMp3ZE0MRVDKJbYSsQYLiOGvnfJ6mb1K+Z+f4IEUhM7KDDrzltYylA +0t+Uh80kIBihaZu9HvaQ08CmO7adGSLmcf0ZPEc7ja0f6I/3SecgrPVuaTf1fw7VDEx9C+/tJpcz rvUQFTFaQoN0wFFapShfTahamvtb7K5Lz1xDtw4WVMyy8CWWC8ek6iSD85/zn97COw4JQpWjM+6g0 2x4NUq3A==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.95 #2 (Red Hat Linux)) id 1oS4bq-0097kK-Eb; Sat, 27 Aug 2022 22:48:58 +0000 Date: Sat, 27 Aug 2022 23:48:58 +0100 From: Al Viro To: John Hubbard Cc: Andrew Morton , Jens Axboe , Miklos Szeredi , Christoph Hellwig , "Darrick J . Wong" , Trond Myklebust , Anna Schumaker , Jan Kara , Logan Gunthorpe , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-mm@kvack.org, LKML Subject: Re: [PATCH 5/6] NFS: direct-io: convert to FOLL_PIN pages Message-ID: References: <20220827083607.2345453-1-jhubbard@nvidia.com> <20220827083607.2345453-6-jhubbard@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220827083607.2345453-6-jhubbard@nvidia.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661640550; a=rsa-sha256; cv=none; b=pCmKFwA4gxaZEajektWlsYBdc6mcbRQSjaLrxYENY0gmWV55XnrV6CISgC/XbQw0xZ/or2 iCl9jWMpRJGfS76XVWUGtxCglzEYXGnqAo0ZkAK603Pxgl0hJtd3267IKozCCeyNO8NVat X+WTuzySi+lVrWAX8pDDg/uX/2sO4RM= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=VQB77bVg; spf=none (imf14.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661640550; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1/n2J4xjTn1ap1GZ0mLWYdRRj9CyoF5AMUAXfowIlzs=; b=esWoaifirpiSX0qSQXOKZZteCwFKnmQj40chAg7mmSh/K/QG7jMnT+RERN8lvYcGBrIdmJ tKfpMfjrr51GNIznEHwgU4w5dqGv8FjXk3xyQpEjxwhebQO+PInTQLTN8k+3Kyt9zYbcT+ W2R54g0ITkbaSpIN2kGuDFfhfZSpXaM= X-Stat-Signature: kps7f5te8md57uoriohirogrxhbg5dws X-Rspamd-Queue-Id: 43320100026 X-Rspam-User: X-Rspamd-Server: rspam01 Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=VQB77bVg; spf=none (imf14.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk X-HE-Tag: 1661640550-688789 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Aug 27, 2022 at 01:36:06AM -0700, John Hubbard wrote: > Convert the NFS Direct IO layer to use pin_user_pages_fast() and > unpin_user_page(), instead of get_user_pages_fast() and put_page(). Again, this stuff can be hit with ITER_BVEC iterators > - result = iov_iter_get_pages_alloc2(iter, &pagevec, > + result = dio_w_iov_iter_pin_pages_alloc(iter, &pagevec, > rsize, &pgbase); and this will break on those.