From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A92B1ECAAA6 for ; Fri, 26 Aug 2022 17:16:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3F9EC6B0074; Fri, 26 Aug 2022 13:16:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3AA06940008; Fri, 26 Aug 2022 13:16:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 29971940007; Fri, 26 Aug 2022 13:16:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1AB056B0074 for ; Fri, 26 Aug 2022 13:16:05 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E522FC075C for ; Fri, 26 Aug 2022 17:16:04 +0000 (UTC) X-FDA: 79842396648.04.720CF14 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf07.hostedemail.com (Postfix) with ESMTP id C13514001D for ; Fri, 26 Aug 2022 17:16:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Z3lmJT7etiyJlSyhtK+Ke6TnJo5E+REvqgc5OdmoAlU=; b=YoVOunKXSmRvwLEIhB1OK3cdBH G/yRA6omFVh8wrZa+OTTDlCerON/c9eOwIiUXSjUjzbmbt7kVwRtpfwKRn6sFwRSCXHHSuDOmWLIe y4PljymFPOHZOW1PZxti63y2MlAu73goHXl7a2szKYXih8lc0jx5End20r1/3fGdNpdFkS3pnyDdY LDI6SwU5ex7GC5DBiNkUQpdLGKeHVurrAT5Y+3VAQggs2KEes3eKA/j25y9yDXyoEMQ41956dUS/r /hKgcyj6xSujQpWEYNlIN/UCXdcLcRpuHoB+r75MbPWEQJswRaDh3FlbeQm9cRDqRnnjJ4DtOsiJA LRNeu0VA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oRcvo-000iT2-LR; Fri, 26 Aug 2022 17:15:44 +0000 Date: Fri, 26 Aug 2022 18:15:44 +0100 From: Matthew Wilcox To: "Yin, Fengwei" Cc: Yang Shi , Yu Zhao , Minchan Kim , Andrew Morton , Linux-MM , =?utf-8?B?6Z+p5aSp56GV?= , mawupeng Subject: Re: (resend)WARNING: trying to isolate tail page in isolate_lru_page Message-ID: References: <485f8c33.2471b.182d5726afb.Coremail.hantianshuo@iie.ac.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661534164; a=rsa-sha256; cv=none; b=qPqsW7XPFCXXBXyA8ImudhYLJAVb5c9ncwKGk0QQA9rljN+FpymC5c3DO0EJCJl0/7pHmA NQJXJ2bMU1acDIpLDAC31/w7mT2Qg9nExnT6z3hOQPH311+0YrqlzMaLfzmdyt+oDfzA6U 2EKmeLNRzyNj3YAGQawyj+jco+waKIo= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=YoVOunKX; dmarc=none; spf=none (imf07.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661534164; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Z3lmJT7etiyJlSyhtK+Ke6TnJo5E+REvqgc5OdmoAlU=; b=Ydt0hZul6MyHEHEzxKc7okZ+zGNVC/vct2zofD0GIAq5qpAgqUuqEcR4CCQFFq/8l2x71O ud7yl5JSqKEqQiOdtQmJTRyib1C5u0/QMCRuAQVJoI1O8JCuXSOmJBmftsYTHkVp3e63j8 PHEPEuahLc7+isxQg9yw1TdhYqk+UEo= X-Rspamd-Server: rspam11 X-Rspam-User: X-Rspamd-Queue-Id: C13514001D Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=YoVOunKX; dmarc=none; spf=none (imf07.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Stat-Signature: mrx7zxa3z8ihtdkuo1fac69p8g3iegqy X-HE-Tag: 1661534162-172336 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Aug 26, 2022 at 11:20:58AM +0800, Yin, Fengwei wrote: > On 8/26/2022 2:46 AM, Matthew Wilcox wrote: > > There's a number of ways of solving this. I'm interested in seeing > > which one Minchan thinks is best. > > My understanding is: > PageTransCompound() return false for compound page if THP is disabled > in kernel config. Replacing PageTransCompound() with PageCompound() > could work here. But for the long term, folio should be the answer. :). Yes, ultimately, isolate_lru_page() is going away as an interface and one will have to call folio_isolate_lru(). But should madvise_cold_or_pageout_pte_range() even be getting called for VMAs which are mmaps of af_packet? can_madv_lru_vma() rules out a number of different types of VMA; should it also be ruling out af_packet VMAs? If so, how?