From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48E47C28D13 for ; Thu, 25 Aug 2022 09:59:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E0B6F6B0075; Thu, 25 Aug 2022 05:59:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D93C36B0078; Thu, 25 Aug 2022 05:59:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C358B6B007B; Thu, 25 Aug 2022 05:59:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id ACCA46B0075 for ; Thu, 25 Aug 2022 05:59:45 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7D9051218C3 for ; Thu, 25 Aug 2022 09:59:45 +0000 (UTC) X-FDA: 79837668330.14.0EA0F24 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf11.hostedemail.com (Postfix) with ESMTP id 13ECC40005 for ; Thu, 25 Aug 2022 09:59:44 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id BC8FF20509; Thu, 25 Aug 2022 09:59:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1661421583; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=L5rRZcueCIssY4VCCG3vNVck7AMdOPZ37pzU6M5A41s=; b=Vl3hMbK24FoJq6YXEAkbrwk0ar+RZdhLQjTg+Eb2l5wZBUHfgKZb2cu67OOuH0zX4qRxVR 8H+ZFeQ0BM6eNeDnb+bnIgBnQr0z13vuM2Yn3syULF2k3xa7aNkNCeWfAlDqdyEHENKF45 jwQW5H11xruSBOx8bU1kAQoj0/tkWvQ= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9C7DC13A8E; Thu, 25 Aug 2022 09:59:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id jj3lIw9IB2PmUwAAMHmgww (envelope-from ); Thu, 25 Aug 2022 09:59:43 +0000 Date: Thu, 25 Aug 2022 11:59:42 +0200 From: Michal Hocko To: Vlastimil Babka Cc: linux-mm@kvack.org, Christoph Hellwig , Andrew Morton , Mel Gorman , Johannes Weiner , LKML Subject: Re: [RFC PATCH] mm: reduce noise in show_mem for lowmem allocations Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=Vl3hMbK2; spf=pass (imf11.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661421585; a=rsa-sha256; cv=none; b=Wuq+QwBegtij6HtOF4hrMmdjml5P7zD9ow9zsqPbepA6yDuUma6tfYJ8qjpyZ/8YSgC9Oc q9dYMC44h9T1E9QDLQhYIvgRTpZ7wAUapG/+zVKDDfRhgZHgh7V3M5Gi3rHFZzqo9fSF6S VzWbkoY+L7HEQuOA/39wG4L70OSNU3o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661421585; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=L5rRZcueCIssY4VCCG3vNVck7AMdOPZ37pzU6M5A41s=; b=a4LbREleFKHFRtsiwThhbIL1hJTQxPWl5W8lausQR50B+XbtEK/YvY6mO46ckFEPyBsiS0 SGHN5HShGEhk6TWkRUlARX0iwp5zdk5j9RD/8tEXcOjFCHfEbdaqqDLcbkOM3kSq9CO+RR MuF7CQnZvjvAMIkitcpG/0QiWfL2tnA= Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=Vl3hMbK2; spf=pass (imf11.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com X-Rspam-User: X-Stat-Signature: g3izem8emuep3xws8o3c3oopznos4m7f X-Rspamd-Queue-Id: 13ECC40005 X-Rspamd-Server: rspam04 X-HE-Tag: 1661421584-909743 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 25-08-22 11:52:09, Vlastimil Babka wrote: > On 8/23/22 11:22, Michal Hocko wrote: > > All but node0 are really completely irrelevant for this allocation > > because they do not have ZONE_DMA yet it swamps the log and makes it > > harder to visually inspect. > > > > Address this by providing gfp_maks parameter to show_mem and filter the > > output to only those zones/nodes which are relevant for the allocation. > > That means nodes which have at least one managed zone which is usable > > for the allocation (zone_idx(zone) <= gfp_zone(gfp_mask)). > > The resulting output for the same failure would become: > > Looks good to me. > > > [...] > > [ 14.017605][ T1] Mem-Info: > > Maybe print the gfp_mask (or just max zone) here again, to make it more > obvious in case somebody sents a report without the top header? I have tried to not alter the output but rather filter it out. The gfp mask is the first line of the allocation failure and from my past experience it is usually included in reports. > > > [ 14.017956][ T1] active_anon:0 inactive_anon:0 isolated_anon:0 > > [ 14.017956][ T1] active_file:0 inactive_file:0 isolated_file:0 > > [ 14.017956][ T1] unevictable:0 dirty:0 writeback:0 > > [ 14.017956][ T1] slab_reclaimable:876 slab_unreclaimable:30300 > > [ 14.017956][ T1] mapped:0 shmem:0 pagetables:12 bounce:0 > > [ 14.017956][ T1] free:3170151735 free_pcp:6868 free_cma:0 > > [ 14.017962][ T1] Node 0 active_anon:0kB inactive_anon:0kB active_file:0kB inactive_file:0kB unevictable:0kB isolated(anon):0kB isolated(file):0kB mapped:0kB dirty:0kB writeback:0kB shmem:0kB shmem_thp: 0kB shmem_pmdmapped: 0kB anon_thp: 0kB writeback_tmp:0kB kernel_stack:7200kB pagetables:4kB all_unreclaimable? no > > [ 14.018026][ T1] Node 0 DMA free:160kB boost:0kB min:0kB low:0kB high:0kB reserved_highatomic:0KB active_anon:0kB inactive_anon:0kB active_file:0kB inactive_file:0kB unevictable:0kB writepending:0kB present:15996kB managed:15360kB mlocked:0kB bounce:0kB free_pcp:0kB local_pcp:0kB free_cma:0kB > > [ 14.018035][ T1] lowmem_reserve[]: 0 0 0 0 0 > > [ 14.018339][ T1] Node 0 DMA: 0*4kB 0*8kB 0*16kB 1*32kB (U) 0*64kB 1*128kB (U) 0*256kB 0*512kB 0*1024kB 0*2048kB 0*4096kB = 160kB > > [ 14.018480][ T1] 0 total pagecache pages > > [ 14.018483][ T1] 0 pages in swap cache > > [ 14.018484][ T1] Swap cache stats: add 0, delete 0, find 0/0 > > [ 14.018486][ T1] Free swap = 0kB > > [ 14.018487][ T1] Total swap = 0kB > > [ 14.018488][ T1] 3221164600 pages RAM > > [ 14.018489][ T1] 0 pages HighMem/MovableOnly > > [ 14.018490][ T1] 50531051 pages reserved > > [ 14.018491][ T1] 0 pages cma reserved > > [ 14.018492][ T1] 0 pages hwpoisoned > > > > Signed-off-by: Michal Hocko -- Michal Hocko SUSE Labs