From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D29AC28D13 for ; Thu, 25 Aug 2022 07:58:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 30796940008; Thu, 25 Aug 2022 03:58:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B7FB940007; Thu, 25 Aug 2022 03:58:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1A5B3940008; Thu, 25 Aug 2022 03:58:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0B0FC940007 for ; Thu, 25 Aug 2022 03:58:37 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id CAC1AABEFB for ; Thu, 25 Aug 2022 07:58:36 +0000 (UTC) X-FDA: 79837363032.13.47D4574 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) by imf04.hostedemail.com (Postfix) with ESMTP id 7B2DF40005 for ; Thu, 25 Aug 2022 07:58:36 +0000 (UTC) Received: by mail-pj1-f45.google.com with SMTP id r15-20020a17090a1bcf00b001fabf42a11cso4054287pjr.3 for ; Thu, 25 Aug 2022 00:58:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=HVtd613i0UXrrnb6Zp85lYyQXZ6YePl/EqH6qWZBvRI=; b=F1h+n/l+1PwWbShr5qGzbgiajlXDQrNiZbm6BzE65WHoz6qAo1nD1YeBb4aqO+SyuE Y9s7xQfE7q/KE0MdrhAU8Qd7Y/nmo6DWRcnW3N5RM5+D0OYFfIXJzf/jr2kDcJiCbcEG jWhrg6EhZDZ+rrQsdhFbEh+AFk6BrywCkc7SM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=HVtd613i0UXrrnb6Zp85lYyQXZ6YePl/EqH6qWZBvRI=; b=jTDqpksEG+Q48Bwia/n6MSHlqJLfvTDQAbKMDsYPCafLTkKVhdJYY56tel5cOb8UIQ B3oaYOZbQbok+Cz0Hb6NhmAEKyaV8g9mqGRxj6L0kGim6dT66nVQOGiNGqBX3fVWhwKw ZI4sO8/AiV6S0dggJwRxRl/2sSMTai8lECkw+UjgjyQYZISSEkYMoDRifGC9QC/hnQIy vkfbftRHEFwKMaUuJRskFNRvs5IqEOp+/3qKwaccNu+lfYW7CkDHsE7Yc6oAplqycGNa DeP8ChJRroy4qLzt4rPX0m9OcSV2qRcw7XeEqVxIdMDtEIYSYJTkxKY5KMQDiUMYZRwZ d9Ig== X-Gm-Message-State: ACgBeo0bQWmXRoga2opzQ5HaPA3f/krd9u63VGi6bFF7KKC1sBZpaj4X S3n34Mmx+YWd1fbiqZIZr77g8w== X-Google-Smtp-Source: AA6agR4W4NP/I95GVaCuzaT5x8cXnhROop5eM3MXOl2QIifvixPndTRA5KpdpsgVMmrmsUIaDqiL7w== X-Received: by 2002:a17:902:b20a:b0:172:7385:ea63 with SMTP id t10-20020a170902b20a00b001727385ea63mr2812693plr.54.1661414314893; Thu, 25 Aug 2022 00:58:34 -0700 (PDT) Received: from google.com ([240f:75:7537:3187:af71:ab2c:8adb:fb1b]) by smtp.gmail.com with ESMTPSA id bn4-20020a17090b0a8400b001fa9e7b0c3esm2763837pjb.41.2022.08.25.00.58.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Aug 2022 00:58:34 -0700 (PDT) Date: Thu, 25 Aug 2022 16:58:29 +0900 From: Sergey Senozhatsky To: Andrew Morton , Alexey Romanov Cc: minchan@kernel.org, senozhatsky@chromium.org, ngupta@vflare.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel@sberdevices.ru, Dmitry Rokosov Subject: Re: [PATCH v2] zram: don't retry compress incompressible page Message-ID: References: <20220824113117.78849-1-avromanov@sberdevices.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220824113117.78849-1-avromanov@sberdevices.ru> ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="F1h+n/l+"; spf=pass (imf04.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.45 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661414316; a=rsa-sha256; cv=none; b=TUa1CZujxZn0vWpiR0K6boWtRgu7IAteDJf44RXNxtlDjWI5QquMgrhxC4sOWLenPLVy+x 2BiHPRTJDLES2fzREUwR6IbEpx41pVbSln7E8FX+/ZXVIMII3xSRnYd7j0UbmkcTMkNcAR H5wMjBcx/RHEwpucWwQWL4SkGpohGGg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661414316; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HVtd613i0UXrrnb6Zp85lYyQXZ6YePl/EqH6qWZBvRI=; b=uLLKEvjRCJ4DojiwOSrAvZbQqQStxwbIC+Y8Bh2E2CVO0TmjCKhTHwUDo1TK8lmnXVxqb2 1h1pozPfL74M4nWjN7rIl2Fx9o2kWiffc5d6zjibBxjfgcm9gg1kn8CiC5AFQWmbHFwKUL JRDphK51MA+K7aGnEOHCs2IzGJ73mB8= X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 7B2DF40005 X-Rspam-User: X-Stat-Signature: ai48q5cznh8geb5oms77uoc8pob3czzy Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="F1h+n/l+"; spf=pass (imf04.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.45 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-HE-Tag: 1661414316-100323 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (22/08/24 14:31), Alexey Romanov wrote: > It doesn't make sense for us to retry to compress an uncompressible > page (comp_len == PAGE_SIZE) in zsmalloc slowpath, because we will > be storing it uncompressed anyway. We can avoid wasting time on > another compression attempt. It is enough to take lock > (zcomp_stream_get) and execute the code below. > > Signed-off-by: Alexey Romanov > Signed-off-by: Dmitry Rokosov Reviewed-by: Sergey Senozhatsky