From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F188C04AA5 for ; Thu, 25 Aug 2022 07:49:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F394F6B0074; Thu, 25 Aug 2022 03:49:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EE90E940008; Thu, 25 Aug 2022 03:49:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D8B54940007; Thu, 25 Aug 2022 03:49:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id CA7F56B0074 for ; Thu, 25 Aug 2022 03:49:42 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A07AE120C3F for ; Thu, 25 Aug 2022 07:49:42 +0000 (UTC) X-FDA: 79837340604.06.9092FDB Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf10.hostedemail.com (Postfix) with ESMTP id 211CEC0003 for ; Thu, 25 Aug 2022 07:49:41 +0000 (UTC) Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 27P6xPbl011620; Thu, 25 Aug 2022 07:49:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : content-type : mime-version; s=corp-2022-7-12; bh=VtyEG5SwAL5sxXykJMyi1Jpyk/a9LU8CMW0YKFt3TVk=; b=IXSQQKW9xnL0IDADEktp0TG1rZ6EWfN9wk/hDOf99vyYxGKhXBwBnT9mE0mVhtVtQF9c 03SRsGcy/i9HF9+W6g2wQYrk0dX1xJu01ExPomIZ6HXrMBqG1C6uOvgDUBkxkOdiM2PV PEuSm5A3j4MkG17CZmPblsS7ePAE0v5WlByGxhbfHhWo5CBlbtM4s2OxRskjRYV65Y1O ymrYkAgjfzCxpun0ftLXQxYgdf7ps7bkKMfDRmcTIfvOReq0IIxQ4x9SF5b5PMWIKU5I 3dTR2AOxdIw2fqTcFZlDR4N1xdR2yXqcUKpc48ERP+Ym9pfwstQpF6oBioaq35VA99PB JA== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3j55nyc205-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 25 Aug 2022 07:49:40 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 27P4hOuW011127; Thu, 25 Aug 2022 07:49:39 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2174.outbound.protection.outlook.com [104.47.59.174]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3j5n6mfg1m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 25 Aug 2022 07:49:39 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XqMjtkj6esPv6adhcxBeyzxn156YdpTV0oeouuRP57/jutnkYT2zfkUzsjZxOYi5s58NnFZppzxuCIxwDE9ILmk9ZueUr5PvhumMq0Y822GxO8cIyJltlveycjkAvTn0tk+OqXYW8vuzGWLPxStyaNMXyXpeN7xA4B9+OwIJy+8VnRAHYzTmXzCWoDRVyaBPO6eXxscUDP0KVpG5Ol50XfG9SKnyyfdzCX7ITKWSdd09ySk21a2q5tYSillnCnS2ywty/IYVZJbaGtM/97Yf7mxOKZUUJm/HDC+k1oGTWOncCpxEgKe/3Ummu4PMRmhbgS7tJuzMMTrybtB+NbHRqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VtyEG5SwAL5sxXykJMyi1Jpyk/a9LU8CMW0YKFt3TVk=; b=D/sEr8UHcCBLnKsmKpUuNptA6l14Vw65I9/2wU7vjUW0rIfzAZ1/9voJivlNk5gn3EhjeeWzlXMClMbdu5o/uSbvAf7pGDbt9bHA6Y2F8zSvO2V9F9LgOuzqJ74vS7IPkl1McHCHBJIdF2cH/oxryF/fKiqh2iNjvpMCXnhdcZjc/tP8VsHp5+hdDHkeRxd1RDuD13hsp8zoKi/b4+JMW8X4/GGZpmHMIvgoWfbdgSEhCOtaCNy/pHjhzD50mnvtJy9LsaXk05MEh8vlkPR5/Ur73agDe1DtiZA8MVIXRs/7nmanisuuv/1w1qk1jenZsNj8ru3bLM98Z6XJjGyUxQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VtyEG5SwAL5sxXykJMyi1Jpyk/a9LU8CMW0YKFt3TVk=; b=Dn0CVlvoTOQ/+eM0cMVlGmWK7Q9DDkE4YhoyebGXPQd3L3DKNzAxI7yGJCozUs4zijtv5rnBDy6GdwkF7jGWnu8L2a5jI8qqYR9cdhs22vIl1nVLUYjaiDSdDhJImyBA3PpvCd+EHuPsikfzHlkA56Ji3dZDxPwPZNuoub2Z0to= Received: from MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) by BN0PR10MB4917.namprd10.prod.outlook.com (2603:10b6:408:116::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.15; Thu, 25 Aug 2022 07:49:37 +0000 Received: from MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::209e:de4d:68ea:c026]) by MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::209e:de4d:68ea:c026%3]) with mapi id 15.20.5546.024; Thu, 25 Aug 2022 07:49:37 +0000 Date: Thu, 25 Aug 2022 10:49:27 +0300 From: Dan Carpenter To: syoshida@redhat.com Cc: linux-mm@kvack.org Subject: [bug report] mm/gup.c: Fix return value for __gup_longterm_locked() Message-ID: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-ClientProxiedBy: ZR0P278CA0063.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:21::14) To MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f3611738-41c8-4c0e-d5af-08da866e5bac X-MS-TrafficTypeDiagnostic: BN0PR10MB4917:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ua8J3aFdvln8682+swZnlJlQxQSQ0OacAU5ZgnsGYLrhdnwuj9ppOsXShNesl9UyDbM2ee4Rv9WsHppMbr7oAj0u5I2jKS3i2UOyrnkgw9byeD+SEWc06k8op4dCmPBrPV1uoz0iG2p0+Hyu2qFJG8ZSW/EgGnjBEORx9YGXD9GBrKVrHDajlVKhznLxRS2D1lngT1k9n+wUdb019NVU5Uh3Eij9igoHC7YEE/K+bEVqzsZEKFF4bESttiOaUf1SfKlAILSYYG2x86HB3CZA7e9oFnt2PLnaiPpNVnqLJhXcJGHlSpKgpSjvr0SglCjjA0kUCdqPoHMMU3QtmLafGbY1Jl895JEcCXbv3YVlDOVl38EIRw4brHQ0NogSGKMNkM1E7ukiNT1t7oG1JMpdsh9RXVa0HFvYZQezEQZGb9aX0NcGnajrCEEQdMxBPXrjkht/Gc22UdgcW9bDBp5Qeafh5smMJLESZQ6tUSALheR05ZUmt6QmjWPttPzfKvr1PDU1p+TKcDo3vXpNmfx85Nfr4f/2nTZmpFW/itpSy2BIAb9/2dX1E0c0g6I1nBye/+tcL9Hz9qp7reZjL29EmNwfYIc603F5v4JEH9C+SwMXZAE8mx5A64B52oq3FfAgg5Ww7G6wBLdY1iQwZVfnIHLxTOaQUrWlaf983R7xKMXB99b2XkTsiHnvXlY/vBOSjlkvbbr5uWKJSafSpTLpO8Z7Jf6EwOgDmrCbg9drwXSM8YUGD8Pf+LYz0rtWpvvg25h5WBSrdhu6b/B9QEcESw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2365.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(7916004)(346002)(136003)(39860400002)(396003)(366004)(376002)(5660300002)(8936002)(478600001)(6486002)(2906002)(6506007)(26005)(41300700001)(52116002)(9686003)(44832011)(6512007)(86362001)(6666004)(38350700002)(38100700002)(33716001)(186003)(83380400001)(66946007)(66556008)(66476007)(4326008)(8676002)(316002)(6916009);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?uENIi2Gwvhe4buri8YDJRgdbaHSwRAD0ltCD954WD7cw5aeIpFW2oQgwThoO?= =?us-ascii?Q?+wFp8KrElMHZCBIXCDxm8mfLTX0HXyzHJBdKCdDTkjkmmQsBXacYGiHRw0Jj?= =?us-ascii?Q?1Gfo/ObcohWYZnICufKZ6/rpl3lDnzonOYZ5kQDBOK5ivKB8sjc/QF/gZJxz?= =?us-ascii?Q?fK26wCqsQ+yjUnxcYoY+MqnYSm1hKAi0d7rn0Pg7pjo/D/4AYbQGBYd8bzYg?= =?us-ascii?Q?nVw2JYsOjqaEZ2GvreYtCpn9lf1KSz+w1j36RbcW9il3j2ITYk5y/u6ARCTn?= =?us-ascii?Q?bBsiN36CSklP7HXeraushyX2H7UrmW/+U1R9jGduKlYKRjgRN0nRzxdhT/+M?= =?us-ascii?Q?6Eeijk+MHiN2ecebgxIaym3ta3y55/CbTEOu5xRDcIrSzCZDVuzyzYJC+dCj?= =?us-ascii?Q?wN24HV9nNU1G31tIiHxAyGkI5Bod8jBV8guvDT9CpzbPrWRqfjEMhYDNPB0U?= =?us-ascii?Q?NDeQvifrQjDfT1nPrLORDCyHZ3rDTjIsypO9lALD7n1iS+Vm6RCKpdH8uIze?= =?us-ascii?Q?Qq1X54k0kUZH/4hW9oZ/ISeCHotn5D/uAg43bBS28hTZoCq3goSDwr9GjcOL?= =?us-ascii?Q?rEn/FBKjWsEzH02a6k6SMmLCCyFFGNsok0akYsxay+2HS3O6HRyVuWGeWj49?= =?us-ascii?Q?E9PAEJEpqMcyWMRpCNPgORAqyCdED2mHzthwq0145ePV9Lhaebv4sx9du/M1?= =?us-ascii?Q?rrbLKIpayIsiWf/zaZ+n920M5KNOP66ZORiSXQnMVuVvphaQ9lU1iRZwK4uS?= =?us-ascii?Q?hNNCItqr6T0JFx22HPUU9nNwzNLmwoqozRRXWYfRdBY1KtUvRvtZu0ahVLA6?= =?us-ascii?Q?m+ngWvM0EF6jPZjbCMw+AI2oYKj7/ZbVMZnRwoH0LqHg7VJEtUir7+akf0xX?= =?us-ascii?Q?OabLSfx3ZosT05Sxb0RG8fAkinenaLfQqlfIy53MYl8C+dTt8Ey9y7Ik0apZ?= =?us-ascii?Q?2oGUEr5BOusoApE1rjXPsOVYN43ZTKBMx7gPQTPp6ZCLwctUWIwP1uF2KO/I?= =?us-ascii?Q?Ejis0aX12SoseALGKf+EzpN8ycyYjEsVbDihw4spcXmIrhkqc1xYKejVtn9v?= =?us-ascii?Q?ykZxLKwxRRm7rpKjn1LMcNUZlezyrC/Xu779VVGHrxX3JbD46MQwtQkSYfK/?= =?us-ascii?Q?FgkW78/X6/dFj1ZOC++rlLL5B7zfOc75C8SF2dlzdRwRpFNEUEtTr11wWPNX?= =?us-ascii?Q?SzSpvqz4DPBSkXKLPj8czv7OW2BhaEcDWd7HKsh+mTOEaMORh9trjdEIYf0W?= =?us-ascii?Q?SzSSeDiFGS3rBpUYOCUsfhMfiY63NIGTXFxes22G2cayGhdO/Gb7d+juC0qA?= =?us-ascii?Q?7+9MMnFzUPppXudnUH9tA93Qo8e60dKt+aFqmckFZt78Nhpuegi+hJtxxXz/?= =?us-ascii?Q?CGdbttxL1T4F7TK426cyIYvYO9n7R/S5SqNpm1jh56fYCku9So1GlfyJqm7Q?= =?us-ascii?Q?aLjxiPMt3wu0r5AD6xEvMoV6dttPFWlKlmn5AYiHT6sK/JAqXT/yAUhRzjRk?= =?us-ascii?Q?bEE00u10oB8+p1JAg6/1Xq+bnwoKVW9nwZgARqISn6DzNCWe4zZoGEJZxp3G?= =?us-ascii?Q?5rxJ37HmAwdFkdVo4T7DzL2OgRlHrl4ZZHx492k4t3s5+MLuQvdD0Ys+yoHP?= =?us-ascii?Q?Uw=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: f3611738-41c8-4c0e-d5af-08da866e5bac X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Aug 2022 07:49:37.0486 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2xT005TWGf87G457rT3KU+pX4xSqmp5VkQFtdoMlvAebDwFe3ii2EgHhbSXQwht0DpYz/YnpwpS43nzUwr2xHxzufqDHV6rPhzR4WoVjCuA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB4917 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-08-25_03,2022-08-22_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0 mlxlogscore=327 mlxscore=0 spamscore=0 adultscore=0 phishscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000 definitions=main-2208250027 X-Proofpoint-ORIG-GUID: IQeMJtZWV5lWdwqnImoMEBSIJTn1t-RQ X-Proofpoint-GUID: IQeMJtZWV5lWdwqnImoMEBSIJTn1t-RQ ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1661413782; a=rsa-sha256; cv=pass; b=SaZhiXoM6w+i5SbzTTG2hvcFzUf7ri5ImXj0OYQd0/ZEPjl4FRQ+Q6nwkNEZO1+jyS2CXa JtH95wkVyDDdhIFiztLMlQ9mxt9bAZBnvUM8wKKYHYZ0YrTUP0kaTO+WEHnMepGYRGZLXB jly6oM41Mq1LH43PeohPA2tP5trUF8U= ARC-Authentication-Results: i=2; imf10.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2022-7-12 header.b=IXSQQKW9; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=Dn0CVlvo; spf=pass (imf10.hostedemail.com: domain of dan.carpenter@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=dan.carpenter@oracle.com; dmarc=pass (policy=none) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661413782; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=VtyEG5SwAL5sxXykJMyi1Jpyk/a9LU8CMW0YKFt3TVk=; b=aQ3OqZG/LRQkeNQVamX9WGOE1uR9fpZU9+ukuQhC4ul0Ye0oCBX0Sud23j45wLjxI3of2y z3aUtZ1MgpSJjLZoFLVJizLGmy0ufqXbOkc7Ord/RDIDtLacpbTewiImYZjybPGjNBJV1o whtd1rye7FlFs6F7Wu84zVKOOSi+bfQ= X-Stat-Signature: 48nyfcftm3nku3hrocm8tys8qahjorfp X-Rspamd-Queue-Id: 211CEC0003 X-Rspam-User: X-Rspamd-Server: rspam06 Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2022-7-12 header.b=IXSQQKW9; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=Dn0CVlvo; spf=pass (imf10.hostedemail.com: domain of dan.carpenter@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=dan.carpenter@oracle.com; dmarc=pass (policy=none) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") X-HE-Tag: 1661413781-813234 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000063, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello Shigeru Yoshida, The patch 35f9c4607f9e: "mm/gup.c: Fix return value for __gup_longterm_locked()" from Aug 22, 2022, leads to the following Smatch static checker warning: mm/gup.c:2089 __gup_longterm_locked() error: uninitialized symbol 'rc'. mm/gup.c 2064 static long __gup_longterm_locked(struct mm_struct *mm, 2065 unsigned long start, 2066 unsigned long nr_pages, 2067 struct page **pages, 2068 struct vm_area_struct **vmas, 2069 unsigned int gup_flags) 2070 { 2071 unsigned int flags; 2072 long rc, nr_pinned_pages; 2073 2074 if (!(gup_flags & FOLL_LONGTERM)) 2075 return __get_user_pages_locked(mm, start, nr_pages, pages, vmas, 2076 NULL, gup_flags); 2077 flags = memalloc_pin_save(); 2078 do { 2079 nr_pinned_pages = __get_user_pages_locked(mm, start, nr_pages, 2080 pages, vmas, NULL, 2081 gup_flags); 2082 if (nr_pinned_pages <= 0) This doesn't work if if fails on the first iteration. But also I'm surprised that we are return -EAGAIN on subsequent iterations... 2083 break; 2084 rc = check_and_migrate_movable_pages(nr_pinned_pages, pages, 2085 gup_flags); 2086 } while (rc == -EAGAIN); 2087 memalloc_pin_restore(flags); 2088 --> 2089 return rc ? rc : nr_pinned_pages; 2090 } regards, dan carpenter