From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC6CCC04AA5 for ; Thu, 25 Aug 2022 07:22:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4AC176B0074; Thu, 25 Aug 2022 03:22:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 45B716B0075; Thu, 25 Aug 2022 03:22:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 32436940007; Thu, 25 Aug 2022 03:22:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 2234E6B0074 for ; Thu, 25 Aug 2022 03:22:58 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id F15CCABCE9 for ; Thu, 25 Aug 2022 07:22:57 +0000 (UTC) X-FDA: 79837273194.03.B5E12EE Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf15.hostedemail.com (Postfix) with ESMTP id A793BA0004 for ; Thu, 25 Aug 2022 07:22:57 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E387061A2A; Thu, 25 Aug 2022 07:22:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B3630C433C1; Thu, 25 Aug 2022 07:22:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1661412176; bh=FZL6dNpPI/YKsRnZLNyMo4D7gdJtSXb/mNkH8Nlircs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ha5zOtk0AvY7x3EA510ExFs2Re0tF/qCrDWbj8ScuZmL1dRJ/pCwzPTJ1HofG6kaL LwrifvXSDr2EJZFsFOq5BYmD3ZPtJhQA9mz12KYgxwET8INYKABD3MDe3a9iWm1oNG U0gz1uULE3YJPQ679T93gSvpNaY1U4yRiXxd6ONs= Date: Thu, 25 Aug 2022 09:22:52 +0200 From: Greg KH To: Muhammad Usama Anjum Cc: Jonathan Corbet , Alexander Viro , Andrew Morton , Shuah Khan , "open list:DOCUMENTATION" , open list , "open list:PROC FILESYSTEM" , "open list:MEMORY MANAGEMENT" , "open list:KERNEL SELFTEST FRAMEWORK" , kernel@collabora.com Subject: Re: [PATCH v2 2/4] fs/proc/task_mmu: Implement IOCTL to get and clear soft dirty PTE bit Message-ID: References: <20220825070926.2922471-1-usama.anjum@collabora.com> <20220825070926.2922471-3-usama.anjum@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220825070926.2922471-3-usama.anjum@collabora.com> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661412177; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iwXcr8XwqloQc1Eff1h30onnH+eH9eOQxpwa0bzH2tA=; b=y4wJTs8D8jnH6+Vm3XK2vZahv8hTD02+0Q7voQgQCSVYFgGuc09sPo9ha0C1TxHBJWWCO8 vFIuJmJJiwXEI2AYHjjKStN89R+21ndgTCN1yOt14hqr7c7PtFiJjXPnlJyIe9rtP3G/Cu 1SCHDAXUdQUi/SgMt1G3lRWYgLpLqYs= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=Ha5zOtk0; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf15.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661412177; a=rsa-sha256; cv=none; b=M/KkqGFCdsX+QxiFsZe43JVGROn0oJsKZGFxx/QXdG0RMZ6TzumlsfVPAlneiD1xpM8orO iCJUIeI5RvEoLvP888G4YC4t8fW82Q62TwO4cYvRHUj0LOx0TSE6qiwp/fn45F36OPKD6P OAILZteSlwiwgn9ErNQfcJZFFs+YCew= Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=Ha5zOtk0; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf15.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org X-Rspam-User: X-Rspamd-Queue-Id: A793BA0004 X-Rspamd-Server: rspam10 X-Stat-Signature: q9q5wgkzhf7998fzingh7qtdbb6ndqh8 X-HE-Tag: 1661412177-928548 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 25, 2022 at 12:09:24PM +0500, Muhammad Usama Anjum wrote: > - The flags can be specified in the flags field. Currently only one > PAGEMAP_SD_NO_REUSED_REGIONS is supported which can be specified to > ignore the VMA dirty flags. You forgot to check that all other bits in that flag are set to 0 properly, otherwise you can never add a new bit to the field ever as you can't expect userspace got it right and did not accidentaly set it already. There is kernel documentation on how to add a new ioctl, you might want to read up on that first before resending this. thanks, greg k-h