From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9252C32774 for ; Thu, 25 Aug 2022 07:21:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 40EB36B0074; Thu, 25 Aug 2022 03:21:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3BEB9940007; Thu, 25 Aug 2022 03:21:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2AD536B0078; Thu, 25 Aug 2022 03:21:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 17D536B0074 for ; Thu, 25 Aug 2022 03:21:26 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D368FAAC47 for ; Thu, 25 Aug 2022 07:21:25 +0000 (UTC) X-FDA: 79837269330.22.521EA6F Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf18.hostedemail.com (Postfix) with ESMTP id 796F91C000E for ; Thu, 25 Aug 2022 07:21:25 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BBB03619FF; Thu, 25 Aug 2022 07:21:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4619DC433C1; Thu, 25 Aug 2022 07:21:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1661412083; bh=9udJCAgNHvS41DLCf14O6mR9ebvxwpEYWnWLv9uTcMo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=0KAAhJPpLLzcVvWyCncSp4hb8RkfzPchoc0cSnYqQfE1si7KR47q9CpBG1ZjMM5e7 b0mgVHVpi8YqqGufROcBxn5gBlfGnDAVq9y8mpeCaCX/4bweKKt7NGFWYNbpbFXPuK 9nKI5kusVJo9xotOEeV+pXeYaITVvS+9GJ1JFUSY= Date: Thu, 25 Aug 2022 09:21:19 +0200 From: Greg KH To: Muhammad Usama Anjum Cc: Jonathan Corbet , Alexander Viro , Andrew Morton , Shuah Khan , "open list:DOCUMENTATION" , open list , "open list:PROC FILESYSTEM" , "open list:MEMORY MANAGEMENT" , "open list:KERNEL SELFTEST FRAMEWORK" , kernel@collabora.com Subject: Re: [PATCH v2 2/4] fs/proc/task_mmu: Implement IOCTL to get and clear soft dirty PTE bit Message-ID: References: <20220825070926.2922471-1-usama.anjum@collabora.com> <20220825070926.2922471-3-usama.anjum@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220825070926.2922471-3-usama.anjum@collabora.com> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661412085; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tP8vuJpx7K79XdZweZuVWpvosA2GiYyx6Ibvmw//QZo=; b=tOdEvLXz9Zve/YjRWcBvgA8v7MldYTrEVrPGuDMBB1Fkr1xi1uS1AP1y6z/hBtulpL9SuX ynIPF21PIlnQV2tatY67jDTkIliS3TAPpN4uegJhfqKmcz++CNVEafyWmakZxGV2nOQXl5 IFqbwEkYwOvBvRc7qEHcSPHoZou3vFo= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=0KAAhJPp; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf18.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661412085; a=rsa-sha256; cv=none; b=AJnIt0yZpqLl+9Lfos7k3/a8ZJ4lRuEa+LW6QIf+OacXgmBkDjcwcxd9jpG5LBw75R+wQ1 zORLRCccXTKtXIPbTv/EC7UdvRz4lk5esbY14S1gXoVuEmG8SckU56/8tzKwx3XBFKfzlP da6xH8Pxp10PgxOUD/6X0dLCiuUUXzM= Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=0KAAhJPp; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf18.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 796F91C000E X-Stat-Signature: b8e9zbt1df5f8f6j3mmu5ob1dop38ggb X-Rspam-User: X-HE-Tag: 1661412085-8698 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 25, 2022 at 12:09:24PM +0500, Muhammad Usama Anjum wrote: > diff --git a/include/uapi/linux/fs.h b/include/uapi/linux/fs.h > index b7b56871029c..a7e48ba9457b 100644 > --- a/include/uapi/linux/fs.h > +++ b/include/uapi/linux/fs.h > @@ -305,4 +305,17 @@ typedef int __bitwise __kernel_rwf_t; > #define RWF_SUPPORTED (RWF_HIPRI | RWF_DSYNC | RWF_SYNC | RWF_NOWAIT |\ > RWF_APPEND) > > +struct pagemap_sd_args { > + void __user *start; > + int len; "int" is not a valid type to cross the user/kernel boundry, sorry. Please be explicit here (__u64? __u32?) > + loff_t __user *vec; > + int vec_len; > + int flags; Same with these. thanks, greg k-h