From: Greg KH <gregkh@linuxfoundation.org>
To: Muhammad Usama Anjum <usama.anjum@collabora.com>
Cc: Jonathan Corbet <corbet@lwn.net>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
Shuah Khan <shuah@kernel.org>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
"open list:PROC FILESYSTEM" <linux-fsdevel@vger.kernel.org>,
"open list:MEMORY MANAGEMENT" <linux-mm@kvack.org>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
kernel@collabora.com
Subject: Re: [PATCH v2 2/4] fs/proc/task_mmu: Implement IOCTL to get and clear soft dirty PTE bit
Date: Thu, 25 Aug 2022 09:21:19 +0200 [thread overview]
Message-ID: <Ywci73JxlWGCMnrK@kroah.com> (raw)
In-Reply-To: <20220825070926.2922471-3-usama.anjum@collabora.com>
On Thu, Aug 25, 2022 at 12:09:24PM +0500, Muhammad Usama Anjum wrote:
> diff --git a/include/uapi/linux/fs.h b/include/uapi/linux/fs.h
> index b7b56871029c..a7e48ba9457b 100644
> --- a/include/uapi/linux/fs.h
> +++ b/include/uapi/linux/fs.h
> @@ -305,4 +305,17 @@ typedef int __bitwise __kernel_rwf_t;
> #define RWF_SUPPORTED (RWF_HIPRI | RWF_DSYNC | RWF_SYNC | RWF_NOWAIT |\
> RWF_APPEND)
>
> +struct pagemap_sd_args {
> + void __user *start;
> + int len;
"int" is not a valid type to cross the user/kernel boundry, sorry.
Please be explicit here (__u64? __u32?)
> + loff_t __user *vec;
> + int vec_len;
> + int flags;
Same with these.
thanks,
greg k-h
next prev parent reply other threads:[~2022-08-25 7:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 7:09 [PATCH v2 0/4] Implement IOCTL to get and clear soft dirty PTE Muhammad Usama Anjum
2022-08-25 7:09 ` [PATCH v2 1/4] fs/proc/task_mmu: update functions to clear the soft-dirty bit Muhammad Usama Anjum
2022-08-25 7:09 ` [PATCH v2 2/4] fs/proc/task_mmu: Implement IOCTL to get and clear soft dirty PTE bit Muhammad Usama Anjum
2022-08-25 7:21 ` Greg KH [this message]
2022-08-25 7:22 ` Greg KH
2022-08-25 10:49 ` Muhammad Usama Anjum
2022-08-25 7:09 ` [PATCH v2 3/4] selftests: vm: add pagemap ioctl tests Muhammad Usama Anjum
2022-08-25 7:09 ` [PATCH v2 4/4] mm: add documentation of the new ioctl on pagemap Muhammad Usama Anjum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ywci73JxlWGCMnrK@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=kernel@collabora.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shuah@kernel.org \
--cc=usama.anjum@collabora.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox