From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A0DBC04AA5 for ; Thu, 25 Aug 2022 05:06:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DC4836B0074; Thu, 25 Aug 2022 01:06:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D7384940009; Thu, 25 Aug 2022 01:06:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C3CC9940008; Thu, 25 Aug 2022 01:06:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B69B96B0074 for ; Thu, 25 Aug 2022 01:06:28 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 964271404C3 for ; Thu, 25 Aug 2022 05:06:28 +0000 (UTC) X-FDA: 79836929256.22.DD63C9F Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) by imf13.hostedemail.com (Postfix) with ESMTP id 36CF520020 for ; Thu, 25 Aug 2022 05:06:28 +0000 (UTC) Received: by mail-pg1-f174.google.com with SMTP id 12so16906905pga.1 for ; Wed, 24 Aug 2022 22:06:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=JekSx0kO6S4WM/0DnT72Lgz62d0H30n1YLrlOtZWovc=; b=AUNgQf7gFEzqbm5x9lMsDjfa7EtuMSOi/HwkqoZhKrOJAhCTwY5FEGyhQpg2Ove3JU C9McQhtVIm2JviHOX5z6s79rOKa8X09KlVe8Q82BIQTbtmncvf6SmmCwTYqy6pVaGd+U ECJW4/c2la6tEAmGui8obi8Lhc5k5mUmpsLDnyf1FEa3giY8jy6V+AUxCsDsLFf1SKjT E4TV9oSVVAgWyT97A5oGiX5CZ8cp31QCETPo00kGrPiBtMT/AHsqKM6iMK5k7LyUXfUc /zkQxtl0YZar7asVQR/RFRwleJEI6JMrDs5/3J/xq8+mJ/od/exBBkubiKN0nbGjRrYQ KZCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=JekSx0kO6S4WM/0DnT72Lgz62d0H30n1YLrlOtZWovc=; b=vRYFZIV+CKCzQDQfzeUKYL88ESV2o+QDyjI5zHPCUs2ZjIEalPEcVuTxYuU0Kg3g3U ZKANiYpc+7pjv03g5tRahicI4wxuzK5eP+jmZSnGWEdTFqEZgguvtSOZggX/u8sYPvxi CAMY/3EU0hrCtHJdUWqAve93XkzngFIGe8qrxlKPrGe4p1JbVVqPlm+ZwY4QRr04bKH1 087ZGzdsAnucXxCElqY9okgS0KqgaSEku1OlAZoK7a+eCjCf4WWH7ukWn4Z/flCK6k6V A3iaWhc0lFFS1aDB4DMZpTbX6hLx5ysurloPwIYIKPaKk/SZ6gbh/HpGOldZjtW6eCg0 Jiug== X-Gm-Message-State: ACgBeo2YkS9iciM/DK9NELH9+jBqt5KP/pFyylx/FopE/Nn03/4UcyZU FBF2Udjyi2kNNch24ir9U52kynDfRYw= X-Google-Smtp-Source: AA6agR5bsNh2GD8M+FNB9LHg4/YXkoDrwAZvJ0BaLhdDIcA+yD3c/OL+WjfYa5pwwVzjSe2NajnGVA== X-Received: by 2002:a05:6a00:14c5:b0:536:7d2f:883e with SMTP id w5-20020a056a0014c500b005367d2f883emr2402372pfu.36.1661403987209; Wed, 24 Aug 2022 22:06:27 -0700 (PDT) Received: from hyeyoo ([114.29.91.56]) by smtp.gmail.com with ESMTPSA id d12-20020a170903230c00b00172ff94861fsm4865338plh.303.2022.08.24.22.06.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Aug 2022 22:06:26 -0700 (PDT) Date: Thu, 25 Aug 2022 14:06:22 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Vlastimil Babka Cc: kernel test robot , kbuild-all@lists.01.org, linux-mm@kvack.org Subject: Re: [vbabka-slab:for-6.1/common_kmalloc 12/17] mm/slab_common.c:1023:7: warning: no previous prototype for '__kmalloc_large_node' Message-ID: References: <202208241004.jZykmQOH-lkp@intel.com> <4eb30402-395c-6cb4-ab1e-a008c4bf32f8@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=AUNgQf7g; spf=pass (imf13.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.215.174 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661403988; a=rsa-sha256; cv=none; b=29/5rRG8uT8kDEgwtgTJBhu/xKuvoMTsha8GxSTIzlE0OZZY63zNa4K47cg0bqIRWL0mPv 0lmWyYBxK/sUZZcqOJP2reLEUpAVoofM4EYo1pw46oyUHL23VdZldPj+ZPmFeY6scgCX5n SF5O4plOskKPwCaMeH0oKTtLj/toF7c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661403988; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JekSx0kO6S4WM/0DnT72Lgz62d0H30n1YLrlOtZWovc=; b=jStpnwiBUVYspfB5rLWgJjjvoMf+Zbrva2Cnc8AanJR7QNMq0Zq/os+mVzvc8o6oUK1QwI vPwgvzZFccGMrexknFtXBMsLbybwECeWoiieaIIc2uRoHOOkymhSi/bgcfUt3c2OyranwF 89aJd+kFD66+pcQghFIG2uaj3cy2/mI= X-Rspam-User: X-Rspamd-Queue-Id: 36CF520020 X-Stat-Signature: tepfttkbgiwuq7m8h9y3qpu55bpcum88 Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=AUNgQf7g; spf=pass (imf13.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.215.174 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam01 X-HE-Tag: 1661403988-662558 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 24, 2022 at 04:27:10PM +0200, Vlastimil Babka wrote: > On 8/24/22 15:35, Hyeonggon Yoo wrote: > > On Wed, Aug 24, 2022 at 02:57:40PM +0200, Vlastimil Babka wrote: > > > On 8/24/22 05:49, Hyeonggon Yoo wrote: > > > > On Wed, Aug 24, 2022 at 10:46:55AM +0800, kernel test robot wrote: > > > > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/vbabka/slab.git for-6.1/common_kmalloc > > > > > head: b261334803b44092acd06be3c9f32c46af818359 > > > > > commit: 79c7527b9805edf14c952deca45de60a8a06a414 [12/17] mm/sl[au]b: generalize kmalloc subsystem > > > > > config: x86_64-randconfig-a015 (https://download.01.org/0day-ci/archive/20220824/202208241004.jZykmQOH-lkp@intel.com/config) > > > > > compiler: gcc-11 (Debian 11.3.0-5) 11.3.0 > > > > > reproduce (this is a W=1 build): > > > > > # https://git.kernel.org/pub/scm/linux/kernel/git/vbabka/slab.git/commit/?id=79c7527b9805edf14c952deca45de60a8a06a414 > > > > > git remote add vbabka-slab git://git.kernel.org/pub/scm/linux/kernel/git/vbabka/slab.git > > > > > git fetch --no-tags vbabka-slab for-6.1/common_kmalloc > > > > > git checkout 79c7527b9805edf14c952deca45de60a8a06a414 > > > > > # save the config file > > > > > mkdir build_dir && cp config build_dir/.config > > > > > make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash > > > > > > > > > > If you fix the issue, kindly add following tag where applicable > > > > > Reported-by: kernel test robot > > > > > > > > > > All warnings (new ones prefixed by >>): > > > > > > > > > > > > mm/slab_common.c:1023:7: warning: no previous prototype for '__kmalloc_large_node' [-Wmissing-prototypes] > > > > > 1023 | void *__kmalloc_large_node(size_t size, gfp_t flags, int node) > > > > > | ^~~~~~~~~~~~~~~~~~~~ > > > > > > > > Oh, I did not add static here. > > > > > > Weird, I didn't get this warning even with W=1. Only the kerneldoc issues. > > > > You can get with CONFIG_SLOB. > > > > > > Please pull: > > > > https://github.com/hygoni/linux.git slab-common-v4r1 > > > > > > > > Fixed warning above and also fixed wrong comment (@objp in comment but > > > > its name is actually 'object') > > > > > > > > git range-diff for-6.1/common_kmalloc~17...for-6.1/common_kmalloc \ > > > > slab-common-v4r1~17...slab-common-v4r1: > > > > > > > > 1: 0276f0da97e3 = 1: 0276f0da97e3 mm/slab: move NUMA-related code to __do_cache_alloc() > > > > 2: d5ea00e8d8c9 = 2: d5ea00e8d8c9 mm/slab: cleanup slab_alloc() and slab_alloc_node() > > > > 3: 48c55c42e6b8 = 3: 48c55c42e6b8 mm/slab_common: remove CONFIG_NUMA ifdefs for common kmalloc functions > > > > 4: cd8523b488ec = 4: cd8523b488ec mm/slab_common: cleanup kmalloc_track_caller() > > > > 5: 0b92d497e03a = 5: 0b92d497e03a mm/sl[au]b: factor out __do_kmalloc_node() > > > > 6: d43649c0f472 = 6: d43649c0f472 mm/slab_common: fold kmalloc_order_trace() into kmalloc_large() > > > > 7: cd6d756d6118 = 7: cd6d756d6118 mm/slub: move kmalloc_large_node() to slab_common.c > > > > 8: fe8f3819416e ! 8: ec277200c5dd mm/slab_common: kmalloc_node: pass large requests to page allocator > > > > @@ mm/slab_common.c: void *kmalloc_large(size_t size, gfp_t flags) > > > > EXPORT_SYMBOL(kmalloc_large); > > > > > > > > -void *kmalloc_large_node(size_t size, gfp_t flags, int node) > > > > -+void *kmalloc_large_node_notrace(size_t size, gfp_t flags, int node) > > > > ++static void *kmalloc_large_node_notrace(size_t size, gfp_t flags, int node) > > > > > > Hmm this (and following changes to kmalloc_large_node_notrace) seems to be > > > wrong, it's still called from slub.c and declared in slab.h at this point. > > > > Ah, I'm very sorry for wrong fix. > > > > > So I've fixed the warnings up locally and force-pushed updated > > > for-6.1/common_kmalloc (head is now ba5801e322), please double-check. > > > > kmalloc_large_node_notrace() need to be moved outside #ifdef CONFIG_SLOB > > when the declaration is in slab.h as it's used for SLOB too. > > (in patch 8) > > Thanks, done now. > Thanks! Looks good to me. -- Thanks, Hyeonggon