From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE889C48BE4 for ; Wed, 24 Aug 2022 20:48:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3BA696B0074; Wed, 24 Aug 2022 16:48:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 342246B0075; Wed, 24 Aug 2022 16:48:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 193B5940007; Wed, 24 Aug 2022 16:48:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 05D436B0074 for ; Wed, 24 Aug 2022 16:48:44 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D3A5980FD4 for ; Wed, 24 Aug 2022 20:48:43 +0000 (UTC) X-FDA: 79835674926.06.694DCA6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf17.hostedemail.com (Postfix) with ESMTP id 8546B40023 for ; Wed, 24 Aug 2022 20:48:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661374123; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/rRnDONf/MIAcvQvaU+OL/iys5bxrMY05ODAN/aEOnI=; b=aj/+ET2UnjpBLdj4Z8sxjtg36aqNF85XMtJ6JREFtjObE2EctYcMtdHYVXrsKzTP2orppa pHIwK90PoLNe+1XTWX6XU5UcREmVmLv7BiZRQyXom6GqT1DO7NxRJDFvvHR7iAKArigtU8 MS5VMR6NRj21Dqp1Mt2986CqLAdUbPs= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-658--ZHBQo3rOtqAuNwJttQaPQ-1; Wed, 24 Aug 2022 16:48:41 -0400 X-MC-Unique: -ZHBQo3rOtqAuNwJttQaPQ-1 Received: by mail-qv1-f72.google.com with SMTP id ly9-20020a0562145c0900b00496e3810e40so6227906qvb.12 for ; Wed, 24 Aug 2022 13:48:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=/rRnDONf/MIAcvQvaU+OL/iys5bxrMY05ODAN/aEOnI=; b=BKE8Vhcor4WVVYeCM0pjZi53Bd0Tupd704UYNzCbh/JzQ9F0Nb0acib3ncYkHWW/8p EAQtFSVZVRQLsvThctf+ehtmDaiRfDCvMjNy+6nC6pfjXTKqw+okcOznRU2i1O533pwP 9dUM+DzjIx3rkjDWVUvZPwc/3SjAHUocmunkyl45BXxhMbGz//q35Qh6NKBCDqlxNnj5 g5VnA2evurIpS1CXoTsGoBAXjn96LSPqW3Jsh3qcF8uTEGm0Mh6wHN/lQy8HwnJtw+7f skSiPRK2xUOXLEPVCBARcGNeBXewtTw38pPNivi6b9Yd4CX7FJPjDj3/k5GpLdDfvbLg U9cw== X-Gm-Message-State: ACgBeo2sgp6Y0g8xQbQVr/ZKslNzosgSchOGVdTETIK9Zs56Cz0mPiXK RKmC08wrXtjQ/rEJjEcv9BxShGDwSaKV0gyT5P4or/AjKQkUm2WoxtJBLz54RmAaKyb125Wom2Z /Gs5u7nTgZ8Y= X-Received: by 2002:ad4:4eaf:0:b0:496:ac46:2d9c with SMTP id ed15-20020ad44eaf000000b00496ac462d9cmr868936qvb.82.1661374121424; Wed, 24 Aug 2022 13:48:41 -0700 (PDT) X-Google-Smtp-Source: AA6agR4s25beJjrLygCxW4UWpRepdZLtdhOdc0j/yJivVpKekwHMGeWPIw0hJ6uQX5trRhdvaC3qCw== X-Received: by 2002:ad4:4eaf:0:b0:496:ac46:2d9c with SMTP id ed15-20020ad44eaf000000b00496ac462d9cmr868905qvb.82.1661374121119; Wed, 24 Aug 2022 13:48:41 -0700 (PDT) Received: from xz-m1.local (bras-base-aurron9127w-grc-35-70-27-3-10.dsl.bell.ca. [70.27.3.10]) by smtp.gmail.com with ESMTPSA id g9-20020ac85809000000b00344576bcfefsm13976258qtg.70.2022.08.24.13.48.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Aug 2022 13:48:40 -0700 (PDT) Date: Wed, 24 Aug 2022 16:48:38 -0400 From: Peter Xu To: Alistair Popple Cc: "Huang, Ying" , Nadav Amit , huang ying , Linux MM , Andrew Morton , LKML , "Sierra Guiza, Alejandro (Alex)" , Felix Kuehling , Jason Gunthorpe , John Hubbard , David Hildenbrand , Ralph Campbell , Matthew Wilcox , Karol Herbst , Lyude Paul , Ben Skeggs , Logan Gunthorpe , paulus@ozlabs.org, linuxppc-dev@lists.ozlabs.org, stable@vger.kernel.org Subject: Re: [PATCH v2 1/2] mm/migrate_device.c: Copy pte dirty bit to page Message-ID: References: <87o7wjtn2g.fsf@nvdebian.thelocal> <87tu6bbaq7.fsf@yhuang6-desk2.ccr.corp.intel.com> <1D2FB37E-831B-445E-ADDC-C1D3FF0425C1@gmail.com> <87czcyawl6.fsf@yhuang6-desk2.ccr.corp.intel.com> <874jy9aqts.fsf@yhuang6-desk2.ccr.corp.intel.com> <87czcqiecd.fsf@nvdebian.thelocal> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="aj/+ET2U"; spf=pass (imf17.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661374123; a=rsa-sha256; cv=none; b=IzYW8MRJa9asgIPuHJ9OcZe9Yh0d58YOD05aYdJ52kIZF+gaD+2kG5mz3xcYrS4MbXNzQI clztLEJZIxdWHIZYIH3dHz/UCBkNVqP6ftwQRGLJDz28JhmHz8ZdtTnQFIddVfnH+awB8c VkMngbh8Wfl9S1p8pMeqYX2IrSE3Eik= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661374123; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/rRnDONf/MIAcvQvaU+OL/iys5bxrMY05ODAN/aEOnI=; b=wcaKoHCSbiG6qE4ZsBqJtNfBnO8//VIyCH/REhLLr9yy3pD3lunWNpW6fm8ddD0/QZPzCH aldPb8h6ytz6yVgDkgPzk/IUb2b/Y9Xx/gRdV3FuEl7cn4MDdvpts59y1Zm2Fm7ahYZQQQ Nns6LWfcsU4WqbX1LBOv/qWneaLivm8= Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="aj/+ET2U"; spf=pass (imf17.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Stat-Signature: dmbsg57tp4wfucjxz96zwsqzkyt4ayei X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 8546B40023 X-Rspam-User: X-HE-Tag: 1661374123-977462 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 24, 2022 at 04:25:44PM -0400, Peter Xu wrote: > On Wed, Aug 24, 2022 at 11:56:25AM +1000, Alistair Popple wrote: > > >> Still I don't know whether there'll be any side effect of having stall tlbs > > >> in !present ptes because I'm not familiar enough with the private dev swap > > >> migration code. But I think having them will be safe, even if redundant. > > > > What side-effect were you thinking of? I don't see any issue with not > > TLB flushing stale device-private TLBs prior to the migration because > > they're not accessible anyway and shouldn't be in any TLB. > > Sorry to be misleading, I never meant we must add them. As I said it's > just that I don't know the code well so I don't know whether it's safe to > not have it. > > IIUC it's about whether having stall system-ram stall tlb in other > processor would matter or not here. E.g. some none pte that this code > collected (boosted both "cpages" and "npages" for a none pte) could have > stall tlb in other cores that makes the page writable there. For this one, let me give a more detailed example. It's about whether below could happen: thread 1 thread 2 thread 3 -------- -------- -------- write to page P (data=P1) (cached TLB writable) zap_pte_range() pgtable lock clear pte for page P pgtable unlock ... migrate_vma_collect pte none, npages++, cpages++ allocate device page copy data (with P1) map pte as device swap write to page P again (data updated from P1->P2) flush tlb Then at last from processor side P should have data P2 but actually from device memory it's P1. Data corrupt. > > When I said I'm not familiar with the code, it's majorly about one thing I > never figured out myself, in that migrate_vma_collect_pmd() has this > optimization to trylock on the page, collect if it succeeded: > > /* > * Optimize for the common case where page is only mapped once > * in one process. If we can lock the page, then we can safely > * set up a special migration page table entry now. > */ > if (trylock_page(page)) { > ... > } else { > put_page(page); > mpfn = 0; > } > > But it's kind of against a pure "optimization" in that if trylock failed, > we'll clear the mpfn so the src[i] will be zero at last. Then will we > directly give up on this page, or will we try to lock_page() again > somewhere? > > The future unmap op is also based on this "cpages", not "npages": > > if (args->cpages) > migrate_vma_unmap(args); > > So I never figured out how this code really works. It'll be great if you > could shed some light to it. > > Thanks, > > -- > Peter Xu -- Peter Xu