From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E867BC32793 for ; Wed, 24 Aug 2022 13:35:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 847AA6B0074; Wed, 24 Aug 2022 09:35:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7F6DC6B0075; Wed, 24 Aug 2022 09:35:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6BF8E6B0078; Wed, 24 Aug 2022 09:35:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5FA716B0074 for ; Wed, 24 Aug 2022 09:35:10 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3705D160F88 for ; Wed, 24 Aug 2022 13:35:10 +0000 (UTC) X-FDA: 79834582380.16.01BF882 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by imf21.hostedemail.com (Postfix) with ESMTP id CC3031C0053 for ; Wed, 24 Aug 2022 13:35:09 +0000 (UTC) Received: by mail-pf1-f176.google.com with SMTP id y127so13534860pfy.5 for ; Wed, 24 Aug 2022 06:35:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=qocgJ1n7e6jaUz2/TxFGeimXF+dLsR/37HKe7pW+lfE=; b=L7sevIsNZ8ObJ2QgFW1LzFPb1Knm9FnbehWTdMVYgaIl5S7Z9ftfVVaVf+ukojHUZ+ i8dgsBC32bohGSgzhn8JMtE3M6o+KcUCTQhayZwpa1RQ50XVOQOl49Ub0Y9rxQsFcq6c gelBQHkqcUEE1HNj/ZbbJ0sSEsB8ALFCG91DDJ4YynHTUB2mJvvYtHKjNtztKlYF5HCR kW4Q+upsj1kCNorpiqtmOoicYmMjrWNM3lllIrM3eUbD9/+JMkjtKmnoMbQIwWyrq8gV BAW4PDhY0cHJLBKFqiuSiHTJGM3kbA9oPAIgc3TttXOAneen7MFi/EUWeXCog023SXr/ 8YSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=qocgJ1n7e6jaUz2/TxFGeimXF+dLsR/37HKe7pW+lfE=; b=1lZiZdCkZZ6/b8hL0h5zNMtMQRTPk8PqvLan9SIecHfmZiQXHkodqw6xCWEIBp9C8w 1dJl/hjJZHfpt/N2BTGw1ztlMWt29NiNCw2r6m2G2BecgovQKIU4YhUcK7iJ5hBBN85o R06OInkX97M7SmPsMuo5YTQRhxLU4qhsutG5A1hvBox1OO7nxL6gEixQQPZak9g3tSin 3nVYgZKGooM2/TvBkP2yS8Q1FkMynjZ5/y00n8eNZINeuB02mnIIAwhkCrbhviDRWYU+ MR3Tmz9P71S9SI4LueOU21T19ZmChrfQJBRhc+7v1KQv0JaD7CiMDXMIkwI1xFI8/qHH E4VQ== X-Gm-Message-State: ACgBeo1ixjSpGrYbbUdJKb2hwruXeGxjP7Y/aYtq0X2GoGnmHhipYIj6 JnLSDxq/Gtv3tsXD6Cqghg0= X-Google-Smtp-Source: AA6agR6S0xj9nbvHzjHXkHIFAwdNJytBLNZbUajgMR72kFM0XUinNJ1F5aOs+3UBIUZe69cP2b4yNQ== X-Received: by 2002:a62:640a:0:b0:536:1f9b:8ace with SMTP id y10-20020a62640a000000b005361f9b8acemr23883498pfb.23.1661348108679; Wed, 24 Aug 2022 06:35:08 -0700 (PDT) Received: from hyeyoo ([114.29.91.56]) by smtp.gmail.com with ESMTPSA id c16-20020a621c10000000b0052f3a7bc29fsm12809210pfc.202.2022.08.24.06.35.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Aug 2022 06:35:07 -0700 (PDT) Date: Wed, 24 Aug 2022 22:35:03 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Vlastimil Babka Cc: kernel test robot , kbuild-all@lists.01.org, linux-mm@kvack.org Subject: Re: [vbabka-slab:for-6.1/common_kmalloc 12/17] mm/slab_common.c:1023:7: warning: no previous prototype for '__kmalloc_large_node' Message-ID: References: <202208241004.jZykmQOH-lkp@intel.com> <4eb30402-395c-6cb4-ab1e-a008c4bf32f8@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4eb30402-395c-6cb4-ab1e-a008c4bf32f8@suse.cz> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661348109; a=rsa-sha256; cv=none; b=ZQHAHK0WTskk9jZNj59pbxCdVZlvrjEgLxD6czs/QahjE5aOd1lFENTf2U/PXJPM5XJr3r ucZJGbP0617YStlp5AGb/wjeTVMcSQ5W1QNQgsCvkNmi7JJCGRqZV0LUdyE/8TNIXGWBX8 d9Tzg5fPUB8zNMS7CkbfsrXZHqpsCI4= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=L7sevIsN; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf21.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.210.176 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661348109; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qocgJ1n7e6jaUz2/TxFGeimXF+dLsR/37HKe7pW+lfE=; b=GMH+wO7XiDAqemyP1uN3c9dXBFG2ylPgDJjyQfVjn1x8EBVHzKryILM9joMbBljCt4YfFN X+Fu9OPnekSdX2xucQJd+YJVyhWgOUoxEA22X5I1PwDlONFCObzBMGjE2lDvp/SH4ASIl0 Oz5ZTx9fqPOWD1uycGxKlzrPvbXVEzg= Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=L7sevIsN; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf21.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.210.176 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com X-Rspamd-Queue-Id: CC3031C0053 X-Rspamd-Server: rspam02 X-Stat-Signature: cyxxohgfnmrtd3rw5obm1mgsoisfs7ma X-Rspam-User: X-HE-Tag: 1661348109-869177 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 24, 2022 at 02:57:40PM +0200, Vlastimil Babka wrote: > On 8/24/22 05:49, Hyeonggon Yoo wrote: > > On Wed, Aug 24, 2022 at 10:46:55AM +0800, kernel test robot wrote: > > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/vbabka/slab.git for-6.1/common_kmalloc > > > head: b261334803b44092acd06be3c9f32c46af818359 > > > commit: 79c7527b9805edf14c952deca45de60a8a06a414 [12/17] mm/sl[au]b: generalize kmalloc subsystem > > > config: x86_64-randconfig-a015 (https://download.01.org/0day-ci/archive/20220824/202208241004.jZykmQOH-lkp@intel.com/config) > > > compiler: gcc-11 (Debian 11.3.0-5) 11.3.0 > > > reproduce (this is a W=1 build): > > > # https://git.kernel.org/pub/scm/linux/kernel/git/vbabka/slab.git/commit/?id=79c7527b9805edf14c952deca45de60a8a06a414 > > > git remote add vbabka-slab git://git.kernel.org/pub/scm/linux/kernel/git/vbabka/slab.git > > > git fetch --no-tags vbabka-slab for-6.1/common_kmalloc > > > git checkout 79c7527b9805edf14c952deca45de60a8a06a414 > > > # save the config file > > > mkdir build_dir && cp config build_dir/.config > > > make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash > > > > > > If you fix the issue, kindly add following tag where applicable > > > Reported-by: kernel test robot > > > > > > All warnings (new ones prefixed by >>): > > > > > > > > mm/slab_common.c:1023:7: warning: no previous prototype for '__kmalloc_large_node' [-Wmissing-prototypes] > > > 1023 | void *__kmalloc_large_node(size_t size, gfp_t flags, int node) > > > | ^~~~~~~~~~~~~~~~~~~~ > > > > Oh, I did not add static here. > > Weird, I didn't get this warning even with W=1. Only the kerneldoc issues. You can get with CONFIG_SLOB. > > Please pull: > > https://github.com/hygoni/linux.git slab-common-v4r1 > > > > Fixed warning above and also fixed wrong comment (@objp in comment but > > its name is actually 'object') > > > > git range-diff for-6.1/common_kmalloc~17...for-6.1/common_kmalloc \ > > slab-common-v4r1~17...slab-common-v4r1: > > > > 1: 0276f0da97e3 = 1: 0276f0da97e3 mm/slab: move NUMA-related code to __do_cache_alloc() > > 2: d5ea00e8d8c9 = 2: d5ea00e8d8c9 mm/slab: cleanup slab_alloc() and slab_alloc_node() > > 3: 48c55c42e6b8 = 3: 48c55c42e6b8 mm/slab_common: remove CONFIG_NUMA ifdefs for common kmalloc functions > > 4: cd8523b488ec = 4: cd8523b488ec mm/slab_common: cleanup kmalloc_track_caller() > > 5: 0b92d497e03a = 5: 0b92d497e03a mm/sl[au]b: factor out __do_kmalloc_node() > > 6: d43649c0f472 = 6: d43649c0f472 mm/slab_common: fold kmalloc_order_trace() into kmalloc_large() > > 7: cd6d756d6118 = 7: cd6d756d6118 mm/slub: move kmalloc_large_node() to slab_common.c > > 8: fe8f3819416e ! 8: ec277200c5dd mm/slab_common: kmalloc_node: pass large requests to page allocator > > @@ mm/slab_common.c: void *kmalloc_large(size_t size, gfp_t flags) > > EXPORT_SYMBOL(kmalloc_large); > > > > -void *kmalloc_large_node(size_t size, gfp_t flags, int node) > > -+void *kmalloc_large_node_notrace(size_t size, gfp_t flags, int node) > > ++static void *kmalloc_large_node_notrace(size_t size, gfp_t flags, int node) > > Hmm this (and following changes to kmalloc_large_node_notrace) seems to be > wrong, it's still called from slub.c and declared in slab.h at this point. Ah, I'm very sorry for wrong fix. > So I've fixed the warnings up locally and force-pushed updated > for-6.1/common_kmalloc (head is now ba5801e322), please double-check. kmalloc_large_node_notrace() need to be moved outside #ifdef CONFIG_SLOB when the declaration is in slab.h as it's used for SLOB too. (in patch 8) -- Thanks, Hyeonggon