From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCAFCC00140 for ; Wed, 24 Aug 2022 09:38:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3342C940008; Wed, 24 Aug 2022 05:38:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E462940007; Wed, 24 Aug 2022 05:38:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1AC0B940008; Wed, 24 Aug 2022 05:38:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0B858940007 for ; Wed, 24 Aug 2022 05:38:33 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id CE0C6C11E3 for ; Wed, 24 Aug 2022 09:38:32 +0000 (UTC) X-FDA: 79833986064.17.C58784B Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) by imf04.hostedemail.com (Postfix) with ESMTP id 854004003B for ; Wed, 24 Aug 2022 09:38:32 +0000 (UTC) Received: by mail-pg1-f180.google.com with SMTP id w13so9464727pgq.7 for ; Wed, 24 Aug 2022 02:38:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=SKcPpqHKjW4e2dhAdJ5zvkqLvQknUi1MfWlt2XH7w80=; b=h9RlhLc54hOltb+I54bC5StmQ37NtKmehwI/TwS0dzGaCKZD05iCyNGSpEg32HWW0z 3HheDjW0jnjnBqwmR0ywQsIfPY30imJC8OoEXKBm11Kv0XmWmKo2hQwsU54+ZyB7+6d+ ZlBNQeaUriKgIpkCck03aEk+XtmH0m5HntfEz0fwHNtUBSHPmwKqObYiFwQsaAlRjxWP WR1yRSzf6N0KIgQFSljyFssDPR3CnVT31xiQ4QYaf9qLi4clcaiIFc9V6HklueBlMPYb G/I7wdhqR68fH4Hv7sy59Xk9N7VoqiVSg7DxDAdNFDOGTamwV0acq1nuXCehDIt5H/BG F6dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=SKcPpqHKjW4e2dhAdJ5zvkqLvQknUi1MfWlt2XH7w80=; b=sqEPOWG1EMUHFUX/D2FOlkjsFgWyrgWZvhkI6jJxaULfebZ0iSwa+PsjBUVQ+wR3wC sH9zS0DPttB23uGLPfMvSrRA4i2qWUuuVsuU8msLREvdQlqDxiZVoXlebSZJFnqnN29V ncPFg2s8TciacszOBWn0PnSaNl4DrT+/sHpvLbP/N2ZZicW3pAFwHTE2efaItLH+UC3i BKM/NdxHKcdb9c1TvzOV4szGDtjb735mvtk4xaLVIQeAM2qnpdS1c57lIYJNFhb5lI00 Hwr8n725A+eBC5NWriWm2csCBfIAT1pEl+7Wa7hi/RD+/z/NTACPp/9QJDU6EvXllnZV JS6Q== X-Gm-Message-State: ACgBeo2+Rv9v1Dwnbgu7BlVcrr/weCh1zJyP8HnpeouzzfdNOkRe4aCi ZkG/qRLWExDvlMkQv+W2VuA= X-Google-Smtp-Source: AA6agR7YCKWuZ9M6+27u0mPvnyXfOLCELSkowfRppRNp4tSNBgB+dNOwgPdc1czPKWmmQmhsT0ol2A== X-Received: by 2002:a05:6a00:ac6:b0:530:3197:48b6 with SMTP id c6-20020a056a000ac600b00530319748b6mr29136227pfl.80.1661333911296; Wed, 24 Aug 2022 02:38:31 -0700 (PDT) Received: from debian.me (subs03-180-214-233-21.three.co.id. [180.214.233.21]) by smtp.gmail.com with ESMTPSA id mt4-20020a17090b230400b001fb18855440sm914547pjb.31.2022.08.24.02.38.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Aug 2022 02:38:30 -0700 (PDT) Received: by debian.me (Postfix, from userid 1000) id CDFA210119B; Wed, 24 Aug 2022 16:38:26 +0700 (WIB) Date: Wed, 24 Aug 2022 16:38:26 +0700 From: Bagas Sanjaya To: xu xin Cc: akpm@linux-foundation.org, corbet@lwn.net, adobriyan@gmail.com, willy@infradead.org, hughd@google.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, xu xin , Xiaokai Ran , Yang Yang Subject: Re: [PATCH v3 2/2] ksm: add profit monitoring documentation Message-ID: References: <20220824070559.219977-1-xu.xin16@zte.com.cn> <20220824070821.220092-1-xu.xin16@zte.com.cn> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6K/xkb9YUOfBCWvM" Content-Disposition: inline In-Reply-To: <20220824070821.220092-1-xu.xin16@zte.com.cn> ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=h9RlhLc5; spf=pass (imf04.hostedemail.com: domain of bagasdotme@gmail.com designates 209.85.215.180 as permitted sender) smtp.mailfrom=bagasdotme@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661333912; a=rsa-sha256; cv=none; b=ieKblV3Jrr3EUKCCkzSKeLuYmCz5NisFzUjUizDv029fLzb8e+g2I7ZoeKgezSBEmAbeVn M1l8DwbTC5UYYwxz3DT1yMgU1Bj6So5pY/e5K8rL0p0+AeflDxUQldRcm6eqJdOcHcWgyh c0pXpnlZ+ykWJQWZ+6nfztbsoEuVDA0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661333912; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SKcPpqHKjW4e2dhAdJ5zvkqLvQknUi1MfWlt2XH7w80=; b=QDl90pZmaGyITwhrYdaow9QZX5yiRNPiVFS07t/GWfyNAnaXmrzAVtHqxJYNKlK8ryUrN6 Yr1N8h8jX9w4xyfkOJ2t1siEYJtAYT4M4o/1WiGRZMPY9cvVKwguyD8cG+aVkLc8HH9LB/ GDjVd/mjOMJQ4jT7I3QJzSrZfmlunrg= X-Stat-Signature: 7g3j1szfa876pyk5u6j7j5oa41sbfpxu X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 854004003B Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=h9RlhLc5; spf=pass (imf04.hostedemail.com: domain of bagasdotme@gmail.com designates 209.85.215.180 as permitted sender) smtp.mailfrom=bagasdotme@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1661333912-105054 X-Bogosity: Ham, tests=bogofilter, spamicity=0.007652, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --6K/xkb9YUOfBCWvM Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 24, 2022 at 07:08:21AM +0000, xu xin wrote: > +1) How to determine whether KSM save memory or consume memory in system-= wide > +range? Here is a simple approximate calculation for reference: > + > + general_profit =3D~ pages_sharing * sizeof(page) - (all_rmap_items) * > + sizeof(rmap_item); > + > +where all_rmap_items can be easily obtained by summing ``pages_sharing``, > +``pages_shared``, ``pages_unshared`` and ``pages_volatile``. > + > +2) The KSM profit inner a single process can be similarly obtained by the > +following approximate calculation: > + > + process_profit =3D~ ksm_merging_sharing * sizeof(page) - > + ksm_rmp_items * sizeof(rmap_item). > + The profit formula above can be put into code blocks. Also, align the numbered list texts, like: ---- >8 ---- diff --git a/Documentation/admin-guide/mm/ksm.rst b/Documentation/admin-gui= de/mm/ksm.rst index 40bc11f6fa15fa..7e3092fe407e37 100644 --- a/Documentation/admin-guide/mm/ksm.rst +++ b/Documentation/admin-guide/mm/ksm.rst @@ -194,22 +194,22 @@ be merged, but some may not be abled to be merged aft= er being checked several times, which are unprofitable memory consumed. =20 1) How to determine whether KSM save memory or consume memory in system-wi= de -range? Here is a simple approximate calculation for reference: + range? Here is a simple approximate calculation for reference:: =20 general_profit =3D~ pages_sharing * sizeof(page) - (all_rmap_items) * sizeof(rmap_item); =20 -where all_rmap_items can be easily obtained by summing ``pages_sharing``, -``pages_shared``, ``pages_unshared`` and ``pages_volatile``. + where all_rmap_items can be easily obtained by summing ``pages_sharing`= `, + ``pages_shared``, ``pages_unshared`` and ``pages_volatile``. =20 2) The KSM profit inner a single process can be similarly obtained by the -following approximate calculation: + following approximate calculation:: =20 process_profit =3D~ ksm_merging_sharing * sizeof(page) - ksm_rmp_items * sizeof(rmap_item). =20 -where both ksm_merging_sharing and ksm_rmp_items are shown under the direc= tory -``/proc//``. + where both ksm_merging_sharing and ksm_rmp_items are shown under the + directory ``/proc//``. =20 From the perspective of application, a high ratio of ``ksm_rmp_items`` to ``ksm_merging_sharing`` means a bad madvise-applied policy, so developers = or Thanks. --=20 An old man doll... just what I always wanted! - Clara --6K/xkb9YUOfBCWvM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCYwXxiQAKCRD2uYlJVVFO o9aKAQCeUXLi0ItbLyz2LIdrV2OFgXZOlmIWc6VYlyKgeBA9UAD5AVrDVXP2Ew0h 0AKb+kU+/YVqox6NvvlZm0p6IPiuLAg= =v9oU -----END PGP SIGNATURE----- --6K/xkb9YUOfBCWvM--