From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5E86C00140 for ; Wed, 24 Aug 2022 10:10:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5D92E940007; Wed, 24 Aug 2022 06:10:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 56C596B0074; Wed, 24 Aug 2022 06:10:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 42915940007; Wed, 24 Aug 2022 06:10:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 309EE6B0073 for ; Wed, 24 Aug 2022 06:10:14 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 034EB41830 for ; Wed, 24 Aug 2022 10:10:13 +0000 (UTC) X-FDA: 79834065948.12.1BD114B Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf02.hostedemail.com (Postfix) with ESMTP id 7E93A80043 for ; Wed, 24 Aug 2022 10:10:13 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 28C6A22AAC; Wed, 24 Aug 2022 10:10:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1661335812; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5UBtlLfUuUQ520o2VtNKOcRggH/l+UXJkaGMTl14yxU=; b=VVejBBpiXeTDUZBonbbIL11hbE3tkmvJKHK3y8kh6FvrsApcgQzT1+Kz2ZyzlmLE3D+f60 UPx4tawWCBVG1R/NkDNwGXZhvbf7IBOj8tNKp4qFfDmxRgMlvc6MRzb16FeFEt+dXqOeYs SKv7YOQNvlMjrxH3fb51D7ugLzLiIpM= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 018D613AC0; Wed, 24 Aug 2022 10:10:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id DkFZOQP5BWP1EwAAMHmgww (envelope-from ); Wed, 24 Aug 2022 10:10:11 +0000 Date: Wed, 24 Aug 2022 12:10:11 +0200 From: Michal Hocko To: Mel Gorman Cc: Andrew Morton , Patrick Daly , David Hildenbrand , linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] mm/page_alloc: Fix race condition between build_all_zonelists and page allocation Message-ID: References: <20220824094901.rbpkackn2qmt36hg@techsingularity.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220824094901.rbpkackn2qmt36hg@techsingularity.net> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661335813; a=rsa-sha256; cv=none; b=1RNYkjlzLjfiQptnwDFIhu3eq28V7+OizK85fuXSSKrqPEHJfOz5G080psZ/tMDBfig2hE t3KkuSteSu5Z7VX8TjFseQdulestOCLY4/NWSSLCdoxyco+WraQJHiVYkOn4ehErWBH1sp FikYrLaenGCbjLOziBZ4CXUADAQBLLk= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=VVejBBpi; spf=pass (imf02.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661335813; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5UBtlLfUuUQ520o2VtNKOcRggH/l+UXJkaGMTl14yxU=; b=cB8yEND1WQ0GVnzqLRY/sZsoHiZlgqH2L0x/oeq+SCONTWsuXytJA/QX0mE6g9UZ6L+oZL 0zBfof7vNhi32SANnxxYgfAaTzkQE9PSiCeOxjAbqWrimDxSDjmqcgBz8AqiAxkFjRv22f pmvHSkpv2PDnRGEHCzi6mk9BY9xLWBM= X-Rspam-User: X-Stat-Signature: ad9czzpxwxosmd4nndz834eekzcchjep X-Rspamd-Queue-Id: 7E93A80043 X-Rspamd-Server: rspam12 Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=VVejBBpi; spf=pass (imf02.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com X-HE-Tag: 1661335813-992360 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 24-08-22 10:49:01, Mel Gorman wrote: > +static unsigned int zonelist_iter_begin(void) > +{ > + if (IS_ENABLED(CONFIG_MEMORY_HOTREMOVE)) > + return 0; > + > + return read_seqbegin(&zonelist_update_seq); > +} > + > +static unsigned int check_retry_zonelist(unsigned int seq) > +{ > + if (IS_ENABLED(CONFIG_MEMORY_HOTREMOVE)) > + return seq; > + > + return read_seqretry(&zonelist_update_seq, seq); > +} these should be negated -- Michal Hocko SUSE Labs