From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EA13C00140 for ; Wed, 24 Aug 2022 03:54:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 94345940008; Tue, 23 Aug 2022 23:54:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8CB776B0074; Tue, 23 Aug 2022 23:54:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7937B940008; Tue, 23 Aug 2022 23:54:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 663BD6B0073 for ; Tue, 23 Aug 2022 23:54:24 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 35D63140116 for ; Wed, 24 Aug 2022 03:54:24 +0000 (UTC) X-FDA: 79833118848.07.CF7829B Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) by imf18.hostedemail.com (Postfix) with ESMTP id CAE2D1C0009 for ; Wed, 24 Aug 2022 03:54:23 +0000 (UTC) Received: by mail-pg1-f169.google.com with SMTP id f4so12106140pgc.12 for ; Tue, 23 Aug 2022 20:54:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=PhpgZPFUtaUU9Q/iQOAzkVlGcu68oagMhy31aoIg+aA=; b=NNBeqrnklN2r2dr4Dqt8daNMCTW3z7H1rnjvaDn2gWmThrsvbpUOf7D0O+9/j3rzoW +WpAMznacX2JKhk+6q4ZCzCTQ1gHzTxmtzNvJq82f6TQ77BB3+ChKnYnxaen9vQo8f0Z zdrTxj30KMpWcdanZlqz5K3zVYx0/zFTDcqHLGEJKffTP8d0HwfTBG5cJJsp09No0l1R f0LTdtQlyl+c89ocXNz7vQvTtxndY56O62ex8h1grOP02reWznwas3F7WIaYTrgPjW/+ cZKTbkDcMPKHRh/RxRSqjSVmJp+RowmhgNfX24JwhWJ4SfevgF+xXuNm2WFZFC/n5PEs vMYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=PhpgZPFUtaUU9Q/iQOAzkVlGcu68oagMhy31aoIg+aA=; b=UFBl7d82b5nCcKXWD0fTpCn2DzPexui/4KlpxUYrH9sMKeZYbsJRqBi259uFugzgj/ qHEfmA0YoUiom84iIu6JjLrgLSbVKSu6bGHsDl3X/+brjRSD7FrIEGFh/UN+eUc6HcMY Q7LJntpE9B5iuOOV80VOeiKzOTXvBrk2K6g2EgRdxTXsHYBUHJ7qv5Der+omgUE1E3KP tKNhnYoHtzlCmXD/lqIuZtt9F12QWF92K/MMDsxnKJ+RKBZaZJD7uq+47oNPw0K+6ejP f/ux29+4vLFC17tUKCHfRcMCU9cJwOCPkkEdzrDMIfwAcfnR2PcyDCRgn8elslRRkUVA n8rg== X-Gm-Message-State: ACgBeo3V/kl5B8Rn8kYCESl3nwmujhUdooClOOOi7u/Zd04Nobb1fwk1 MmiKzEA0xrXVCzijV2+G4RY= X-Google-Smtp-Source: AA6agR7dXxxKnMRZUrOTwunLitSYOa4t6HHRBE/PA8aK7edN/NphlVv1F5mJiKwnyVIE6LF9sP9sKA== X-Received: by 2002:a63:2a02:0:b0:42b:2711:d534 with SMTP id q2-20020a632a02000000b0042b2711d534mr64858pgq.176.1661313262784; Tue, 23 Aug 2022 20:54:22 -0700 (PDT) Received: from hyeyoo ([114.29.91.56]) by smtp.gmail.com with ESMTPSA id 88-20020a17090a09e100b001f94d25bfabsm174610pjo.28.2022.08.23.20.54.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Aug 2022 20:54:19 -0700 (PDT) Date: Wed, 24 Aug 2022 12:54:14 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Vlastimil Babka Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 13/17] mm/sl[au]b: cleanup kmem_cache_alloc[_node]_trace() Message-ID: References: <20220817101826.236819-1-42.hyeyoo@gmail.com> <20220817101826.236819-14-42.hyeyoo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661313263; a=rsa-sha256; cv=none; b=Tk3k6DDnwil5qNRr51mnRfBLY5N+X68X+wS/gSE5sQ1TbNvJ+Osdm9aCDPrWvZsXiCBKnc euS9YrzeBvnRpVz9CGp6qg22MreAQMEcgLT75w9lev98C0XP9kQkDrHjNkUbA+IJLaMp1J OW3OOKgzGJezchVoj9DYxOpPugtd4QY= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=NNBeqrnk; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf18.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.215.169 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661313263; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PhpgZPFUtaUU9Q/iQOAzkVlGcu68oagMhy31aoIg+aA=; b=BvMxVVaCn8aIraccdmdK2Kzd7dWlxbEpzyhK5XjztZE/Lzx2NWqCJJfiMLPALdCo8XUGLe Exu5gt7GhHgSS7YdpkqBoycsA7UGU4u7uiOEJkMVIxHXPAme3b3ByHCck6h5P9T0Cm/4TR ZUnncGuBYyedTr3Qp0Ho/MHkRU5QMTc= Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=NNBeqrnk; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf18.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.215.169 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com X-Stat-Signature: 6q6bfcftjnaio5u9ndd6qgimw8kw3mtk X-Rspamd-Queue-Id: CAE2D1C0009 X-Rspamd-Server: rspam03 X-Rspam-User: X-HE-Tag: 1661313263-844106 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 23, 2022 at 05:04:36PM +0200, Vlastimil Babka wrote: > On 8/17/22 12:18, Hyeonggon Yoo wrote: > > This patch does: > > I've removed this line locally and re-idented the rest. Ah, thanks. looks better. > > - Despite its name, kmem_cache_alloc[_node]_trace() is hook for > > inlined kmalloc. So rename it to kmalloc[_node]_trace(). > > > > - Move its implementation to slab_common.c by using > > __kmem_cache_alloc_node(), but keep CONFIG_TRACING=n varients to > > save a function call when CONFIG_TRACING=n. > > > > - Use __assume_kmalloc_alignment for kmalloc[_node]_trace > > instead of __assume_slab_alignement. Generally kmalloc has > > larger alignment requirements. > > > > Suggested-by: Vlastimil Babka > > Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> > > Reviewed-by: Vlastimil Babka Thanks! -- Thanks, Hyeonggon