From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4729CC32772 for ; Tue, 23 Aug 2022 22:05:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 39012940008; Tue, 23 Aug 2022 18:04:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 317CF940007; Tue, 23 Aug 2022 18:04:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 191D0940008; Tue, 23 Aug 2022 18:04:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 03DEF940007 for ; Tue, 23 Aug 2022 18:04:59 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id CD3D9C1804 for ; Tue, 23 Aug 2022 22:04:58 +0000 (UTC) X-FDA: 79832238276.08.E6F8061 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 02EF61C0032 for ; Tue, 23 Aug 2022 22:04:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661292296; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=R2o9KL5zJfRlNaW0ivmyyVUxydW3mUT+lo+e3IQKKzo=; b=bXjY/IgaF5Bd6N+IuhNdpcLfnNL29Rz0cNj7UJr0JkjKs8b4NDaDQKDYqIcYpAsnJhI7lV iK+IWIVp4dlzLzIOJO57zG/GMVkVMA5E9PnAHsH+RdrFKcW6LqiZmzp6l8/ziuyE8VgU5A 06n7SDGzSBR1Ku9FM1bd+QLLcPgMvXc= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-55-O8ZCEj8HPZuXJQF7nJq_ZA-1; Tue, 23 Aug 2022 18:04:53 -0400 X-MC-Unique: O8ZCEj8HPZuXJQF7nJq_ZA-1 Received: by mail-qv1-f71.google.com with SMTP id c10-20020a0ce64a000000b00496b34088f3so8374087qvn.15 for ; Tue, 23 Aug 2022 15:04:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=R2o9KL5zJfRlNaW0ivmyyVUxydW3mUT+lo+e3IQKKzo=; b=1bK3HAqyXX/ljQGKtG1LZi1uGeec9Zxhhd+bGZccaYHHWCAbXNpWTc7L899Y4ZW+HW 9KkCAOq1vJdGBB1YjCqT2peuoNr62pko+9kpreSI4lGzynZ8fD6suPJml8Fu1iGWTHeW ASKMgp9NYasfMrLU9OA9lnupw9+yxYALK79jiUf8bjfQw/6EqoK8kKDPiSQpYgKS2cM4 3O0AuK1ediHQm8maEI3dA7yELoqgJQcy60Ugx4leE+8O9sC8jtQv1MRkZECFhHIdqqgG J7Uyol2TLNKwbY0c48ey/W0+95g8gbgbjFJq8so/8+kJP/pZQEDmauTCbScm4hcD7w8P lXMw== X-Gm-Message-State: ACgBeo2xuQNzzaxAwPQFXdFYijBpwjJkqV5un6HFyAmwccwYCRtrPG17 ZDfynMn63TtOicvaMl+ld70VgOxnveqiNu4oQacx6C7NdxWmpdS4ZrGuURY6k+QE/fv8IQEm8E3 NVyY9biBUlQE= X-Received: by 2002:ac8:5bcd:0:b0:343:7d45:ee05 with SMTP id b13-20020ac85bcd000000b003437d45ee05mr21566036qtb.653.1661292292946; Tue, 23 Aug 2022 15:04:52 -0700 (PDT) X-Google-Smtp-Source: AA6agR4EUSU9wZacJpr3l6kWOwcXBazf6jqi3Mt/oSu6SfGvNLvUWP2Cr6dhy4eV3Vp7pKAzN+m6vw== X-Received: by 2002:ac8:5bcd:0:b0:343:7d45:ee05 with SMTP id b13-20020ac85bcd000000b003437d45ee05mr21566000qtb.653.1661292292702; Tue, 23 Aug 2022 15:04:52 -0700 (PDT) Received: from xz-m1.local (bras-base-aurron9127w-grc-35-70-27-3-10.dsl.bell.ca. [70.27.3.10]) by smtp.gmail.com with ESMTPSA id s21-20020ac85295000000b00343028a9425sm11334798qtn.16.2022.08.23.15.04.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Aug 2022 15:04:52 -0700 (PDT) Date: Tue, 23 Aug 2022 18:04:50 -0400 From: Peter Xu To: Yu Zhao Cc: Andrew Morton , "Huang, Ying" , Linux-MM , linux-kernel , Hugh Dickins , "Kirill A . Shutemov" , Alistair Popple , Andrea Arcangeli , Minchan Kim , David Hildenbrand , Andi Kleen , Nadav Amit , Vlastimil Babka Subject: Re: [PATCH v4 3/7] mm/swap: Add swp_offset_pfn() to fetch PFN from swap entry Message-ID: References: <20220811161331.37055-1-peterx@redhat.com> <20220811161331.37055-4-peterx@redhat.com> <87lerudwcb.fsf@yhuang6-desk2.ccr.corp.intel.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661292297; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=R2o9KL5zJfRlNaW0ivmyyVUxydW3mUT+lo+e3IQKKzo=; b=BOQex3ZYgFvAxsB2gEPNC1aZ0buBiU3CMHuE12j/IZwgQ0Ycag+dNWnlk5lXyFuQukj8dY Pz/CD1VAddcuq51ntRssD8aDcdInV0gC2GyrbWtAAkn0EOwMv2pS9QSoHWo+nQlwRJ33Wi kWwLNF8Km9F4lAqGUwV7mpdLvE5eE+E= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="bXjY/Iga"; spf=pass (imf21.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661292297; a=rsa-sha256; cv=none; b=fjiD5KLUMSRWI1j9MVhQvMvgL8IWYK00DMYtNWRDXjAklt0JBxAG/vAAGbrCX2a6/9caf4 yvjJ6T05i6HTgmS0akYzcM8W0ApUm9rilg1qDeiATJy02l7NK8tOYBcoMpilDfBNYKpGS+ T4CuYpIrsZgRmAq7YomD4nm9wppFTcE= X-Rspam-User: Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="bXjY/Iga"; spf=pass (imf21.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 02EF61C0032 X-Stat-Signature: k44u61gr4cfc4kstwzgw8qriqw9edfi6 X-HE-Tag: 1661292296-170284 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 23, 2022 at 03:01:09PM -0600, Yu Zhao wrote: > On Thu, Aug 11, 2022 at 8:33 PM Huang, Ying wrote: > > > > Peter Xu writes: > > > > > We've got a bunch of special swap entries that stores PFN inside the swap > > > offset fields. To fetch the PFN, normally the user just calls swp_offset() > > > assuming that'll be the PFN. > > > > > > Add a helper swp_offset_pfn() to fetch the PFN instead, fetching only the > > > max possible length of a PFN on the host, meanwhile doing proper check with > > > MAX_PHYSMEM_BITS to make sure the swap offsets can actually store the PFNs > > > properly always using the BUILD_BUG_ON() in is_pfn_swap_entry(). > > > > > > One reason to do so is we never tried to sanitize whether swap offset can > > > really fit for storing PFN. At the meantime, this patch also prepares us > > > with the future possibility to store more information inside the swp offset > > > field, so assuming "swp_offset(entry)" to be the PFN will not stand any > > > more very soon. > > > > > > Replace many of the swp_offset() callers to use swp_offset_pfn() where > > > proper. Note that many of the existing users are not candidates for the > > > replacement, e.g.: > > > > > > (1) When the swap entry is not a pfn swap entry at all, or, > > > (2) when we wanna keep the whole swp_offset but only change the swp type. > > > > > > For the latter, it can happen when fork() triggered on a write-migration > > > swap entry pte, we may want to only change the migration type from > > > write->read but keep the rest, so it's not "fetching PFN" but "changing > > > swap type only". They're left aside so that when there're more information > > > within the swp offset they'll be carried over naturally in those cases. > > > > > > Since at it, dropping hwpoison_entry_to_pfn() because that's exactly what > > > the new swp_offset_pfn() is about. > > > > > > Signed-off-by: Peter Xu > > > > LGTM, Thanks! > > > > Reviewed-by: "Huang, Ying" > > Hi, > > I hit the following crash on mm-everything-2022-08-22-22-59. Please take a look. > > Thanks. > > kernel BUG at include/linux/swapops.h:117! > CPU: 46 PID: 5245 Comm: EventManager_De Tainted: G S O L > 6.0.0-dbg-DEV #2 > RIP: 0010:pfn_swap_entry_to_page+0x72/0xf0 > Code: c6 48 8b 36 48 83 fe ff 74 53 48 01 d1 48 83 c1 08 48 8b 09 f6 > c1 01 75 7b 66 90 48 89 c1 48 8b 09 f6 c1 01 74 74 5d c3 eb 9e <0f> 0b > 48 ba ff ff ff ff 03 00 00 00 eb ae a9 ff 0f 00 00 75 13 48 > RSP: 0018:ffffa59e73fabb80 EFLAGS: 00010282 > RAX: 00000000ffffffe8 RBX: 0c00000000000000 RCX: ffffcd5440000000 > RDX: 1ffffffffff7a80a RSI: 0000000000000000 RDI: 0c0000000000042b > RBP: ffffa59e73fabb80 R08: ffff9965ca6e8bb8 R09: 0000000000000000 > R10: ffffffffa5a2f62d R11: 0000030b372e9fff R12: ffff997b79db5738 > R13: 000000000000042b R14: 0c0000000000042b R15: 1ffffffffff7a80a > FS: 00007f549d1bb700(0000) GS:ffff99d3cf680000(0000) knlGS:0000000000000000 > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > CR2: 0000440d035b3180 CR3: 0000002243176004 CR4: 00000000003706e0 > DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > Call Trace: > > change_pte_range+0x36e/0x880 > change_p4d_range+0x2e8/0x670 > change_protection_range+0x14e/0x2c0 > mprotect_fixup+0x1ee/0x330 > do_mprotect_pkey+0x34c/0x440 > __x64_sys_mprotect+0x1d/0x30 The VM_BUG_ON added in this patch seems to have revealed a real bug, because we probably shouldn't call pfn_swap_entry_to_page() upon e.g. a genuine swap pte. I'll post a patch shortly, thanks. -- Peter Xu