From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A63BC28D13 for ; Tue, 23 Aug 2022 01:13:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A1DC48D0002; Mon, 22 Aug 2022 21:13:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9CE228D0001; Mon, 22 Aug 2022 21:13:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 896268D0002; Mon, 22 Aug 2022 21:13:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7B8978D0001 for ; Mon, 22 Aug 2022 21:13:24 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 4DEB11A0A30 for ; Tue, 23 Aug 2022 01:13:24 +0000 (UTC) X-FDA: 79829084328.25.A99F18D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf17.hostedemail.com (Postfix) with ESMTP id 0DBFF40004 for ; Tue, 23 Aug 2022 01:13:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661217201; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yfh06TyG5c34D7x1kaHxF6+hr4mEnE7ZvWBsUHmo9JM=; b=En5V0LvoWKag493UQcTTYPxn6jKGXQv+R246OITink9xk6zGq6Y/87+3T5no7+HYbzIksY 8vzXfrMvKbBtaQEMET5MP71k61UeTqQLsex9B635vP6igr2KIzXnGMu0Zs7ph0ECX1FztX vj+tG8OSmojSlEvkfUJ885kAffFOsws= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-202-q_SzlhyIMgiW9KpYE3iyUA-1; Mon, 22 Aug 2022 21:13:17 -0400 X-MC-Unique: q_SzlhyIMgiW9KpYE3iyUA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 47F38811E75; Tue, 23 Aug 2022 01:13:17 +0000 (UTC) Received: from localhost (ovpn-12-31.pek2.redhat.com [10.72.12.31]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 978112026D4C; Tue, 23 Aug 2022 01:13:16 +0000 (UTC) Date: Tue, 23 Aug 2022 09:13:13 +0800 From: Baoquan He To: Christoph Hellwig Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, agordeev@linux.ibm.com, wangkefeng.wang@huawei.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 02/11] mm: ioremap: fixup the physical address and page prot Message-ID: References: <20220820003125.353570-1-bhe@redhat.com> <20220820003125.353570-3-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661217203; a=rsa-sha256; cv=none; b=DM/Z3U1dvAyaHOMPeV+du828rfzWaBRvpTWuR+C2EiD19H1TzLJGqUHeJ8uhZybbNMie6F 20G8cL/1nBAkf0GPECmEUm8XwVSkM9IPE+6JYT1W7ttDQr9TXmjGvAuZNujQaH577V+dwC +3N50Q8K7pGHYDbRRkm0vLqj3X8wiMc= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=En5V0Lvo; spf=pass (imf17.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661217203; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yfh06TyG5c34D7x1kaHxF6+hr4mEnE7ZvWBsUHmo9JM=; b=xePni4LC5LX9pMHPr7Uhd1almiDkiMRAfnxDGB55a2+DwGArIw2pTVTE610HHLuYaQfbUX cwMz069R9f6kEuxjJt8qMJzwTmFz/jLClEJagYuLcEB1XJnyZGYd1uWPc+SiasCv73N1RV WYTUuMWTfydn7y7WiKc/WpLuQLBx34E= X-Stat-Signature: w8kuqu1sn356hpkjosm564wweua5bng4 X-Rspamd-Queue-Id: 0DBFF40004 X-Rspamd-Server: rspam11 X-Rspam-User: Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=En5V0Lvo; spf=pass (imf17.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-HE-Tag: 1661217201-528404 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 08/20/22 at 11:54pm, Christoph Hellwig wrote: > > -void __iomem *arch_ioremap(phys_addr_t phys_addr, size_t size, unsigned long prot); > > +void __iomem * > > +arch_ioremap(phys_addr_t *paddr, size_t size, unsigned long *prot_val); > > It seems a bit odd to do this in two steps vs just doing the entire > change in the first patch. Any good reason for that? I will merge patch 1~2 or 1~3 into patch 1. Earlier, I wrote the reason as below paragraph in cover letter of v1 post. Now it seems not so hard to tell and understand. ==== For patch 1~3, I don't merge them because I made them in different rounds of changing. And splitting them makes me easily describe the intention and make review easier. I can merge them after v1 reviewing if anyone thinks they should be merged. ====