From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FB67C28D13 for ; Mon, 22 Aug 2022 16:36:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 785708D0003; Mon, 22 Aug 2022 12:36:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 734BA8D0001; Mon, 22 Aug 2022 12:36:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5D7638D0003; Mon, 22 Aug 2022 12:36:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5085E8D0001 for ; Mon, 22 Aug 2022 12:36:37 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 23383C115A for ; Mon, 22 Aug 2022 16:36:37 +0000 (UTC) X-FDA: 79827782034.02.BDB456E Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf25.hostedemail.com (Postfix) with ESMTP id A81E1A0347 for ; Mon, 22 Aug 2022 16:35:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=domgJmoasu517o7hiFT4zNTeyrBIkqaCSkQfvyZKNLU=; b=Tw6p8M7RyStV6wNAy4O/dgD1py vI8mWyvL8CibdIqBsMEyXMNElgEzEZzixMUTD1yqPToWVT4My1huMvirgeF4lJUU5e/ZYxIxjGSY0 GY6xPkvT9xuSeg8W5uVzCTaadKsGTBBjILbTTk/LauSnfKVHgnmyNAiYQJn6iWdHI/iQ7LHyq9rzH JpHZsX94o3vxhZqy4sBuGG29P/OBozfvajJYze24by72NxUj9h0TZaZodcHTXjeNqYrDPCZpoqK/k 0VcjMjhK5v10GI0aiBeGHcbp1nnQBO8er4IClskwoSrLFzWx7fzKY+aSGHeUyEQ0v887I1c5MdEcw BI9FOegg==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=worktop.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQAO7-00EShX-Qn; Mon, 22 Aug 2022 16:34:55 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id DDD109804A3; Mon, 22 Aug 2022 18:34:53 +0200 (CEST) Date: Mon, 22 Aug 2022 18:34:53 +0200 From: Peter Zijlstra To: Song Liu Cc: Linux-MM , lkml , Andrew Morton , X86 ML , Christoph Hellwig , Kernel Team , "Edgecombe, Rick P" , Luis Chamberlain , Dave Hansen , Song Liu Subject: Re: [RFC 0/5] vmalloc_exec for modules and BPF programs Message-ID: References: <20220818224218.2399791-1-song@kernel.org> <4D089469-B32B-4347-A811-B1E5EE011307@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4D089469-B32B-4347-A811-B1E5EE011307@fb.com> ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Tw6p8M7R; spf=none (imf25.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661186114; a=rsa-sha256; cv=none; b=YuRTMMYU1WSqnD3eVertrzLjIuOeN5hB4WMJF0tjYfhxK3aqaCKuvWrYGTQc1m5LKKhNOt 2it3OSUPnYJrLuYkgjtWD0H/3s9Sac7UAAljjvWmEbenHKXNXpyI3QMIxnXutIZC4QsFR9 ka2EaDF0FfRFh9FxoKTxHgretznsU2I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661186114; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=domgJmoasu517o7hiFT4zNTeyrBIkqaCSkQfvyZKNLU=; b=irHBFqYrZkNuBdFxLyN+gM/ickAOBsja2S+ADzo7zXOHMxqxMed2/x4/dD1/9Cyzi6TAD7 89Fj9pnGXz/pjdw49sd/mlTVi3BuVsX4LH3Ma963PxF3LiyWhehB2V84LCBmjFtnZq7K2/ Pb5rXrzhipt9VXsu2BWdzjwLu+V0B3o= Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Tw6p8M7R; spf=none (imf25.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none X-Stat-Signature: 51hx1fyy8em4km1q8sq4bizy7pfoatzd X-Rspamd-Queue-Id: A81E1A0347 X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1661186113-872704 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 22, 2022 at 03:46:38PM +0000, Song Liu wrote: > Could you please share your feedback on this? I've looked at it all of 5 minutes, so perhaps I've missed something. However, I'm a little surprised you went with a second tree instead of doing the top-down thing for data. The way you did it makes it hard to have guard pages between text and data.