From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62322C00140 for ; Sun, 21 Aug 2022 06:57:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E59726B0073; Sun, 21 Aug 2022 02:57:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DE2D06B0074; Sun, 21 Aug 2022 02:57:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C855F8D0001; Sun, 21 Aug 2022 02:57:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B9E5E6B0073 for ; Sun, 21 Aug 2022 02:57:38 -0400 (EDT) Received: from smtpin31.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 94F04AC410 for ; Sun, 21 Aug 2022 06:57:38 +0000 (UTC) X-FDA: 79822694196.31.2BD5979 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf05.hostedemail.com (Postfix) with ESMTP id 60B80100029 for ; Sun, 21 Aug 2022 06:57:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=tbA8GPJvpZPjyT8xHzEYgyx5w9Okhk3popffrDAY7oI=; b=YQLHw+2HeEkLn1TFXnAvnkNWuQ CMyJ6wld0ZyFCBh86KeBcBe+lLp2TWnlT6BiMubAZLJ0ABQA26Nhcz7LIp4ysQytdifnmFp/uPWab majGosilWVAwMpzMrnkoxMRXSsB1DVftzKSWOvBM/sna7VtHeYFEGArhRaH/wJyqe0nMdgy0L0Ha6 QtYT1Xby+15OePctot8MDtVp27E8nBpwmzewLKX6qX2Yz2Aadsae2jvS+LFIsaFbdRkntWv6B4g0Y ouqQQjGQb4h7XHQHzTsUbVEvMjB0sdNSsziNUhkgiYus8hjbVwXhS9jOvm5AH0kqlhBikY4I458hD 0K1JB16A==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oPetl-0071xF-ID; Sun, 21 Aug 2022 06:57:30 +0000 Date: Sat, 20 Aug 2022 23:57:29 -0700 From: Christoph Hellwig To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, hch@infradead.org, agordeev@linux.ibm.com, wangkefeng.wang@huawei.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 03/11] mm: ioremap: allow ARCH to have its own ioremap definition Message-ID: References: <20220820003125.353570-1-bhe@redhat.com> <20220820003125.353570-4-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220820003125.353570-4-bhe@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661065058; a=rsa-sha256; cv=none; b=6aEAmx6uGRlZNlShmWDhOz7dkKS+bz2cTgTSScrlzmmL/4T/ypERe8Cz4JzLzxoB3QeHQh OVXLmyCqf3hN1fHHhJtatSn9X1KRWM6U3+ngQ1q7HcfVKJzeTCoKkIwo0fZGY3LZSygvdH uswbKXeprfaLoQt7NRzQLD4y6YIKXds= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=YQLHw+2H; dmarc=none; spf=none (imf05.hostedemail.com: domain of BATV+a2efb402714a86af2474+6937+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+a2efb402714a86af2474+6937+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661065058; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tbA8GPJvpZPjyT8xHzEYgyx5w9Okhk3popffrDAY7oI=; b=b6wzA6LcTQMdwXP3naojbt8XawTZ6O7BlmF86DpTlQQwaI8BMjYvbi9GLppLfCQ30eqPt/ xmLdEADOkbQHnt8VG/FnZ60TRiWs/Lga049VPqFoGwcbKouJxJnytSVBQ/ZSq7A3G6Si3d ZDWNFWAsKiV2iKFsA6wWWXMGjVGBaiw= X-Rspamd-Queue-Id: 60B80100029 X-Stat-Signature: zrf9ufdjije67mrmfkx6ene8h7u7is4d Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=YQLHw+2H; dmarc=none; spf=none (imf05.hostedemail.com: domain of BATV+a2efb402714a86af2474+6937+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+a2efb402714a86af2474+6937+infradead.org+hch@bombadil.srs.infradead.org X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1661065058-926172 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Aug 20, 2022 at 08:31:17AM +0800, Baoquan He wrote: > Architectures like xtensa, arc, can be converted to GENERIC_IOREMAP, > to take standard ioremap_prot() and ioremap_xxx() way. But they have > ARCH specific handling for ioremap() method, than standard ioremap() > method. Do they? For arc, the arc_uncached_addr_space case can be easily handled by arch_ioremap, and the xtensa case looks very similar to that. I'd really like to kill off arch definitions of ioremap going forward, as they should just be a special case of ioremap_prot by definition.