From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4AB8C28D13 for ; Fri, 19 Aug 2022 22:46:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 58EE26B0073; Fri, 19 Aug 2022 18:46:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 53E296B0074; Fri, 19 Aug 2022 18:46:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 406DB6B0075; Fri, 19 Aug 2022 18:46:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 302E66B0073 for ; Fri, 19 Aug 2022 18:46:27 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 0B5361C7642 for ; Fri, 19 Aug 2022 22:46:27 +0000 (UTC) X-FDA: 79817827614.06.649F0A9 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf26.hostedemail.com (Postfix) with ESMTP id C897D1400D0 for ; Fri, 19 Aug 2022 22:36:35 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B0524B82922; Fri, 19 Aug 2022 22:36:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4E384C433C1; Fri, 19 Aug 2022 22:36:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660948593; bh=kpK5eC8bTRHQNDpZySZTMewfQlwFe4s77+Dm8dzizJM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SCx44mu5hKk00BK3uwf0FoDeHM87V/ahSAmRx8/yzU1OJqF6KaYGyfA9CGMseZzse 5VPOUzUXq+kXd5uQWOEyYS8BJn6oaiQkWgPpKIKx4qCukbSHj2qZmkcTRoIiMxwX11 yN0ycIWRBR/jnZOii6Sh+DVfp2Stsr597R9GIXbFZxCpxyiDGgimVV28rRG6kt2rFR DJGyv/3EqF3HVe5g0D8aciApXQvCNClUB/uYuQYMTdv6RIrfBO0VG3n4CDIJvLi8B0 kKpULZTFTzv8I4rdVSQ268mlV121+/PXTjKKSs3vr3PuATdDsmvUJFmVKHKEqFhilP X3fwG42pnMZhA== Date: Fri, 19 Aug 2022 15:36:31 -0700 From: Eric Biggers To: "Fabio M. De Francesco" Cc: linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] f2fs: use memcpy_{to,from}_page() where possible Message-ID: References: <20220818225450.84090-1-ebiggers@kernel.org> <4743896.GXAFRqVoOG@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4743896.GXAFRqVoOG@localhost.localdomain> ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=SCx44mu5; spf=pass (imf26.hostedemail.com: domain of ebiggers@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=ebiggers@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660948595; a=rsa-sha256; cv=none; b=Jjeiom2DycixwVqWsktFQ8fHlv0AeVf9pttojaLOYLmoCbUcSW7Nny8JvJzmBCVVM34C7E C0lw3+plIkgSdCtsspcE3aVs5FPd+MVWi/SPm/IP9/9UVZ3vXHXLRHTs87+QRVk60pniWj jVpKtaGLdGzdtsXJ3/J1/sPHCug02gI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660948595; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dxVRtig+EM4NPYxfPnemijrkgg65AT6bDiPOUJMwc9w=; b=P3LO067qLD4azEp3zcpBZNEq2HQoP4roFBu1HqDOXZBDCpy9nR6hC1iMhX9W2bZmcSBY5P r+cwAoT9QKmLo1Iteuz0Q1hqCZHSDfoBDze/s+L7dm8CmgZCSJXk395xK+3MTfggIrcgJd VwI6eSc8hnMg+2uDIaqU4xxbRWND/ME= X-Rspam-User: Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=SCx44mu5; spf=pass (imf26.hostedemail.com: domain of ebiggers@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=ebiggers@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspamd-Server: rspam02 X-Stat-Signature: xff1w8n7tqszyg7drte1bbxifmf1dxbq X-Rspamd-Queue-Id: C897D1400D0 X-HE-Tag: 1660948595-116551 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Aug 19, 2022 at 01:11:41PM +0200, Fabio M. De Francesco wrote: > > - src_addr = inline_data_addr(inode, ipage); > > - dst_addr = kmap_atomic(page); > > - memcpy(dst_addr, src_addr, MAX_INLINE_DATA(inode)); > > + memcpy_to_page(page, 0, inline_data_addr(inode, ipage), > > + MAX_INLINE_DATA(inode)); > > flush_dcache_page(page); > > flush_dcache_page() is redundant here. memcpy_to_page() takes care to call it. Done in v2. > > - kaddr = kmap_atomic(page); > > - memcpy(kaddr + offset, data, tocopy); > > - kunmap_atomic(kaddr); > > + memcpy_to_page(page, offset, data, tocopy); > > flush_dcache_page(page); > > Same here. Likewise. > > It looks like you forgot a conversion from kmap_atomic() in fs/f2fs/inline.c > at line 266. Also done in v2. I think I had skipped that one intentionally, but I must not have looked closely because it converts just fine. Thanks! - Eric