From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E682FC0502A for ; Wed, 31 Aug 2022 14:04:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 257AC8D0002; Wed, 31 Aug 2022 10:04:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 206BB8D0001; Wed, 31 Aug 2022 10:04:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0CF348D0002; Wed, 31 Aug 2022 10:04:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id ED9C28D0001 for ; Wed, 31 Aug 2022 10:04:51 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B39161604A2 for ; Wed, 31 Aug 2022 14:04:51 +0000 (UTC) X-FDA: 79860058782.05.F551D85 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by imf25.hostedemail.com (Postfix) with ESMTP id 69211A0052 for ; Wed, 31 Aug 2022 14:04:50 +0000 (UTC) Received: by mail-pj1-f51.google.com with SMTP id j9-20020a17090a3e0900b001fd9568b117so11453324pjc.3 for ; Wed, 31 Aug 2022 07:04:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=JRpljp0WIXjTAmjOkCvSfavCaZCHOKd5qHM7dwF9nGg=; b=R7AXl+wh7Gz11j9C+AihtwiFo9WJNMhuMOaHeGW/raY1qIY4uS9u+Hbu8Sh8uSZnGJ bleHFikT78poIC7GkaGyhZ1/8t3jD/OzYykF0M6uU+PEm0y2gj9svLJuC9Y4Z82nxAzH Cp1rVjWbLmR/dvdm0GAwXitejVyQSUrZMf5mosXh4bYDEPdEM4tVQXbgcmjkNfpzbQUF dgXGUKd8EI7LqU7Xz/xHP7ioTOKo7oELQdAn4Uuz6bbliODEH1wyNuZcSXlmwsvuYwrU LwBfVmxVdnAmgfsfK16GMusgQFCWqgWEHtVDKsf+pdohgWXDdnZEbJIZaLXItwl8nJBU Nuwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=JRpljp0WIXjTAmjOkCvSfavCaZCHOKd5qHM7dwF9nGg=; b=xmQ5rN9GE6wz9QCiQT9UveYUQL+lr3es73xVnNqVfQGJVcdVjQkkoS7W3nw2nkAWAa Uci2dNeXYcrZLive2squSVhKOuKXVD0wRQOiEnGmAgX4bqwLYqV6aW8HgmxP/23CfstX TartXUUf73LcB2vUXt4SZUimYLsk+k5hAm45wxKwX5jxNcjJmXBnsAHFQqZVEx0jDqZt A8ZkQX7OB2N5lO7WzotpyM8MmFkGLyXZyB+8l6ZLvA61BHok5pkJV5GyzW5Gm9XdYhHu NZGLPDHkLHeoSdHKxoOWRFqGp37My4Lh9x8bW7U2WOdwzYSXURLHw7YTztSA1Zgum3Uz AUvQ== X-Gm-Message-State: ACgBeo3H6ULEbfWiLCvNgXR2EG0zhpCs4JeOJ+1B533oOnb1ouOY0+Gy oMzaQUTtZozaJr6qQsNjZc8= X-Google-Smtp-Source: AA6agR5GDuJLy9unXZoFgaCuJagFQ/NKLBaIQSRKRRUfDngfEVBNrIFiVD7axTV+u0pF+xpzIn7YFw== X-Received: by 2002:a17:90b:1b12:b0:1fe:b98:2c42 with SMTP id nu18-20020a17090b1b1200b001fe0b982c42mr3481015pjb.184.1661954689297; Wed, 31 Aug 2022 07:04:49 -0700 (PDT) Received: from hyeyoo ([114.29.91.56]) by smtp.gmail.com with ESMTPSA id w18-20020a1709027b9200b001728ac8af94sm11556321pll.248.2022.08.31.07.04.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Aug 2022 07:04:47 -0700 (PDT) Date: Wed, 31 Aug 2022 23:04:41 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Feng Tang Cc: Andrew Morton , Alexander Potapenko , Marco Elver , Dmitry Vyukov , Vlastimil Babka , kasan-dev@googlegroups.com, linux-mm@kvack.org Subject: Re: [PATCH -next] mm: kence: add __kmem_cache_free to function skip list Message-ID: References: <20220831073051.3032-1-feng.tang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220831073051.3032-1-feng.tang@intel.com> ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=R7AXl+wh; spf=pass (imf25.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.216.51 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661954690; a=rsa-sha256; cv=none; b=JZWNT2PBsY4aRcFeAfQxIhj+aWCbpRJ6e6YxfA5eXbDhecPiEqvA+/qs44yAZoxTJcY9+4 plGZ8xSCDYryUv3DzjEUwv4fdaQg2VdZzk0kh7vM0RU2KX8mnsD/RB2KeLPMLfTPTOhUXk ej0vFSes6D5BSVr037D14DLWo5bN1cE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661954690; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JRpljp0WIXjTAmjOkCvSfavCaZCHOKd5qHM7dwF9nGg=; b=LoHehWS9idKR0CET+GS922lYb3/EXV2PtwwYe73pB+4Lt6J5sCrFdqnyblamqg4cIBo1G2 MSxuY6dS8Aee17PfA5pNi5U0ANp6/FNBZqkHsb5yu6KhJ5f+7xUDjLU3rdRoQcEp2WXDdW VJGTHhFUKDwjWpJCQVu6wPSo+RuvKhA= X-Stat-Signature: fohi75c6tie6kfsi95kzdjsy9rp938qi X-Rspamd-Queue-Id: 69211A0052 Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=R7AXl+wh; spf=pass (imf25.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.216.51 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1661954690-480603 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 31, 2022 at 03:30:51PM +0800, Feng Tang wrote: > When testing the linux-next kernel, kfence's kunit test reported some > errors: > > [ 12.812412] not ok 7 - test_double_free > [ 13.011968] not ok 9 - test_invalid_addr_free > [ 13.438947] not ok 11 - test_corruption > [ 18.635647] not ok 18 - test_kmalloc_aligned_oob_write > > Further check shows there is the "common kmalloc" patchset from > Hyeonggon Yoo, which cleanup the kmalloc code and make a better > sharing of slab/slub. There is some function name change around it, > which was not recognized by current kfence function name handling > code, and interpreted as error. > > Add new function name "__kmem_cache_free" to make it known to kfence. > > Signed-off-by: Feng Tang > --- > mm/kfence/report.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/kfence/report.c b/mm/kfence/report.c > index f5a6d8ba3e21..7e496856c2eb 100644 > --- a/mm/kfence/report.c > +++ b/mm/kfence/report.c > @@ -86,6 +86,7 @@ static int get_stack_skipnr(const unsigned long stack_entries[], int num_entries > /* Also the *_bulk() variants by only checking prefixes. */ > if (str_has_prefix(buf, ARCH_FUNC_PREFIX "kfree") || > str_has_prefix(buf, ARCH_FUNC_PREFIX "kmem_cache_free") || > + str_has_prefix(buf, ARCH_FUNC_PREFIX "__kmem_cache_free") || > str_has_prefix(buf, ARCH_FUNC_PREFIX "__kmalloc") || > str_has_prefix(buf, ARCH_FUNC_PREFIX "kmem_cache_alloc")) > goto found; > -- > 2.27.0 > Thank you for catching this! Unfortunately not reproducible on my environment with linux-next (IDK why). Maybe you can include those functions too? - __kmem_cache_alloc_node - kmalloc_[node_]trace, kmalloc_large[_node] -- Thanks, Hyeonggon