From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06C0AECAAD5 for ; Wed, 31 Aug 2022 13:33:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6922F6B0071; Wed, 31 Aug 2022 09:33:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6419A8D0003; Wed, 31 Aug 2022 09:33:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 509948D0002; Wed, 31 Aug 2022 09:33:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 40F936B0071 for ; Wed, 31 Aug 2022 09:33:56 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 168A914041D for ; Wed, 31 Aug 2022 13:33:56 +0000 (UTC) X-FDA: 79859980872.14.D630557 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) by imf09.hostedemail.com (Postfix) with ESMTP id C025B140053 for ; Wed, 31 Aug 2022 13:33:55 +0000 (UTC) Received: by mail-pg1-f179.google.com with SMTP id 202so13523735pgc.8 for ; Wed, 31 Aug 2022 06:33:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=1PE3GKnhwOhRif7fn1enjVH8DVXVUvhYKrLN724969I=; b=BDicR5TJvL5oR2CfoULAhbPtsjdaQUo8LupEgctXNvDRwIdsaxZVxk3GBI3Erzm4vk aCYL0FK9UAa4d751uPbhSGOVQLb0E5V+/9+zN2P+pfgn58Te4w2jJ+geGwfNLM8wQYt1 ruQNla7c/YWtBBlAJ8wxKBaBOsNNDhvAFLM2wkK1VEnF7sqNw4dwUyun7xT11TmgwUp9 rE+/GTAen/+frXJ3pcZ8s8nWEZZiu1fgC49WIdMaW+rwKMCqe19QG+uaJvutr2PnTaxH C9cbKyr3IhIae0cxmQLNUUt1HhQvdiha6n8HF5vaUf7hJGsEATD/PErOya2PB4zTlQdC iPeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=1PE3GKnhwOhRif7fn1enjVH8DVXVUvhYKrLN724969I=; b=mBL8/EruCoSra5hwxoJIgt+zfPBwTjzQRPA2Z91PnKxbsZpvzca8276gvZc1oMoD7V KQ+Hu2osmnp8L2QqXDAQoTnH47FAq9PBcRNh1Fxgw1alHgeZFFvIZuPLKTm5L/Pq+AYM PVJ6vEDuP73E/Sopj0lxmex+nxmd3bFn4p1O1p3czVSyGBtY2h6dNMyXl9Zy7obWYQ+t EFZgQ6Hx+CdiOko+qGyrw2/aUQuRNPQEozwJHSYmUjOFbbRIlcNCsAcLWES7Rv/jCA6/ UnC2NQQa7nd+tEho0OijTMMaXj85epBXCbpwL9F6Otm+Lj8OQ2nldmC1Ha/CgYtYRwpH b8xA== X-Gm-Message-State: ACgBeo07/vz4VZg0r/m0dW/VMXesLjrDtfqQMm6QPm7cOhZhq/LDjD2h 5MJTZ+3LU4O2Kk7+PsPjGbo= X-Google-Smtp-Source: AA6agR6KmyTMobUbdXA3xUzSjKLI551KM+BCVV/L16aTZhKH4J0yQhveyLp/PO5lreFFBmR8UrBsdA== X-Received: by 2002:a65:6d93:0:b0:42c:50ec:8025 with SMTP id bc19-20020a656d93000000b0042c50ec8025mr9689713pgb.62.1661952834522; Wed, 31 Aug 2022 06:33:54 -0700 (PDT) Received: from hyeyoo ([114.29.91.56]) by smtp.gmail.com with ESMTPSA id pj7-20020a17090b4f4700b001fb277223bdsm1306189pjb.2.2022.08.31.06.33.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Aug 2022 06:33:53 -0700 (PDT) Date: Wed, 31 Aug 2022 22:33:48 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Chao Yu Cc: linux-mm@kvack.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, jaegeuk@kernel.org, Chao Yu , stable@kernel.org, syzbot+81684812ea68216e08c5@syzkaller.appspotmail.com Subject: Re: [PATCH] mm/slub: fix to return errno if kmalloc() fails Message-ID: References: <20220830141009.150075-1-chao@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220830141009.150075-1-chao@kernel.org> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661952835; a=rsa-sha256; cv=none; b=bAtGmiyM7tPi8/rjISQgQajuVfrKAPKSb0k8LqRjtxz85sLTsoCXQRFRA6W00CX55RBgTs vmkx37zKnxEvufnMEaHo+wRwiJAbfGgQTPgEa4S93sCN6xU91XTIj/Hp3Pzmu9lw9bG7L4 cyxGYsbj/xLf9bZs0QYK4tjOPMvgQVM= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=BDicR5TJ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf09.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.215.179 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661952835; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1PE3GKnhwOhRif7fn1enjVH8DVXVUvhYKrLN724969I=; b=cHuy5X6WVhJUY+ViBLVAgzmGd2V1a8LjE+XbbQ/2tupIEDeB9VW3+XbZEGtRjynO58+dfb Kp+FSNmQCXHsOKLhCx5FXI/wYRX8nStfsges204FKrYV5bXdljJGUFHHQjUGWYXgACIJtP wzXzUCGEUh4cuIih6QXqhN0XOYAOTpk= Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=BDicR5TJ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf09.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.215.179 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com X-Rspam-User: X-Rspamd-Server: rspam12 X-Stat-Signature: wukkei3zmqe6sguxe5unj13ohse5ontt X-Rspamd-Queue-Id: C025B140053 X-HE-Tag: 1661952835-946306 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 30, 2022 at 10:10:09PM +0800, Chao Yu wrote: > From: Chao Yu > > In create_unique_id(), kmalloc(, GFP_KERNEL) can fail due to > out-of-memory, if it fails, return errno correctly rather than > triggering panic via BUG_ON(); > > kernel BUG at mm/slub.c:5893! > Internal error: Oops - BUG: 0 [#1] PREEMPT SMP > > Call trace: > sysfs_slab_add+0x258/0x260 mm/slub.c:5973 > __kmem_cache_create+0x60/0x118 mm/slub.c:4899 > create_cache mm/slab_common.c:229 [inline] > kmem_cache_create_usercopy+0x19c/0x31c mm/slab_common.c:335 > kmem_cache_create+0x1c/0x28 mm/slab_common.c:390 > f2fs_kmem_cache_create fs/f2fs/f2fs.h:2766 [inline] > f2fs_init_xattr_caches+0x78/0xb4 fs/f2fs/xattr.c:808 > f2fs_fill_super+0x1050/0x1e0c fs/f2fs/super.c:4149 > mount_bdev+0x1b8/0x210 fs/super.c:1400 > f2fs_mount+0x44/0x58 fs/f2fs/super.c:4512 > legacy_get_tree+0x30/0x74 fs/fs_context.c:610 > vfs_get_tree+0x40/0x140 fs/super.c:1530 > do_new_mount+0x1dc/0x4e4 fs/namespace.c:3040 > path_mount+0x358/0x914 fs/namespace.c:3370 > do_mount fs/namespace.c:3383 [inline] > __do_sys_mount fs/namespace.c:3591 [inline] > __se_sys_mount fs/namespace.c:3568 [inline] > __arm64_sys_mount+0x2f8/0x408 fs/namespace.c:3568 > > Cc: > Reported-by: syzbot+81684812ea68216e08c5@syzkaller.appspotmail.com Fixes: 81819f0fc8285 ("SLUB core") > Signed-off-by: Chao Yu > --- > mm/slub.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/mm/slub.c b/mm/slub.c > index 862dbd9af4f5..e6f3727b9ad2 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -5890,7 +5890,8 @@ static char *create_unique_id(struct kmem_cache *s) > char *name = kmalloc(ID_STR_LENGTH, GFP_KERNEL); > char *p = name; > > - BUG_ON(!name); > + if (!name) > + return ERR_PTR(-ENOMEM); > > *p++ = ':'; > /* > @@ -5948,6 +5949,8 @@ static int sysfs_slab_add(struct kmem_cache *s) > * for the symlinks. > */ > name = create_unique_id(s); > + if (IS_ERR(name)) > + return PTR_ERR(name); > } > > s->kobj.kset = kset; > -- > 2.25.1 > > Looks good to me. Reviewed-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> Thanks! -- Thanks, Hyeonggon