From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50D27ECAAD1 for ; Wed, 31 Aug 2022 14:52:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DDBC98D0002; Wed, 31 Aug 2022 10:52:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D8AEC8D0001; Wed, 31 Aug 2022 10:52:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C2B678D0002; Wed, 31 Aug 2022 10:52:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id AF83A8D0001 for ; Wed, 31 Aug 2022 10:52:25 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 554A51207B1 for ; Wed, 31 Aug 2022 14:52:25 +0000 (UTC) X-FDA: 79860178650.17.1C26D6C Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by imf20.hostedemail.com (Postfix) with ESMTP id D66E81C005B for ; Wed, 31 Aug 2022 14:52:24 +0000 (UTC) Received: by mail-pf1-f173.google.com with SMTP id 145so14294927pfw.4 for ; Wed, 31 Aug 2022 07:52:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=Gf8tbj4RpGeuppvSON/HSM0Glqk0yYviXDuhJFMb/GU=; b=cQxyBMvvozNYynus3zxZ3j6RzXSBCpn5FoAJ+nxKz3VHiS1lPZzxADwXlYRuG0lI3B iubXtay3v5e612hUHNMRi9pO3BoM7+V6nua4ccIirdwdAWV5GDmbXNB3aaP0GSgTpuWP nHW/4r7u39B3y081Hzdd0igqeAx9v0A/y+Tn0jf9CDsHJTsjTTvOjhaKnfYTW5kkLBrn KNgAj1LflkiZ/CvLjcjVtD6gnblQiNy2KksOanc3Da332hYVeyFKkr7EDZqsgSRqLj4T /auCOgZbeBvfyH8YPAadjtSdky6NohdNqcDfIs6cFywfY1K96K97eYQ7qGIxabWIC7/8 VmNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=Gf8tbj4RpGeuppvSON/HSM0Glqk0yYviXDuhJFMb/GU=; b=Sr645HfvXpmBzKqZ4RuNiXEJsj0I2JfSVxNuC9rgVafViqfVgzUdESJMJyoEDkKTAK 9774Ig0T8ZHIf0V2vfMTipxfRwi+DwGcgonQfFMcNKlJosfMuxfoW2csMCANNt0tQ43a nZWeul06jO6B/c1z6UsqniMjheVduHvsjJ6fLvkSzuYm7g+OfWOMcemGMaBn6wwJntpb nB7BNG2sq/NfUtV1gqpGoMe457EeChYRajRXjOuYdnputVIveeZgCcf+0uRtGbV0HH5K CECFsFeZXCF76cRbA50+u+rRwwLxr3HUbOqPQ0FRRNgfZA4eMNwv2m8Od7z7YLLsyoBv vYCQ== X-Gm-Message-State: ACgBeo3SOD7vtW62JFfqHWQ1QskE2E3T6OcD6hN2XhyvoxoYThWD+Vqx FdlthwKw7jbur4f+E1KKKpA= X-Google-Smtp-Source: AA6agR7awV28A8GFlOqP8EMOm3gwrL/ylD9ZFMMEnI72iN/QFjWSAFyzuqanhGFK9yCQXMTjstNzFQ== X-Received: by 2002:a65:408b:0:b0:42a:55fb:60b0 with SMTP id t11-20020a65408b000000b0042a55fb60b0mr22418817pgp.431.1661957543649; Wed, 31 Aug 2022 07:52:23 -0700 (PDT) Received: from hyeyoo ([114.29.91.56]) by smtp.gmail.com with ESMTPSA id i63-20020a626d42000000b00537b8aa0a46sm11571093pfc.96.2022.08.31.07.52.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Aug 2022 07:52:22 -0700 (PDT) Date: Wed, 31 Aug 2022 23:52:15 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Feng Tang Cc: Andrew Morton , Vlastimil Babka , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Roman Gushchin , Dmitry Vyukov , Dave Hansen , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Robin Murphy , John Garry , Kefeng Wang Subject: Re: [PATCH v4 1/4] mm/slub: enable debugging memory wasting of kmalloc Message-ID: References: <20220829075618.69069-1-feng.tang@intel.com> <20220829075618.69069-2-feng.tang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220829075618.69069-2-feng.tang@intel.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661957544; a=rsa-sha256; cv=none; b=FFbYuQ13s5R88hBRQx7Uf3WlgVAGG6gB0D0rcZfD4PMJZIttjAclLtPVUiEMDfLuwOpK8X nmFvQw/6oj16nlRyNThQWT2Po1HvNgTrLsyaIGdyh8TuQXxk0k5yJxUV2ieOlU0w8tzhOX b6WXFIVJS1Xh4lxpO0sbOH0UJTordkk= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=cQxyBMvv; spf=pass (imf20.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.210.173 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661957544; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Gf8tbj4RpGeuppvSON/HSM0Glqk0yYviXDuhJFMb/GU=; b=t4cShOyOBRiwcVVMAK24E1NjnVRpb3NPkTgMFV88jws2eR7hATQMnukxx+JuHtnbSpVORz CN3nI0rY6uVR4hXrgaroj68x0lUcjEyTE2mfBFsUjAFskkVSzt0Fv8wKe4YxMj5lk3dj+H bAa23X3R3WTufu6oMUrpTzEoxyb/zpE= X-Rspam-User: X-Stat-Signature: zb4udccafpd1e4gs7u93pajcqkieskjs X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: D66E81C005B Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=cQxyBMvv; spf=pass (imf20.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.210.173 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1661957544-846187 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 29, 2022 at 03:56:15PM +0800, Feng Tang wrote: > kmalloc's API family is critical for mm, with one nature that it will > round up the request size to a fixed one (mostly power of 2). Say > when user requests memory for '2^n + 1' bytes, actually 2^(n+1) bytes > could be allocated, so in worst case, there is around 50% memory > space waste. > [...] > static void *___slab_alloc(struct kmem_cache *s, gfp_t gfpflags, int node, > - unsigned long addr, struct kmem_cache_cpu *c) > + unsigned long addr, struct kmem_cache_cpu *c, unsigned int orig_size) > { > void *freelist; > struct slab *slab; > @@ -3115,6 +3158,7 @@ static void *___slab_alloc(struct kmem_cache *s, gfp_t gfpflags, int node, > > if (s->flags & SLAB_STORE_USER) > set_track(s, freelist, TRACK_ALLOC, addr); > + set_orig_size(s, freelist, orig_size); > > return freelist; > } > @@ -3140,6 +3184,8 @@ static void *___slab_alloc(struct kmem_cache *s, gfp_t gfpflags, int node, > */ > if (s->flags & SLAB_STORE_USER) > set_track(s, freelist, TRACK_ALLOC, addr); > + set_orig_size(s, freelist, orig_size); > + > return freelist; > } Maybe we can move set_track() and set_orig_size() to after slab_post_alloc_hook(). something like alloc/free hooks for debugging caches? (and drop orig_size parameter.) Thanks! > > @@ -3182,7 +3228,7 @@ static void *___slab_alloc(struct kmem_cache *s, gfp_t gfpflags, int node, > * pointer. > */ > static void *__slab_alloc(struct kmem_cache *s, gfp_t gfpflags, int node, > - unsigned long addr, struct kmem_cache_cpu *c) > + unsigned long addr, struct kmem_cache_cpu *c, unsigned int orig_size) > { > void *p; -- Thanks, Hyeonggon