From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2516FECAAD1 for ; Tue, 30 Aug 2022 15:32:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8C0FE6B0074; Tue, 30 Aug 2022 11:32:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 86FBF6B0075; Tue, 30 Aug 2022 11:32:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 737888D0001; Tue, 30 Aug 2022 11:32:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6021B6B0074 for ; Tue, 30 Aug 2022 11:32:56 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 3BB38C0117 for ; Tue, 30 Aug 2022 15:32:56 +0000 (UTC) X-FDA: 79856651952.03.2945512 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf31.hostedemail.com (Postfix) with ESMTP id DBEED2004C for ; Tue, 30 Aug 2022 15:32:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661873574; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aGqhem2itSKaHrjC4BlyXRFM6q06nnYLdNlc5n073Fk=; b=X7AmBCXiXc0QYDklMOMf2KPUFDb4V8Cr59pF2qMV1lfneKvyvQbVoGtEGYuo/a60K98TTQ 5pJde2ElboxAHcjopSK1TAjuBv5Wh8GZ1CEJ9cK1DfVGXJ+jzztbPGZM5JFgbe78nPJxcO XUQrsgxGz7ybiyHQdscxfZI25jnafNc= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-58-XsDRBZe5Oa6JzcJ5QGGD9A-1; Tue, 30 Aug 2022 11:32:53 -0400 X-MC-Unique: XsDRBZe5Oa6JzcJ5QGGD9A-1 Received: by mail-qk1-f198.google.com with SMTP id ay10-20020a05620a178a00b006bbcab9d554so9481962qkb.13 for ; Tue, 30 Aug 2022 08:32:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=aGqhem2itSKaHrjC4BlyXRFM6q06nnYLdNlc5n073Fk=; b=j3vswmehTLcateMztqvu7EYkCm6AcHNyl39GAPtsK5PTdPI3FavNJCWqGctTVxB3rm 0qZKkR/LK+wl2armxdOueUra4WuEzdNRQ2f/l8ng07o6WjB6d4kqpZQ1V1CNh/hnn8qk sBphC/NoSf4GIsriCPnPqwDA90ET9iPKt4SHNwgS0TOmpX8b3yZdf9gSYE9j19SpQphi 10L6zXjk7Cq+AWiitVdF/CTKavfLVGZtcY6NTZWDfSqsEDnFboizvRWD7T7vDWmY57tf mT+OvYNvYz8YyffofVjNXkQ2Rqm6GgLAjRlX3LVCv3QhKi/vbe9J3ZlYr6rKLVnnBZO4 T0cg== X-Gm-Message-State: ACgBeo1ECB36xb7ZfZCFzYHIS4pyuJk9lgJADmevY/EIuOU6VpMnY3nt EGE1pVUwO1AzPxPjeTI1NyTQxIrnei6U1q4oAlooeSE8Tz/Jnfn3N9z+PgAhD1TlkTTDVT6C1JX tba2rw7FdCbA= X-Received: by 2002:ac8:7dca:0:b0:344:5679:2dbb with SMTP id c10-20020ac87dca000000b0034456792dbbmr15123551qte.245.1661873572778; Tue, 30 Aug 2022 08:32:52 -0700 (PDT) X-Google-Smtp-Source: AA6agR48Go2NEknJ0fsb7/1Yh1FeRyl0H1a/lXTbzznE52uHXow7lceifYMWxr1HqYa+SXW/SpB8ig== X-Received: by 2002:ac8:7dca:0:b0:344:5679:2dbb with SMTP id c10-20020ac87dca000000b0034456792dbbmr15123523qte.245.1661873572555; Tue, 30 Aug 2022 08:32:52 -0700 (PDT) Received: from xz-m1.local (bras-base-aurron9127w-grc-35-70-27-3-10.dsl.bell.ca. [70.27.3.10]) by smtp.gmail.com with ESMTPSA id ga20-20020a05622a591400b00342fa1f4a10sm6785437qtb.61.2022.08.30.08.32.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Aug 2022 08:32:51 -0700 (PDT) Date: Tue, 30 Aug 2022 11:32:49 -0400 From: Peter Xu To: Alistair Popple Cc: Andrew Morton , David Hildenbrand , linux-mm@kvack.org, John Hubbard , Ralph Campbell Subject: Re: [PATCH v2] mm/migrate_device.c: Fix a misleading and out-dated comment Message-ID: References: <20220830020138.497063-1-apopple@nvidia.com> MIME-Version: 1.0 In-Reply-To: <20220830020138.497063-1-apopple@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661873574; a=rsa-sha256; cv=none; b=INhJoa+tFWvPEGaygkSvU+FSdrq0Uy2kQK0we/0nfmYKXS8gg+YHwYg5ZyI8xsXJsqX4iq PnR+zikPN4DN2JituMBE9+C70dc7TILzIqAc/BuHek8LgOafFSqROXbhnbEcFU1b4vPazy 0aiksb5z5hLikmg+SPJ75gO4mp/rWKs= ARC-Authentication-Results: i=1; imf31.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=X7AmBCXi; spf=pass (imf31.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661873574; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aGqhem2itSKaHrjC4BlyXRFM6q06nnYLdNlc5n073Fk=; b=wfar9JVUhXbdxyHNKE3ay+D7DYjlsFsB972R5OvGJht2YnifwC3pO2fmCrXm+HtafoNBlS WRwcFwSu12w0np2mZcG4Nw2buLvEJC6F2tPmSD9VbtwZS0w5S6y7MRPexmZX/WGWA+FHhu lB42UnftcZenBSIHTnk736bgHn0EejY= X-Rspam-User: Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=X7AmBCXi; spf=pass (imf31.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Stat-Signature: ksd15kqpon1465r94qa3wwycdntfcmde X-Rspamd-Queue-Id: DBEED2004C X-Rspamd-Server: rspam10 X-HE-Tag: 1661873574-807172 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 30, 2022 at 12:01:38PM +1000, Alistair Popple wrote: > Commit ab09243aa95a ("mm/migrate.c: remove MIGRATE_PFN_LOCKED") changed > the way trylock_page() in migrate_vma_collect_pmd() works without > updating the comment. Reword the comment to be less misleading and a > better reflection of what happens. > > Signed-off-by: Alistair Popple > Reported-by: Peter Xu > Fixes: ab09243aa95a ("mm/migrate.c: remove MIGRATE_PFN_LOCKED") Acked-by: Peter Xu Thanks, -- Peter Xu