From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6754ECAAD1 for ; Tue, 30 Aug 2022 06:30:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 276C16B0073; Tue, 30 Aug 2022 02:30:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 226CE6B0074; Tue, 30 Aug 2022 02:30:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A0D9940007; Tue, 30 Aug 2022 02:30:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id EFC776B0073 for ; Tue, 30 Aug 2022 02:30:40 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C8FB680E5C for ; Tue, 30 Aug 2022 06:30:40 +0000 (UTC) X-FDA: 79855285440.07.8E15023 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf24.hostedemail.com (Postfix) with ESMTP id 48A03180021 for ; Tue, 30 Aug 2022 06:30:40 +0000 (UTC) Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 27U0crHS007950; Tue, 30 Aug 2022 06:30:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : content-type : mime-version; s=corp-2022-7-12; bh=W3KpYgpG7gZiY74W/prWW9dQm0Rui4qdD5P0+lvWZtM=; b=o83oWZhcp5Pu2bGjzTj+2frr+UQZ9Ed35PpILF4TKYL1fsqbKCIaJU0EK2iLyuVdzivw 115EuoG0BxFvhbhdP4bnIH1yFNRF2mGGrj2kPQ7+oM3Vu+b4Q4Sjcp3TFSbeWiXQ4rMN 6+YKpkpTfn43yprIWecjNDHRJplINcKfEkmwP7lHQ9jPVSJOylmyixC7VftXBIVzw3QS vZsZ2q2WVDt/2gGCNXKDBz7hi6oxNR7+uJKGbw6CVcYjobnfAzXtK1u6jXkzlG9uL5B0 R8Rq275T6SEIcKxA3pSe0DJC2BJhPTYqoS/TRjoJg9Ti/aMEJtbgbr2bkAbEjrh74BHU ww== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3j7btt5aur-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 30 Aug 2022 06:30:38 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 27U5aAd4018617; Tue, 30 Aug 2022 06:30:38 GMT Received: from nam04-dm6-obe.outbound.protection.outlook.com (mail-dm6nam04lp2041.outbound.protection.outlook.com [104.47.73.41]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3j79q3n5gh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 30 Aug 2022 06:30:37 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G4yTHo5WaQlWUHGc6MXu46C7tFmC23WfJfnyZ/zPPVUyJARYKwy0L9oYII3hMiQPm0/ZABPj3huEvKxDQdopgXMrsXo5JZP9G6rWau+DVul7Ly6I8Y1/iknOWegsXYogPXxYEW+42yPQZGNk5aFRMW0EqJCo0BDEg0VG+NvCUVS0famkzaAY4fwvmb9oME+XtlMmNUFPWHCXk8d1X2q8eLL2X//B7E7TAWkDKEO4MmzW/+TIFIZYjRLUNdPFucQ4UgV6tMWDPwHya3OLJFfxruS1C1JP08Q516KWU2JDDudgD+SNiGITL1ANLK2Za9TXoHfRKfDDwU9bzvyLOoNH7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W3KpYgpG7gZiY74W/prWW9dQm0Rui4qdD5P0+lvWZtM=; b=lWUdOSwQ6TpLB+DdkWn603duGHT+5JCUMfk79yFKQ0XJgKRgeY3rc/6HfCDWxz1WotkYoQ5VZvNYDYslka4q8pmqllQb5z8OMLPlhfK5CfOOuz2cAoyCAwr9qjAM5SS5ieej7abK3jFiLx9LjSNSRc2R0zQ1WpnzlrTQeeXQ14B+3chg6L9FkpihnVXAI3xZS9zAu+1H6M4HkLfzUgxvw4vH3b/yFvjWmyfO55GcEFpqf4eQ+fT1Jz73qNKIm1AmGCL7scKjVTddLk6zOImnlVbcdpdK0uWjmgl3sUtf7DKS/W4jADoOAUTSstHr3ICFshyZ9H4SUuReYPM96KKlFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W3KpYgpG7gZiY74W/prWW9dQm0Rui4qdD5P0+lvWZtM=; b=ZJzSlb2cQ/UYHBc39NrNDUOhQBQO/IhV0ix5oNDhIk4wjQdVGbOZ6OoWZvcP/VNOUCYN4KVAM7QNHgRx6RQVODwFT6MIFmHiKRgeqD8qeII7p1G2K1dii6BN2CeIg1mqZJzQSN2VKzEaecjxy3sMdln/j6/ndJc8Ob8EUUpmbd4= Received: from MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) by SN6PR10MB2831.namprd10.prod.outlook.com (2603:10b6:805:cd::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.14; Tue, 30 Aug 2022 06:30:35 +0000 Received: from MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::209e:de4d:68ea:c026]) by MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::209e:de4d:68ea:c026%3]) with mapi id 15.20.5566.021; Tue, 30 Aug 2022 06:30:35 +0000 Date: Tue, 30 Aug 2022 09:30:26 +0300 From: Dan Carpenter To: mhocko@suse.com Cc: linux-mm@kvack.org Subject: [bug report] mm: reduce noise in show_mem for lowmem allocations Message-ID: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-ClientProxiedBy: ZR0P278CA0159.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:41::8) To MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ee783568-00c8-4306-ca12-08da8a51258d X-MS-TrafficTypeDiagnostic: SN6PR10MB2831:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aLYf9+kT3i/vvfAYoIirkBUkWbuWBsTJOyFEgEVd0OsYtN0jIjc/tTdlekKPYbeSx2GjPYtuunhnCo1sGi6JWERt38NFl8XNmp++Z7ix+aVrLmYuZJmFCdGTVdV5iy8u79M9MKfV44SAoKNM/+A30qPcfyyPHotAH884IUGePjmyLhVXvQBu5EqYBnXf+/YmuF6CfDgpq/n1GX8cocL2WAnla9K7aOo8mqyo5ackRuTsQUz2M7tYRMjpd7pkioV3cBh4h1BwUke8ARI5EfMcX09NUkJIJeM1j60k82j1v5CTMlKXQn4d/Aakj6+tSzLPSfvHaPCSYqx5N7q3InN0a6sIFf3YrKMzXNv7NJv8ZZc2dy48+3lRNfPqcgKIkAswec6Gc5+7gphLOjQDfFUgxjZI8ntI8QlhIDOlp4HF8mM9+9m035GQfIS1g/3zCOTlmMj30UFv46DZjL6QuTsrFkvlNvXb+MgoEqe/KE8sKli6pN0X+OPhROD/hxWLQt2GmhZN/5D2xzG1TTW6kvwgiQ6oiFK0oMoZZh7SQtN/dPlNpsIDCUnVBi9Vg9bInoemZUIuasBvVPp5n5AciEbYXcA8LjPS9M1/QDsgHoOyLCbkAerfN98ATUdQ7UyxIMD54bQQqn9fkH7sbU+N1KBR9jHpZMFdYE7ZpbmCLKZjDSCLu8eBUYLiYTqAzT/JWee1UExh6GUDdWjCkcphEN5Y0I47jSzspB2nh/JOOGa/ZeJ/lCLEhE8mcZLxpPyq4rS0nVrLMSCSjB8bN14t+yH7nQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2365.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(7916004)(136003)(366004)(346002)(376002)(39860400002)(396003)(316002)(6916009)(8676002)(66476007)(86362001)(66556008)(6486002)(4326008)(66946007)(478600001)(5660300002)(41300700001)(8936002)(6666004)(33716001)(38350700002)(44832011)(38100700002)(6506007)(2906002)(52116002)(83380400001)(26005)(9686003)(186003)(6512007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0vBHm7PC78K39Y4A6VQe/IaQrxQmE5z+5Mv8Qx9YcNIj2XTbQBxAzOM+eSZ6?= =?us-ascii?Q?S7JcB9mBwFN18bWmervucowMgyhN/Xg9nYXlF8ZVzdn+4Q+rf7Ei4s6G2zA6?= =?us-ascii?Q?YFH+lHa0zoKLgsHe4MSTHWWBYqQTQurpza3ZEZkqLqOrwnSil646Kjkwd2Qx?= =?us-ascii?Q?jc6fnI0yanSM/kgQgJbfzygA3fxluiJnfQ9OnYnTIn6kc/w4zd4OFawu5xgg?= =?us-ascii?Q?qmwtBy2YnCaFYP0EhdymKj7YvwyuWkesMZ7mlLJuzsb/m9FfRpwSgSCaQgUK?= =?us-ascii?Q?TqR5lU0QWi2XzrE4Dfv/SGi5CTwfMCaj4rJEo9A11/7OiTOrDVCIpKbI5g38?= =?us-ascii?Q?rfUEAIzHM3MpT3fEbTSKxS8D9Qr+mBBbYxGXA8+tqd2YVc1lXPlga72I+2ny?= =?us-ascii?Q?0H0HKXwncQ89AG0+adfNe+xDgwyUCA1i13QtISon6Rfm3FN6q2boVUZpJeTI?= =?us-ascii?Q?G1RvIxSajQAEYFRKba1VebJ1L8NL8iNbiePZsJNriW61ScXRVOkmXV13C5rR?= =?us-ascii?Q?5K13yfzjouJWflWouH+tmTXRpId/Rs6+uRxevsy7kBO4auKOzWf+W/tUJXLg?= =?us-ascii?Q?uWu3oKbjUUm3+lDCIQKguZLw2Y669uW7/XBu1Gg5w4npXeHD9PFcnsNHuI84?= =?us-ascii?Q?RyOrDCMETeNTsOg8MFDaQM7l5EBrZAEqcjs3n9T93Jb1VIOZXzkH+INJu3wV?= =?us-ascii?Q?1AnqjGAABhan6S9dd2jznP1AXHcr2klto2PWfGamykhFAPkpl1GSh++MRphO?= =?us-ascii?Q?b8WTITVeB5AFaZBbFLIxEP6pUERGv6Y5II2s1+n4UdwULMOEi4sTwIFAoTyf?= =?us-ascii?Q?bMZ5p10DwXub4QFZawx+Fv8RKLpH+Fm/4fc2tg7iNVujRP7ntRfgIhChbi8L?= =?us-ascii?Q?yQKoMe3WgAve8y2VxRs27VXK13M2QFaBUzDHnIKdUsWKs39H1vAegBqrXq96?= =?us-ascii?Q?kwB2nHKAFHpVYTrC5OhWEc35o9s/fbX0ToEnsyONDRnKOLxyBU7TYot4pM2G?= =?us-ascii?Q?czULzQtjHf6dUTumU1Gy3QUnSrl2NM3nYSt3LyxJnVFAVTu8NKYddYeiEMz2?= =?us-ascii?Q?evAPdclWxLwAInvMbPLQFeQkbmrVsA5SpMYDsSw6UAjTdGSYezHrK9s4DTRS?= =?us-ascii?Q?jtkEf/551J53k5fevyX9ZNyDm4ujkf4FNGh6WXGZZiCPPuhB758LS/AVLRAX?= =?us-ascii?Q?c+5rmcOkNd6jRG5kmI78jXLt01ZSmB5UXOHrwX4nF7feltT8MwkhOxFuf15W?= =?us-ascii?Q?g/hrfgLA5nKxsFQqQcHnNQIfgTNmZN9iphiRdwIbuya+4OmbpHR8x7TBF+9B?= =?us-ascii?Q?eepdTbVjw9V6gRWrfyTNpiqGW09OUbpz0gKi6h9/ehmhYUMySPfeayeEZj0e?= =?us-ascii?Q?rnrdfPF5N5aAXKa7n4pMziGmKTujn+Vt1NcSE9GEfZzHyOmuk6YRY7P4jCeI?= =?us-ascii?Q?H6CYzSSta5llNkUsjKcTIRbNQiWw0LW+B9ICwRYrMkE7YWjvki1s8XbWgXCW?= =?us-ascii?Q?d2coxZx+AUywy6+Sh0+HculT6hoFGhd7mxMpCmO8MPu4DHVlQcKGKzDp83vT?= =?us-ascii?Q?g8XV7i8UC3mZSzU8OrV3vrAc5+6NpxSMJF54Pp7cjm1PYlNGT27PmSuG9Ihg?= =?us-ascii?Q?pg=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: ee783568-00c8-4306-ca12-08da8a51258d X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Aug 2022 06:30:35.7442 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: K6h1lqndBWaKEiS5AElfsil2GJsTLz0UUD2Dqbrbi9qb/7Nz+DD3PbUnwQIT0YszWBgIEBgJuvHvPifu+sVR9ur8norCdN2ycMrr+vrbooU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR10MB2831 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-08-30_02,2022-08-25_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 malwarescore=0 spamscore=0 adultscore=0 mlxscore=0 mlxlogscore=768 suspectscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000 definitions=main-2208300030 X-Proofpoint-ORIG-GUID: r0I1yx8YNV7hxDFXU745JlDZsPky1Bzt X-Proofpoint-GUID: r0I1yx8YNV7hxDFXU745JlDZsPky1Bzt ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1661841040; a=rsa-sha256; cv=pass; b=URkDClyalgPJ74/TEikCMWeLn3YUbv5nFYSMck1q3lCfLkeEPlbL+KvW7AXwZ6UZuB4pnu m3BAM2cXV6uYjkhXAu1rgti4YGrzNO7jVE/Ylh2M63j0Hvszoc4McVuL4QNHKJXvnoTBJ+ O7WRe8zYV/DiSXpplm3bSBfNTEsCUC8= ARC-Authentication-Results: i=2; imf24.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2022-7-12 header.b=o83oWZhc; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=ZJzSlb2c; spf=pass (imf24.hostedemail.com: domain of dan.carpenter@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=dan.carpenter@oracle.com; dmarc=pass (policy=none) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661841040; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=W3KpYgpG7gZiY74W/prWW9dQm0Rui4qdD5P0+lvWZtM=; b=SfApo2V3PvVjhzi5Z77ZnmxMNFnnoqTuu7lFz/PMpSXKQWkomChR4Gbb035dfA8EQSUG9I P6ETpJCKs0sKSKj2Nb/gzXm7U7glA5QjCAxikCMr+cOAWH50rlcSr6B1RZHpaL1tpJlr0E 3LX01oaHcv+SbfngchOc4mY2ShE7sQ8= Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2022-7-12 header.b=o83oWZhc; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=ZJzSlb2c; spf=pass (imf24.hostedemail.com: domain of dan.carpenter@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=dan.carpenter@oracle.com; dmarc=pass (policy=none) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") X-Rspamd-Server: rspam05 X-Stat-Signature: hsonyryhpj11wrztrrhxrdr7yed3xp8x X-Rspamd-Queue-Id: 48A03180021 X-Rspam-User: X-HE-Tag: 1661841040-436431 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello Michal Hocko, The patch e8fedfea3dea: "mm: reduce noise in show_mem for lowmem allocations" from Aug 23, 2022, leads to the following Smatch static checker warning: kernel/panic.c:190 panic_print_sys_info() warn: sleeping in atomic context kernel/panic.c 175 static void panic_print_sys_info(bool console_flush) 176 { 177 if (console_flush) { 178 if (panic_print & PANIC_PRINT_ALL_PRINTK_MSG) 179 console_flush_on_panic(CONSOLE_REPLAY_ALL); 180 return; 181 } 182 183 if (panic_print & PANIC_PRINT_ALL_CPU_BT) 184 trigger_all_cpu_backtrace(); 185 186 if (panic_print & PANIC_PRINT_TASK_INFO) 187 show_state(); 188 189 if (panic_print & PANIC_PRINT_MEM_INFO) --> 190 show_mem(0, NULL, GFP_HIGHUSER_MOVABLE); ^^^^^^^^^^^^^^^^^^^^ This obviously seems very deliberate and a lot of weird stuff happens during panic(). But the panic() function disables preemption so shouldn't this be GFP_ATOMIC? GFP_HIGHUSER_MOVABLE has __GFP_RECLAIM and triggering swap during a panic seems bad. 191 192 if (panic_print & PANIC_PRINT_TIMER_INFO) 193 sysrq_timer_list_show(); 194 195 if (panic_print & PANIC_PRINT_LOCK_INFO) 196 debug_show_all_locks(); 197 198 if (panic_print & PANIC_PRINT_FTRACE_INFO) 199 ftrace_dump(DUMP_ALL); 200 } regards, dan carpenter