From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEB7BECAAD1 for ; Wed, 31 Aug 2022 19:28:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5DDCA8D0001; Wed, 31 Aug 2022 15:28:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5660A6B0073; Wed, 31 Aug 2022 15:28:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4062D8D0001; Wed, 31 Aug 2022 15:28:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2E16B6B0072 for ; Wed, 31 Aug 2022 15:28:09 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0B472ABBB1 for ; Wed, 31 Aug 2022 19:28:09 +0000 (UTC) X-FDA: 79860873498.30.0E81AD3 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf13.hostedemail.com (Postfix) with ESMTP id 4BF9220012 for ; Wed, 31 Aug 2022 19:28:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=COXA0nr8/oFAjzYFNBlfqg/PG216/XGX105MCvhb76o=; b=c2R+78d5nQboEOwjI+D7fNgadm kOANFOyyNZaHtxf7w5U4oXxDxFwJtrijKZ0ghhTjhKdRYLR0XgZ2jIwR7U1/1ZunGTMrw7UVtTTnJ 2CGIZXx/i3lEZvBL8iLrXVUU7CE+teYQHeOf9VSthRiAYY58leHEdeWrWW+F1YjkQkw7kr0SGEBjr ykIbWde2mJlgmeoGb2/XyvM3oYWq62W/rBoTD1KRNshtYM9xapcQlGaLxeMnbsCNtICbXBRa3Seaw 7Y73cwY9+zukhORcaLFUhaD33909paXr3eO8T9f7nkYh5ZQ4kffgafRDyH5TcolvPENUGHTjCAw/a cp2xZ9OA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oTTNW-005NTh-4E; Wed, 31 Aug 2022 19:27:58 +0000 Date: Wed, 31 Aug 2022 20:27:58 +0100 From: Matthew Wilcox To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, Peter Xu , Mike Kravetz , linux-mm@kvack.org, Andrew Morton Subject: Re: [PATCH v2] hugetlb: use mm.h instead of mm_types.h Message-ID: References: <20220831185739.21400-1-rdunlap@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220831185739.21400-1-rdunlap@infradead.org> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661974088; a=rsa-sha256; cv=none; b=XZnc0LZbMcQN1qJf1Q3AJaG3jreRegYU4Z0FvMK1OKZPP7JXI/2mQ/CrOVjEg4GFfTxBM1 +/hkRx4AouC/ZGu+gG0gcAb66YtNm2y+JEcEhx5FVD3z5KhdkeoUdw7mXAXopBCseag7Aj hMF7OTDfk/AoymHofAKxUayBVjcfOrc= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=c2R+78d5; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661974088; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=COXA0nr8/oFAjzYFNBlfqg/PG216/XGX105MCvhb76o=; b=qlZTMsWPyhmND2RwKYS7uv+W2EtNzxr/DhWfINL7KS34Hkm0Lg5RXkRmY+mZk5lAKYDkA8 v3QJhN3iRnr1uo6Pqus0AnzbXWnn2YsIc6ckLG6o6nBVtNrbDFCAhZ2fyZV+lBrTTJKNbm 24kQ2ioidAtl2mEAg4Ghr9cmRqmaa7M= X-Rspam-User: X-Stat-Signature: eaoqkipjkjxsh88y961e4j3yexqpfpo7 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 4BF9220012 Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=c2R+78d5; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-HE-Tag: 1661974088-513362 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 31, 2022 at 11:57:39AM -0700, Randy Dunlap wrote: > mm_types.h does not have zap_flags_t in it so use mm.h instead > in hugetlb.h. ... my copy of mm_types.h has zap_flags_t in it. Was it recently moved? Perhaps moving it back is a better solution to this problem? > Fixes this build error: > > In file included from ../drivers/virt/nitro_enclaves/ne_misc_dev.c:16:0: > ../include/linux/hugetlb.h:414:4: error: unknown type name ‘zap_flags_t’; did you mean ‘vm_flags_t’? > zap_flags_t zap_flags) > > Signed-off-by: Randy Dunlap > Cc: Peter Xu > Cc: Mike Kravetz > Cc: linux-mm@kvack.org > Cc: Andrew Morton > Reviewed-by: Peter Xu > --- > Fixes: mm-hugetlb-only-drop-uffd-wp-special-pte-if-required-fix.patch > v2: add Rev-by: Peter > drop the bogus S-o-b: in Cc: Peter Xu > > include/linux/hugetlb.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/include/linux/hugetlb.h > +++ b/include/linux/hugetlb.h > @@ -2,7 +2,7 @@ > #ifndef _LINUX_HUGETLB_H > #define _LINUX_HUGETLB_H > > -#include > +#include > #include > #include > #include >