From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED0B9C25B0E for ; Tue, 16 Aug 2022 20:35:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 08F8D8D0002; Tue, 16 Aug 2022 16:35:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 03EBE8D0001; Tue, 16 Aug 2022 16:35:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E214B8D0002; Tue, 16 Aug 2022 16:35:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D252F8D0001 for ; Tue, 16 Aug 2022 16:35:09 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A5AFC80379 for ; Tue, 16 Aug 2022 20:35:09 +0000 (UTC) X-FDA: 79806610338.28.60291C3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf06.hostedemail.com (Postfix) with ESMTP id CEACF1801A2 for ; Tue, 16 Aug 2022 20:35:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1660682108; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8qNWq56WcsAjV+d0DPWCWS43jEIePhWAAvwxxzNI+Yo=; b=PWUm55nNMex+zZxNub8oYd4hNMtzeQlNKTqQ1YjiwanSyO4hGdn5lKRA1ornHk/FsGXZBk kzRa2+2LZaz6Bb3Pssjnk6pxQaqf/1jM96Inrx+Hd4bdQXaBmyH8w3E2nzSa/owEWSVW2m swhjEbwVNDSA1eaPiHw7EBj0HY3cYUw= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-584-TpdtqXv3PP-fSNx6peWFWQ-1; Tue, 16 Aug 2022 16:35:07 -0400 X-MC-Unique: TpdtqXv3PP-fSNx6peWFWQ-1 Received: by mail-qv1-f70.google.com with SMTP id d10-20020a0cf6ca000000b00496744bc8e6so338902qvo.2 for ; Tue, 16 Aug 2022 13:35:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=8qNWq56WcsAjV+d0DPWCWS43jEIePhWAAvwxxzNI+Yo=; b=dTB/qE6EDinZlwo8stbRZE5c1hGDScUpXpJy5acnX9ZHW8tMVzpM4SPn1iFnVdWXhq +0qok3QHsae1QYECtgS4PL29hRymdplvPBO+YmfTpT1sGTv82aWmKrCvB+k52rXk0Gzc u7jSC5XBkcKHU79t6u6RztJjAYGRWY6wA249Izyk8UYRmVnp9e8NGyxuPEruOzNVRiph 5abx3VQuAl6YqQ8AKATQgg7RMcLuMaM/X7YWDEY48hKHLZQ7Qap5FX9wZYBEkt3leNMe hnzcLKagxXXnJeh7XrhUgBIb+oMXQZUCCZKnZNhFONzIewiSCsWcfvH5QOe+epNAR5WQ 9eEw== X-Gm-Message-State: ACgBeo26OU0KHc5rSn9RVMWqRNppj2E3MpakKB4acpHtDOg3b76+/uLA nRa782vWXQC/Nmmps1hz1Eitm07wNLZ6SPzuqKNK9ukpPGtS1J/RWrDwFW8gDIBSrC3/91bAgQ3 XZbcPx2PBvmw= X-Received: by 2002:a05:6214:2aa2:b0:477:1882:3dc with SMTP id js2-20020a0562142aa200b00477188203dcmr19064882qvb.11.1660682106689; Tue, 16 Aug 2022 13:35:06 -0700 (PDT) X-Google-Smtp-Source: AA6agR6sxNDlfRThn/rIz3JOnzmI+jYq7VbHmqoYMTVRKckqHUaSQxZWhXW5hA43Dz2DbrziOS2X+w== X-Received: by 2002:a05:6214:2aa2:b0:477:1882:3dc with SMTP id js2-20020a0562142aa200b00477188203dcmr19064852qvb.11.1660682106470; Tue, 16 Aug 2022 13:35:06 -0700 (PDT) Received: from xz-m1.local (bras-base-aurron9127w-grc-35-70-27-3-10.dsl.bell.ca. [70.27.3.10]) by smtp.gmail.com with ESMTPSA id l1-20020a05620a28c100b006b958c34bf1sm3222130qkp.10.2022.08.16.13.35.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Aug 2022 13:35:05 -0700 (PDT) Date: Tue, 16 Aug 2022 16:35:04 -0400 From: Peter Xu To: huang ying Cc: Alistair Popple , linux-mm@kvack.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, "Sierra Guiza, Alejandro (Alex)" , Felix Kuehling , Jason Gunthorpe , John Hubbard , David Hildenbrand , Ralph Campbell , Matthew Wilcox , Karol Herbst , Lyude Paul , Ben Skeggs , Logan Gunthorpe , paulus@ozlabs.org, linuxppc-dev@lists.ozlabs.org, Huang Ying , stable@vger.kernel.org Subject: Re: [PATCH v2 1/2] mm/migrate_device.c: Copy pte dirty bit to page Message-ID: References: <6e77914685ede036c419fa65b6adc27f25a6c3e9.1660635033.git-series.apopple@nvidia.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660682109; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8qNWq56WcsAjV+d0DPWCWS43jEIePhWAAvwxxzNI+Yo=; b=nurCRPRO1y/regNVPe6X88INp7oLEudcCI8rNq5slhr6l9oWjxMG//MFeeSWrb4nd1SGdQ nR52wdOHZCNPe8u2O0jkUdj9FDa2T3rK5e093Bok9xZOlcNmeg9Rc5bSE/5m9MX8kEhE7C PzlbmmsdOiGxJidNfcNJpDf4cUsxUbE= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PWUm55nN; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf06.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660682109; a=rsa-sha256; cv=none; b=0DS8fzrUbPrZMGitEgaJ/OYOv/V5IHBVfAWa8T8a7sqftxN86tTU3AKjDpsOoWcuLQhpWQ KndRLhoRERoF+m5+3VN4vPuTykJm5EHJ03ltj1FdtTt75y1QMhDgcZJ4NNwJpMg/ua2CLz CkSM6lyuIkKh7UaBWyPyeGIOan/lGSM= Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PWUm55nN; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf06.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com X-Rspam-User: X-Stat-Signature: zqmqnkwars7dqbgwbkbhi5nw8o4chq74 X-Rspamd-Queue-Id: CEACF1801A2 X-Rspamd-Server: rspam11 X-HE-Tag: 1660682108-766820 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 16, 2022 at 04:10:29PM +0800, huang ying wrote: > > @@ -193,11 +194,10 @@ static int migrate_vma_collect_pmd(pmd_t *pmdp, > > bool anon_exclusive; > > pte_t swp_pte; > > > > + flush_cache_page(vma, addr, pte_pfn(*ptep)); > > + pte = ptep_clear_flush(vma, addr, ptep); > > Although I think it's possible to batch the TLB flushing just before > unlocking PTL. The current code looks correct. If we're with unconditionally ptep_clear_flush(), does it mean we should probably drop the "unmapped" and the last flush_tlb_range() already since they'll be redundant? If that'll need to be dropped, it looks indeed better to still keep the batch to me but just move it earlier (before unlock iiuc then it'll be safe), then we can keep using ptep_get_and_clear() afaiu but keep "pte" updated. Thanks, -- Peter Xu