From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E0DCC00140 for ; Mon, 15 Aug 2022 21:26:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D05A18D0002; Mon, 15 Aug 2022 17:26:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CB54B8D0001; Mon, 15 Aug 2022 17:26:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BA39E8D0002; Mon, 15 Aug 2022 17:26:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A724E8D0001 for ; Mon, 15 Aug 2022 17:26:43 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7438940ED1 for ; Mon, 15 Aug 2022 21:26:43 +0000 (UTC) X-FDA: 79803111486.11.7C63E40 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by imf26.hostedemail.com (Postfix) with ESMTP id 1ADBB14002E for ; Mon, 15 Aug 2022 21:26:42 +0000 (UTC) Received: by mail-pl1-f172.google.com with SMTP id d10so7446464plr.6 for ; Mon, 15 Aug 2022 14:26:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=s6C7xjGZFgkJFr5KfYkyBRVqHeZGBiLrMu8lM2DAdGc=; b=AG3J8t9JIoa5aHNcIfU8Afi648JK1hym91JEPUZ0dSFr5Vu5y1F0zIWj3okus4yq7j 8SrjoNQWRS//nsxmvCMkWk5+ZtML4OympnohBF9ZypJ8vl3UZvWN6IWIIFXPyNQCw1PI ucQrEA19LX2XEiWOCgX4GP+56VU6Fg+OsQ8WCf2ae6sSq2c0PCH0rSS7aYW8rMg6949Y 46jOZtF9nXRcO3kDvuQpcCjcdnmbi6fI43+d2V1+EJk6zApr7+iOgtfTnxXurQoQ5YSI iZJ4cd/1gtdUwzdgm7U6lWdHkdrKAPobffvwMvfHC7Fh5oAzxw+sZQqSq2Mjlarza+pI 0NxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=s6C7xjGZFgkJFr5KfYkyBRVqHeZGBiLrMu8lM2DAdGc=; b=CUVcSAzm4t4V51IzrGmYlw06Ni1nC+ThZc6AS9/jJxHk/M9MEpSIpNoypyGHsEvgPR WLmnfI6rKUqTmpAFeInputMh9/c512UHKjfRajfnJy4HPVJANUyI/O6/9yIoR5yY4Pfk 2gkpSe11C2y7Zsaye9jo4RlSM5U2DGvoV7I6xbMaJTKnQjifWVtcXxrro35r/pLZCOQt ay63IQSjBOdtEKWrf9HohNw/E7IvwXUe27HwUgPLuMaxgKOxvoVQ25H0rS5bhuNAcK++ nGqbKU+q1rb0OrGFXgqO5jMrCgfNCcPf7ZsN9oawo50/cH0RY6TO4GyuD36XdUNBKE4s uXeA== X-Gm-Message-State: ACgBeo0j3lht3xOsG9mT5vKVBaIrF2xGRoy7XeXStVc1YdlIzqpxaBFY ev/y2o181HG3c78YznnbtE9QzQ== X-Google-Smtp-Source: AA6agR5M/rTTm9t+DDlIhUOT49cx0BFsQgd8Bv4U1FkQ3NT1pVtZbfkGUWydTZW3Wa2xY49yXK93gQ== X-Received: by 2002:a17:90b:164b:b0:1f5:15ae:3206 with SMTP id il11-20020a17090b164b00b001f515ae3206mr19855063pjb.140.1660598802001; Mon, 15 Aug 2022 14:26:42 -0700 (PDT) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id w12-20020a170902e88c00b0016a6caacaefsm7476713plg.103.2022.08.15.14.26.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Aug 2022 14:26:41 -0700 (PDT) Date: Mon, 15 Aug 2022 21:26:37 +0000 From: Sean Christopherson To: Peter Xu Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, David Hildenbrand , "Dr . David Alan Gilbert" , John Hubbard , Linux MM Mailing List , Andrew Morton , Paolo Bonzini , Andrea Arcangeli Subject: Re: [PATCH v2 3/3] kvm/x86: Allow to respond to generic signals during slow page faults Message-ID: References: <20220721000318.93522-1-peterx@redhat.com> <20220721000318.93522-4-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=AG3J8t9J; spf=pass (imf26.hostedemail.com: domain of seanjc@google.com designates 209.85.214.172 as permitted sender) smtp.mailfrom=seanjc@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660598803; a=rsa-sha256; cv=none; b=rY71GUVmFZA+5kl17RGyUIVQ255r3FGyVGUqmSsIkR66c1O7UnV3nBKX5vTnnHy/5T3iK5 V9ORRBfPqlP2dlncSOE2Z6DqE9u+dn/Nu2RlE/uDlUt5Pi/dP48Yica+tKRBzMXHTheC/o ANrS2WfPyr2NhrhCpp5Qs0hmSi+XSeg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660598803; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=s6C7xjGZFgkJFr5KfYkyBRVqHeZGBiLrMu8lM2DAdGc=; b=UKU+8IijuxCaVqSdWw/ITBxvFrsB2MjpgH9aIuTqf5FVHAnObq6l1VuEQaUCoNG82WRiqo jpghUX0oCV7MmnzFo8i30XSlAteZMhTT7EUdScuPDDRNI33uU+t0nbQaJo3BwGNXIOb38W GihOA9IPxNuRSfilFHwH4f9/l9ehCTk= Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=AG3J8t9J; spf=pass (imf26.hostedemail.com: domain of seanjc@google.com designates 209.85.214.172 as permitted sender) smtp.mailfrom=seanjc@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspam-User: X-Rspamd-Server: rspam12 X-Stat-Signature: hx9ymzoparrhcydnkbutngqccgentfrg X-Rspamd-Queue-Id: 1ADBB14002E X-HE-Tag: 1660598802-457282 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 11, 2022, Peter Xu wrote: > On Thu, Aug 11, 2022 at 08:12:38PM +0000, Sean Christopherson wrote: > > > diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c > > > index 17252f39bd7c..aeafe0e9cfbf 100644 > > > --- a/arch/x86/kvm/mmu/mmu.c > > > +++ b/arch/x86/kvm/mmu/mmu.c > > > @@ -3012,6 +3012,13 @@ static int kvm_handle_bad_page(struct kvm_vcpu *vcpu, gfn_t gfn, kvm_pfn_t pfn) > > > static int handle_abnormal_pfn(struct kvm_vcpu *vcpu, struct kvm_page_fault *fault, > > > unsigned int access) > > > { > > > + /* NOTE: not all error pfn is fatal; handle sigpending pfn first */ > > > + if (unlikely(is_sigpending_pfn(fault->pfn))) { > > > > Move this into kvm_handle_bad_page(), then there's no need for a comment to call > > out that this needs to come before the is_error_pfn() check. This _is_ a "bad" > > PFN, it just so happens that userspace might be able to resolve the "bad" PFN. > > It's a pity it needs to be in "bad pfn" category since that's the only > thing we can easily use, but true it is now. Would renaming that to kvm_handle_error_pfn() help? I agree that "bad" is poor terminology now that it handles a variety of errors, hence the quotes.