From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BA6BC2BB47 for ; Mon, 15 Aug 2022 13:33:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 971828D0002; Mon, 15 Aug 2022 09:33:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 921078D0001; Mon, 15 Aug 2022 09:33:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 80FCA8D0002; Mon, 15 Aug 2022 09:33:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 71CA48D0001 for ; Mon, 15 Aug 2022 09:33:46 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 39A5CC0DDA for ; Mon, 15 Aug 2022 13:33:46 +0000 (UTC) X-FDA: 79801919652.25.EAB14BC Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf02.hostedemail.com (Postfix) with ESMTP id 501E0801D4 for ; Mon, 15 Aug 2022 13:33:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=2tb0w40Fu2zdCcFs6ZUVcbW7rTOPIDoybVJIh3ibvtw=; b=ax+Wmnu+H069bkg0E2OOoboZVV Yhf2AhlnLFbvpIEs1VEenljURmrHzR6KISLtipuGpRZECX+cNYLgVUaCQqMs3Rhe63sWHx0C1E4EZ p2eK+C0haavPK72ewv/LS8vfvsudJXL9/tFaN9zMn5E+qPxcZswkA0MKOhwt61ARHb8GK5YSTNfQ3 G7wclSvc6cJr1jwPzOyiJdxnN48fm5a5s7JuVPxbLGnomHSwrCJ4A2++0qJjf5bF/QsNfAlOOLayN PMMeMD1uTGBJluyjd/46WaE6LGHKrVhyIfmdNzRrgXIVpyFH+MQIXta/+zS5kcs3+0XPSJdDGd1gK Xrw6eJYQ==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=worktop.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1oNaDg-005kle-SG; Mon, 15 Aug 2022 13:33:28 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id 168DE980153; Mon, 15 Aug 2022 15:33:28 +0200 (CEST) Date: Mon, 15 Aug 2022 15:33:27 +0200 From: Peter Zijlstra To: "Kirill A. Shutemov" Cc: Dave Hansen , Andy Lutomirski , x86@kernel.org, Kostya Serebryany , Andrey Ryabinin , Andrey Konovalov , Alexander Potapenko , Taras Madan , Dmitry Vyukov , "H . J . Lu" , Andi Kleen , Rick Edgecombe , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv6 04/11] x86/mm: Handle LAM on context switch Message-ID: References: <20220815041803.17954-1-kirill.shutemov@linux.intel.com> <20220815041803.17954-5-kirill.shutemov@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220815041803.17954-5-kirill.shutemov@linux.intel.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660570425; a=rsa-sha256; cv=none; b=nhAcYIIWv3zN0tZAPcu057tXYmPJZhTI+eG//rF402vl+t32uwBMXzpsJHxHV7aO+nMI9H keEamNExgQEjvDQBjggb9sZZ6bf+VE0DDxhcu7Hr84b1QwQWGRQfwXqAGn8JI6dh9YtW44 P8osyVKLeXrAwvOE0zDBjhIS1ckceJc= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ax+Wmnu+; dmarc=none; spf=none (imf02.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660570425; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2tb0w40Fu2zdCcFs6ZUVcbW7rTOPIDoybVJIh3ibvtw=; b=XJMlepG4OaLi7Oh6w+fRktMou64wA8dpqb/G9n1LsNASI/tZc+vBiGIwcH+op9T4qUVbXM EKo027Pv5H56l8t/fNbV5PzGpdhW5JrV5SavS0cqas19heI1ahKPZFzpYIKeZLUNWyas4Z td41dkqLSJAmcPfRtXC0UzzdvlZtnjM= X-Stat-Signature: ai65sdw7jmak4iq7fhrn1cfamftrakac X-Rspamd-Queue-Id: 501E0801D4 Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ax+Wmnu+; dmarc=none; spf=none (imf02.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1660570425-496190 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 15, 2022 at 07:17:56AM +0300, Kirill A. Shutemov wrote: > @@ -1071,8 +1082,10 @@ void flush_tlb_kernel_range(unsigned long start, unsigned long end) > */ > unsigned long __get_current_cr3_fast(void) > { > - unsigned long cr3 = build_cr3(this_cpu_read(cpu_tlbstate.loaded_mm)->pgd, > - this_cpu_read(cpu_tlbstate.loaded_mm_asid)); > + unsigned long cr3 = > + build_cr3(this_cpu_read(cpu_tlbstate.loaded_mm)->pgd, > + this_cpu_read(cpu_tlbstate.loaded_mm_asid), > + tlbstate_lam_cr3_mask()); My editor auto indents this as: unsigned long cr3 = build_cr3(this_cpu_read(cpu_tlbstate.loaded_mm)->pgd, this_cpu_read(cpu_tlbstate.loaded_mm_asid), tlbstate_lam_cr3_mask()); which (to me) is *much* clearer.