From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99607C00140 for ; Fri, 12 Aug 2022 18:12:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BC0168E0008; Fri, 12 Aug 2022 14:12:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B48398E0001; Fri, 12 Aug 2022 14:12:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9C2978E0008; Fri, 12 Aug 2022 14:12:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 866098E0001 for ; Fri, 12 Aug 2022 14:12:02 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 63299141CF8 for ; Fri, 12 Aug 2022 18:12:02 +0000 (UTC) X-FDA: 79791734484.29.CDEBFA7 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf20.hostedemail.com (Postfix) with ESMTP id 6028B1C01A3 for ; Fri, 12 Aug 2022 18:12:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=1kuZ1tf0B+TroFFOYxJQmWrPK3ACtUqm+sxQLEDf+/I=; b=eqfyJVBz1jub5Cndm+Sjr3uGO/ cI0jFJnGAwfur5rzLm8yfpIHG2eTGIgVEdV64OdKHt4InPL+ZD1kjFOj/WympEQWxHr8aEKx9DeSw sp5P5hKjo0jfFl8Jv1Ixb4drW/ktYtx9HYfyERk1fufyNJrabzSDWY8rG4bbAv8aZ9Lzs18ZQ+mvf 1KxAvyAkmEbx2CZhjad1/PnkFMCCzDAjTcreHBkWJaY4qKG1RZyeWBXK4l1e1nImvMumBt9Tv1cQA pVyZhbw7rm9/BPjsXwtYOtqGOuDb8Bg3pEn/92BSV0GQQQoIb5tCj/q10rU5iYt48f8k88zcoWNBJ HU4RcoMg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oMZ8T-002TUW-Iz; Fri, 12 Aug 2022 18:11:53 +0000 Date: Fri, 12 Aug 2022 19:11:53 +0100 From: Matthew Wilcox To: John Hubbard Cc: Alistair Popple , linux-mm@kvack.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, "Sierra Guiza, Alejandro (Alex)" , Chaitanya Kulkarni , Dan Williams , Felix Kuehling , Jason Gunthorpe , Logan Gunthorpe , Miaohe Lin , Muchun Song , Ralph Campbell , David Hildenbrand Subject: Re: [PATCH v4 1/2] mm/gup.c: Don't pass gup_flags to check_and_migrate_movable_pages() Message-ID: References: <487960bf67c7273ff5606c76f73bb51271bc7b90.1660269441.git-series.apopple@nvidia.com> <51d4408b-14f5-f6a8-80cf-d23cdb0a7c69@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51d4408b-14f5-f6a8-80cf-d23cdb0a7c69@nvidia.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660327921; a=rsa-sha256; cv=none; b=bm7O4xEB6XwH25ocPi5E16ByxvhiPS3HNherfQTN2pwmKJDfaCeDPgkw1C68Wxyr5czH+U WGx0m14rS/STkxyRgpUYwULmFMxkyb7s+eFk949NYWCyveagrBnts9QJG9+/9QlYmLFy5K PlU6DaB+l3v2kfzJjkntHXxc3+Epz6k= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=eqfyJVBz; dmarc=none; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660327921; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1kuZ1tf0B+TroFFOYxJQmWrPK3ACtUqm+sxQLEDf+/I=; b=MOExwDMJ3/g4nahuUUNfVPDTsRSOzjaniWbrPspsvnNemVAPRaXzOoH1TiQo+4FXlXhKYp u+f39/QAD2+q8h0M8PevHbveo+Its0M6wHY6Ot3P28Bb1LSfIZx6EOVzOBlN8Y/ixcDZOT oCIQydubYq8XQNOIzN0VFSBzfJkSUCk= X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 6028B1C01A3 Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=eqfyJVBz; dmarc=none; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Stat-Signature: jwphqsruqqyhyxx8opgeqbp9kdgexax1 X-Rspam-User: X-HE-Tag: 1660327920-477447 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Aug 12, 2022 at 11:02:42AM -0700, John Hubbard wrote: > On 8/12/22 05:57, Matthew Wilcox wrote: > > On Fri, Aug 12, 2022 at 12:13:08PM +1000, Alistair Popple wrote: > > > + get_page(&folio->page); > > > + unpin_user_page(&folio->page); > > > > https://lore.kernel.org/linux-mm/YvJddHPZsh7Lwzps@casper.infradead.org/ > > The above fix shows up in patch 2/2. I noticed during review that > it was applied to a different patch than the one you replied to, > but figured it didn't matter which patch picked up this fix, since > the problem precedes either patch. Oh! I didn't realise patch 2/2 changed the same lines. let me go and read 2/2.