From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 949B1C25B06 for ; Thu, 11 Aug 2022 21:23:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F1C706B0073; Thu, 11 Aug 2022 17:23:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ECBF36B0075; Thu, 11 Aug 2022 17:23:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D93C88E0001; Thu, 11 Aug 2022 17:23:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id CB3A66B0073 for ; Thu, 11 Aug 2022 17:23:20 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A4F1912192F for ; Thu, 11 Aug 2022 21:23:20 +0000 (UTC) X-FDA: 79788587760.28.E9FA244 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf15.hostedemail.com (Postfix) with ESMTP id CD297A018A for ; Thu, 11 Aug 2022 21:23:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1660252998; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EvXEqwnpgxBR5V37M69x7J1gz6DoDVNjLXtrplisCZQ=; b=Q+hf7fXGkzRqDZWhHjoW0+z305SRjbpSkPZs2DpE5teRvT+EfZymkRuOKeMpYoj2Npo13y fZcqW6TJtrAgPyTzXxAcin7/cRyeblVe/nwLmwna7QYa4UsAGeu1XrDQtj0W6LVxql9Vin Qy50ycZYICEetJmoTIWNojxk6/EgGAI= Received: from mail-il1-f198.google.com (mail-il1-f198.google.com [209.85.166.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-177-xlxOXDRjNLm6U0jc9bGWQg-1; Thu, 11 Aug 2022 17:23:17 -0400 X-MC-Unique: xlxOXDRjNLm6U0jc9bGWQg-1 Received: by mail-il1-f198.google.com with SMTP id d4-20020a056e02214400b002df95f624a4so12337868ilv.1 for ; Thu, 11 Aug 2022 14:23:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=EvXEqwnpgxBR5V37M69x7J1gz6DoDVNjLXtrplisCZQ=; b=N/qjUTYt5k+zFakswm4py5jk+rMRoJLntONavrLu7Gil8OaYBE8cFcnGhZR/8Q9dlP r9Xu75LuDtSwiJxqXHnPJS85SNwZ3A1P+Sdf+LfrbIJSzUkmtwEoS2FmeMYBFa/VC2Pw iK1kNqn9avIflWXr/aVQ/Wdw6a5uNh8B4W+Zzp4GJYzkQ1di/9cw9RT252apG1n2fYop 0At7WumhLGvzimvE4o13ih7HAuaK5w9YulwU22rieXB+sOAlsl5MIGLNumqnYITegNe2 E3oSJQMtNIAKGx14PGEWIMjtJ+ze8CgwZCnzqsZRYzdKTiDzKWU76SqtrNX5xNvtMrVY DAJA== X-Gm-Message-State: ACgBeo20Pd6Y0dL4jsCl8H26sCQ/0+CSqnAMoO+8J1DmUXQckq9dRgPq RQ7YjFtZHw4+mHcX0lB0pLqdMOocHguXHlF/Shg5i5eLXGgNITlRc/WpAka6+QQ/+TidtJ3E5mu E+HLaW3XVeTs= X-Received: by 2002:a05:6638:408a:b0:343:4e78:3d6d with SMTP id m10-20020a056638408a00b003434e783d6dmr580571jam.9.1660252996387; Thu, 11 Aug 2022 14:23:16 -0700 (PDT) X-Google-Smtp-Source: AA6agR50v/aovLGMB6cObagQV2vXH8mMuQeI2tmvoteP2TWYTc/0UBplSCwVrdq7os7G5z5WKJJZ4g== X-Received: by 2002:a05:6638:408a:b0:343:4e78:3d6d with SMTP id m10-20020a056638408a00b003434e783d6dmr580561jam.9.1660252996165; Thu, 11 Aug 2022 14:23:16 -0700 (PDT) Received: from xz-m1.local (bras-base-aurron9127w-grc-35-70-27-3-10.dsl.bell.ca. [70.27.3.10]) by smtp.gmail.com with ESMTPSA id n6-20020a056e021ba600b002de23b60e77sm154376ili.39.2022.08.11.14.23.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Aug 2022 14:23:15 -0700 (PDT) Date: Thu, 11 Aug 2022 17:23:14 -0400 From: Peter Xu To: Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, David Hildenbrand , Mike Rapoport , Mike Kravetz , Andrea Arcangeli , Nadav Amit , Axel Rasmussen Subject: Re: [PATCH] mm/uffd: Reset write protection when unregister with wp-mode Message-ID: References: <20220811201340.39342-1-peterx@redhat.com> <20220811141144.6aa509e68c5c7cd8b6c131b6@linux-foundation.org> MIME-Version: 1.0 In-Reply-To: <20220811141144.6aa509e68c5c7cd8b6c131b6@linux-foundation.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660252999; a=rsa-sha256; cv=none; b=2DN5ZC92zl6zbfIsFyhynTyoBoOycsYbkVF7lxFfDximWGeLg7ryAUaRn8nq9gZVPIr0cx mseQaQSUDI+tUZoEuTpFfHSx7zzYa9degO077rDRy5+8WfQvyZtNlD9PzE0CFv2uRluX7E lLGwIfEo9IGOZXo/Rb6NncPr+VyQMxE= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Q+hf7fXG; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660252999; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EvXEqwnpgxBR5V37M69x7J1gz6DoDVNjLXtrplisCZQ=; b=jydrDNJxtKkOTgnpAegst9CMG8TNwnBIqF3e8EXvm0S1/49B5NXca+boPT2CXWkMVHWdUO XlMjS9+wn2XPEy9uGN5OxrU2ve4kgjirBuZwhqIZeGH1FZPnoaumDmPF0iD/snQVkr9OSg IqMsuzZHvcbRSARqUgSt+4fiyrswSIs= X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: CD297A018A Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Q+hf7fXG; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com X-Stat-Signature: f7xnn1111su1ygtg1bc3a9goph3576uq X-Rspam-User: X-HE-Tag: 1660252998-706042 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 11, 2022 at 02:11:44PM -0700, Andrew Morton wrote: > On Thu, 11 Aug 2022 16:13:40 -0400 Peter Xu wrote: > > > I added a Fixes upon introducing of uffd-wp shmem+hugetlbfs because that's > > the only issue reported so far and that's the commit David's reproducer > > will start working (v5.19+). But the whole idea actually applies to not > > only file memories but also anonymous. It's just that we don't need to fix > > anonymous prior to v5.19- because there's no known way to exploit. > > I added a cc:stable to this. Thanks, Andrew. I'll remember to do so in future patches when Fixes apply. -- Peter Xu