From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A39D8C00140 for ; Wed, 10 Aug 2022 20:44:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E3496B0073; Wed, 10 Aug 2022 16:44:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 96C026B0074; Wed, 10 Aug 2022 16:44:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 80CD18E0001; Wed, 10 Aug 2022 16:44:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6BF396B0073 for ; Wed, 10 Aug 2022 16:44:21 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3EE1C4071E for ; Wed, 10 Aug 2022 20:44:21 +0000 (UTC) X-FDA: 79784860722.28.12D43EB Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf18.hostedemail.com (Postfix) with ESMTP id B2AF11C016D for ; Wed, 10 Aug 2022 20:44:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=2OvXf0xNBrC73fYE6Jm87Hbjynk6ZxeWJjR7VarX35Q=; b=gEODEB38kcppLQMxi1gGLTBcNG vPtqrQGHUkRiR6z40NXWr6mQEaG3SCllkR8BBz+NuAzZ/I6GTwxDhNTjm8LaKwLb9ot7PcDUfeP9B 4jA/9I21BcJiJe7B4ei0IH4v89wLgUTUg5XzPxirgD54exk/8BVbhpqQ/PyBX1m2R1tOT4StHcoM3 Tt6EyPgywRfMynTOoUS8fQ7wJF5nKTT2Rd20wh4a35VEEyFqpF0DnNkcN/DQrhVZ5ILVVspTxWy9L thdCit1bkMPm62iZTi56/jdjicr6r5syVPMQKtbZyuKGA8cEQUry1MujjCCyMsPnMT4BorAjTFVHj K/iU4Rag==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oLsYY-00HF0P-FL; Wed, 10 Aug 2022 20:43:58 +0000 Date: Wed, 10 Aug 2022 21:43:58 +0100 From: Matthew Wilcox To: Johannes Weiner Cc: Christoph Hellwig , Mel Gorman , Jan Kara , Bob Peterson , Andreas Gruenbacher , "Darrick J. Wong" , Damien Le Moal , Naohiro Aota , Vlastimil Babka , Johannes Thumshirn , cluster-devel@redhat.com, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: remove iomap_writepage v2 Message-ID: References: <20220719041311.709250-1-hch@lst.de> <20220728111016.uwbaywprzkzne7ib@quack3> <20220729092216.GE3493@suse.de> <20220729141145.GA31605@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660164260; a=rsa-sha256; cv=none; b=hb6wF6t4kdIordAiXQ+vUFMn20cRPaYKVIkIYo/u2s8e8ziqcf8m6O+WnUWS0ytnWHeO3j gDTaUEBxXFKN0KkRKeGiy6i+JCK3eme+XPGUHT53u5Td0B5/SPTe88Vk9A9fTACEPUSbsX /lkthW+aRkW2u9Zgx2al8YeyxH92H1A= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=gEODEB38; dmarc=none; spf=none (imf18.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660164260; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2OvXf0xNBrC73fYE6Jm87Hbjynk6ZxeWJjR7VarX35Q=; b=MALfl1SUyV8opKDPIIAcfX56L0pufuBsTvp9SsNu1lG25C4tCFo298dHeoZxPp3/CT+O8D 1fiYJFsrWQJJV2ch3skk3xqhX6Svp2dxBNkZVMV7vyfQe1Zol8aUHynMnIzesV76Zh8lt+ 3byCYOu37hmde/A5t2xpntG0E5nh6VY= X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: B2AF11C016D Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=gEODEB38; dmarc=none; spf=none (imf18.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Stat-Signature: 8o38j4xt9utq7wgbidgtosxtyqi9hnz9 X-Rspam-User: X-HE-Tag: 1660164259-975068 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 01, 2022 at 11:31:50AM -0400, Johannes Weiner wrote: > XFS hasn't had a ->writepage call for a while. After LSF I internally > tested dropping btrfs' callback, and the results looked good: no OOM > kills with dirty/writeback pages remaining, performance parity. Then I > went on vacation and Christoph beat me to the patch :) To avoid duplicating work with you or Christoph ... it seems like the plan is to kill ->writepage entirely soon, so there's no point in me doing a sweep of all the filesystems to convert ->writepage to ->write_folio, correct? I assume the plan for filesystems which have a writepage but don't have a ->writepages (9p, adfs, affs, bfs, ecryptfs, gfs2, hostfs, jfs, minix, nilfs2, ntfs, ocfs2, reiserfs, sysv, ubifs, udf, ufs, vboxsf) is to give them a writepages, modelled on iomap_writepages(). Seems that adding a block_writepages() might be a useful thing for me to do?