From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7B7DC25B07 for ; Wed, 10 Aug 2022 23:17:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 452EE6B0073; Wed, 10 Aug 2022 19:17:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 401E76B0074; Wed, 10 Aug 2022 19:17:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2C9568E0001; Wed, 10 Aug 2022 19:17:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 195CB6B0073 for ; Wed, 10 Aug 2022 19:17:45 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C347D40EE0 for ; Wed, 10 Aug 2022 23:17:44 +0000 (UTC) X-FDA: 79785247248.12.C6100A1 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf03.hostedemail.com (Postfix) with ESMTP id DEAA020178 for ; Wed, 10 Aug 2022 23:17:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=Mf4ac8fVspvGcWxrOWEut1SK8rLHEYFOaT0I3ndebsw=; b=r8Qym12JFF1vTWy+OxxpowZKqG cUI2jR9JvF5dzHgWiQCX5ryLuRYAfMmM7Hg78la9ARHn3JV2SPzM8OTdx2wkTbBgBBHaNuVOquOJF 3iQMAaU++310TWi52sNy+hx14cZjxzaiZFqVqcihkvcnRjOywnc0C1w2vKiKC8Z5Xdklfqdlyopak J7RJM8ig/pHce8N5tiRPnqQq8TZlk8kDt3nk7wFIDKqDD+dGomwLM/GFMd9mdIynioViWHDhrekhN +c+k9iuFCKf5xFEjpAP20cZJbfzBO5NuCHUqfukaMaMK/7l2rc1MyL5suK7pBByJI0FhnKrRITjQ+ YPY7HzBA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oLux1-00HOHQ-P6; Wed, 10 Aug 2022 23:17:23 +0000 Date: Thu, 11 Aug 2022 00:17:23 +0100 From: Matthew Wilcox To: Andreas =?iso-8859-1?Q?Gr=FCnbacher?= Cc: Johannes Weiner , Christoph Hellwig , Mel Gorman , Jan Kara , Bob Peterson , Andreas Gruenbacher , "Darrick J. Wong" , Damien Le Moal , Naohiro Aota , Vlastimil Babka , Johannes Thumshirn , cluster-devel , linux-xfs , Linux FS-devel Mailing List , Linux-MM Subject: Re: remove iomap_writepage v2 Message-ID: References: <20220719041311.709250-1-hch@lst.de> <20220728111016.uwbaywprzkzne7ib@quack3> <20220729092216.GE3493@suse.de> <20220729141145.GA31605@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660173463; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Mf4ac8fVspvGcWxrOWEut1SK8rLHEYFOaT0I3ndebsw=; b=KmCg9jGFMK6Sq+smTdM1+SLnse8OXf7JHjoKfsxhX1Z61InCJnfj+EkfomqdCVORiupOsL nbHmK+O3svchj42Erg1eiKpmpz8TqMlTbF7VcrV83MBRahHYma/e52yOkFNwYRlj7QJQhW IAu+vTri+iyI0uQDx5aZadiCy78A9oc= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=r8Qym12J; dmarc=none; spf=none (imf03.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660173463; a=rsa-sha256; cv=none; b=Kl3BBgrpl1pbUnn/tuhwPjGMQ9/C1ly2xdY5AJbs1msw/NHIo4IKTTY179JGKFjH5H2elp yDCKRBG+EShVF9MJ6UnturDwiVutVZUz4GG9qjteQ/Gd60V0HHJLlLcTHr4ULg2qcmY+7C 06DAmMDTeRxVnZchIpw7sxM3JS8bjGg= X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: DEAA020178 X-Rspam-User: X-Stat-Signature: mkmwgdkfkb7x4u6w7tx3sguzddtaa6d3 Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=r8Qym12J; dmarc=none; spf=none (imf03.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-HE-Tag: 1660173461-698902 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 10, 2022 at 11:32:06PM +0200, Andreas Grünbacher wrote: > Am Mi., 10. Aug. 2022 um 22:57 Uhr schrieb Matthew Wilcox : > > On Mon, Aug 01, 2022 at 11:31:50AM -0400, Johannes Weiner wrote: > > > XFS hasn't had a ->writepage call for a while. After LSF I internally > > > tested dropping btrfs' callback, and the results looked good: no OOM > > > kills with dirty/writeback pages remaining, performance parity. Then I > > > went on vacation and Christoph beat me to the patch :) > > > > To avoid duplicating work with you or Christoph ... it seems like the > > plan is to kill ->writepage entirely soon, so there's no point in me > > doing a sweep of all the filesystems to convert ->writepage to > > ->write_folio, correct? > > > > I assume the plan for filesystems which have a writepage but don't have > > a ->writepages (9p, adfs, affs, bfs, ecryptfs, gfs2, hostfs, jfs, minix, > > nilfs2, ntfs, ocfs2, reiserfs, sysv, ubifs, udf, ufs, vboxsf) is to give > > them a writepages, modelled on iomap_writepages(). Seems that adding > > a block_writepages() might be a useful thing for me to do? > > Hmm, gfs2 does have gfs2_writepages() and gfs2_jdata_writepages() > functions, so it should probably be fine. Ah, it's gfs2_aspace_writepage which doesn't have a writepages counterpart. I haven't looked at it to understand why it's needed. (gfs2_meta_aops and gfs2_rgrp_aops)