From: Michal Hocko <mhocko@suse.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Charan Teja Kalla <quic_charante@quicinc.com>,
david@redhat.com, pasha.tatashin@soleen.com, sieberf@amazon.com,
shakeelb@google.com, sjpark@amazon.de, dhowells@redhat.com,
willy@infradead.org, quic_pkondeti@quicinc.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH V3] mm: fix use-after free of page_ext after race with memory-offline
Date: Wed, 10 Aug 2022 09:23:30 +0200 [thread overview]
Message-ID: <YvNc8vuinnddc78j@dhcp22.suse.cz> (raw)
In-Reply-To: <20220809185714.5af7057c1270b11079cb196a@linux-foundation.org>
On Tue 09-08-22 18:57:14, Andrew Morton wrote:
> On Tue, 9 Aug 2022 20:16:43 +0530 Charan Teja Kalla <quic_charante@quicinc.com> wrote:
>
> > The below is one path where race between page_ext and offline of the
> > respective memory blocks will cause use-after-free on the access of
> > page_ext structure.
>
> Has this race ever been observed at runtime?
>
> Given the size of the fix, I'm looking for excuses to not backport it
> into -stable kernels!
I believe this is quite theoretical for two reasons
1) the memory hotplug (offlining) is quite rare operation
2) with all the retries the race window is quite hard to trigger
So this is good to have address long term but nothing really for stable
until somebody actually hits that with a real world workload.
Btw. I plan to have a look and review this but times are busy. Hopefully
soon.
Thanks!
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2022-08-10 7:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 14:46 Charan Teja Kalla
2022-08-10 1:57 ` Andrew Morton
2022-08-10 7:23 ` Michal Hocko [this message]
2022-08-10 8:27 ` Charan Teja Kalla
2022-08-10 11:40 ` Vlastimil Babka
2022-08-10 14:31 ` Charan Teja Kalla
[not found] ` <Yvpg6odyDsXrjw5i@dhcp22.suse.cz>
2022-08-15 15:26 ` Matthew Wilcox
2022-08-15 15:31 ` Michal Hocko
2022-08-16 9:34 ` Charan Teja Kalla
[not found] ` <YvvCpW0ep9N8CbDr@dhcp22.suse.cz>
2022-08-18 14:01 ` Charan Teja Kalla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YvNc8vuinnddc78j@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pasha.tatashin@soleen.com \
--cc=quic_charante@quicinc.com \
--cc=quic_pkondeti@quicinc.com \
--cc=shakeelb@google.com \
--cc=sieberf@amazon.com \
--cc=sjpark@amazon.de \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox